task #9617
closedRename ICNB to ICNP
100%
Description
Since certain time the code is better called ICNP. See https://en.wikipedia.org/wiki/International_Code_of_Nomenclature_of_Prokaryotes for details.
The current publication for the code: https://www.microbiologyresearch.org/content/journal/ijsem/10.1099/ijsem.0.000778 / https://doi.org/10.1099/ijsem.0.000778
Related issues
Updated by Andreas Kohlbecker almost 3 years ago
NOTE: this change in NomenclaturalCodeEdition
should not affect the name
of historic code editions which where originally published as ICNB. These names must be retained.
Updated by Andreas Kohlbecker almost 3 years ago
- Related to bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBN added
Updated by Andreas Müller almost 3 years ago
Andreas Kohlbecker wrote:
NOTE: this change in
NomenclaturalCodeEdition
should not affect thename
of historic code editions which where originally published as ICNB. These names must be retained.
NomenclaturalCodeEdition entry names are pure enum "names" not used for anything else. So we can rename them but there is no big need for this as they should never be shown to the user in anyway. Having all the same prefix has a certain advantage for sorting. Needs discussion.
This differs from NomenclaturalCode, where the abbreviation is also used as a title that is shown to users (but there we only use the current code abbreviation for pratical reasons.
This ticket is about NomenclaturalCode not NomenclaturalCodeEditon
Updated by Andreas Müller almost 3 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 50
Applied in changeset cdmlib|a918965a9529a628c997456fd5810338a2f7443f.
Updated by Andreas Müller almost 3 years ago
- Target version changed from CDM UML 5.43 to Release 5.25
Updated by Andreas Müller almost 3 years ago
- Status changed from Resolved to Closed
- % Done changed from 50 to 100
I tink this can be closed. ICNB/P is not yet really used anyway.
Updated by Andreas Kohlbecker almost 3 years ago
please consider the discussion in #9618 before closing this ticket, as the question there is highly related.
Updated by Andreas Müller almost 3 years ago
Andreas Kohlbecker wrote:
please consider the discussion in #9618 before closing this ticket, as the question there is highly related.
As explained in #9618 the need for an historic abbreviation (if required by users) should be handled as separate parameter, not by using enum names.
Also this ticket is about NomenclaturalCode not NomenclaturalCodeEditon.
The remaining discussion should be done at #9618. IMO there is no need to keep 2 tickets open for this.
But if phycobank (the only DB using the above mentioned feature) handles also names from ICNP we can temporarily revert the changes in NomenclaturalCodeEditon related to this ticket.
Updated by Andreas Müller almost 3 years ago
- Target version changed from Release 5.25 to Release 5.23