Project

General

Profile

task #9617

Rename ICNB to ICNP

Added by Andreas Müller 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
New
Category:
cdm
Target version:
Start date:
05/10/2021
Due date:
% Done:

100%

Severity:
normal


Related issues

Related to Edit - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBN Closed 05/10/2021

Associated revisions

Revision a918965a (diff)
Added by Andreas Müller 6 months ago

fix #9617 rename ICNB to ICNP in cdmlib

Revision 4488955c (diff)
Added by Andreas Müller 6 months ago

ref #9617 javadoc in rank class

Revision 182c851e (diff)
Added by Andreas Müller 6 months ago

ref #9617 update vaadin doc

Revision 6d6ca639 (diff)
Added by Andreas Müller 6 months ago

ref #9617 replace ICNB to ICNP in taxeditor

Revision 98e684f7 (diff)
Added by Andreas Müller 6 months ago

ref #9617 replace ICNB to ICNP in taxeditor (cont.)

Revision 7fd0cf17 (diff)
Added by Andreas Müller 6 months ago

ref #9617 rename ICNB to ICNP in cdmlib-app

Revision 084b31e9 (diff)
Added by Andreas Müller 6 months ago

ref #9617 change label for ICNP in taxeditor

Revision e4c6e7b3 (diff)
Added by Andreas Müller 6 months ago

ref #9617 javadoc adaptations

History

#1 Updated by Andreas Müller 6 months ago

  • Description updated (diff)

#2 Updated by Andreas Kohlbecker 6 months ago

NOTE: this change in NomenclaturalCodeEdition should not affect the name of historic code editions which where originally published as ICNB. These names must be retained.

#3 Updated by Andreas Kohlbecker 6 months ago

  • Related to bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBN added

#4 Updated by Andreas Müller 6 months ago

Andreas Kohlbecker wrote:

NOTE: this change in NomenclaturalCodeEdition should not affect the name of historic code editions which where originally published as ICNB. These names must be retained.

NomenclaturalCodeEdition entry names are pure enum "names" not used for anything else. So we can rename them but there is no big need for this as they should never be shown to the user in anyway. Having all the same prefix has a certain advantage for sorting. Needs discussion.

This differs from NomenclaturalCode, where the abbreviation is also used as a title that is shown to users (but there we only use the current code abbreviation for pratical reasons.

This ticket is about NomenclaturalCode not NomenclaturalCodeEditon

#5 Updated by Andreas Müller 6 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#6 Updated by Andreas Müller 6 months ago

  • Target version changed from CDM UML 5.29 to Release 5.25

#7 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

I tink this can be closed. ICNB/P is not yet really used anyway.

#8 Updated by Andreas Kohlbecker 6 months ago

please consider the discussion in #9618 before closing this ticket, as the question there is highly related.

#9 Updated by Andreas Müller 6 months ago

Andreas Kohlbecker wrote:

please consider the discussion in #9618 before closing this ticket, as the question there is highly related.

As explained in #9618 the need for an historic abbreviation (if required by users) should be handled as separate parameter, not by using enum names.
Also this ticket is about NomenclaturalCode not NomenclaturalCodeEditon.
The remaining discussion should be done at #9618. IMO there is no need to keep 2 tickets open for this.

But if phycobank (the only DB using the above mentioned feature) handles also names from ICNP we can temporarily revert the changes in NomenclaturalCodeEditon related to this ticket.

#10 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)