bug #9612
closedROLE_USER_MANAGER is missing as a group in FirstDataImporter
Added by Andreas Müller almost 3 years ago. Updated almost 3 years ago.
100%
Description
... for details see #9051
Or is it not wanted to have a group for this as default similar to Group_Project_Manager?
Related issues
Updated by Andreas Müller almost 3 years ago
- Subject changed from ROLE_USER_MANAGER is missing in FirstDataImporter to ROLE_USER_MANAGER is missing as a group in FirstDataImporter
- Description updated (diff)
Updated by Andreas Müller almost 3 years ago
- Status changed from New to In Progress
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- Priority changed from New to Highest
- % Done changed from 0 to 20
Updated by Andreas Müller almost 3 years ago
- Related to bug #9051: Role Project manager should not have right to edit users and creating a new user with missing rights results in two message-boxes added
Updated by Andreas Müller almost 3 years ago
- Related to feature request #9613: Use fixed uuids for roles project manager, publish and user manager added
Updated by Andreas Müller almost 3 years ago
- Status changed from In Progress to Resolved
- % Done changed from 20 to 50
Applied in changeset cdmlib|ee97649b15bfeb922508e97eec12aaecbd04535e.
Updated by Andreas Müller almost 3 years ago
- Assignee changed from Andreas Müller to Andreas Kohlbecker
This is fixed and can be reviewed.
Updated by Andreas Kohlbecker almost 3 years ago
- Status changed from Resolved to In Progress
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 50 to 40
implementation ok, the FirstDataInserterTest
however looks like it has never been implemented, seems like a copy of some other test.
Since you have changed some core code, I suggest to implement at least one test that covers addMissingAuthority()
Updated by Andreas Kohlbecker almost 3 years ago
Andreas Kohlbecker wrote:
implementation ok, the
FirstDataInserterTest
however looks like it has never been implemented, seems like a copy of some other test.
Since you have changed some core code, I suggest to implement at least one test that coversaddMissingAuthority()
I now see that there is another ticket (#9613) to which this rather refers to, please decide yourself in which context you want to deal with this.
Updated by Andreas Müller almost 3 years ago
- Status changed from In Progress to Resolved
- Assignee changed from Andreas Müller to Andreas Kohlbecker
The addMissingAuthority method is a private method that is explicitly tested in testBlankDB by the result dataset "FirstDataInserterTest.testBlankDB-result.xml". This is why I extended the result dataset. With this result dataset I don't think there is a need for testing the method explicitly. Before there was a need because the adding of the authority was tested nowhere.
Updated by Andreas Müller almost 3 years ago
But I also do not understand what the testInsertData() test method is for. It does not seem to be related to first data inserting. Should we remove it?
Updated by Andreas Kohlbecker almost 3 years ago
- Status changed from Resolved to Closed
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 50 to 100
Ja, die sollte weg, dass die hier keinen Sinn macht, meinte ich auch mit "seems like a copy of some other test."
Den Sinn der anderen Test-Methode habe ich nicht gleich erkannt da ich den Methodennamen falsch interpretiert hatte. Ich hab den leicht geändert und auch noch einen java doc Kommentar beigefügt.
Ich denke wir können das Ticket nun schließen
Updated by Andreas Müller almost 3 years ago
- Target version changed from Release 5.25 to Release 5.23