Project

General

Profile

bug #9612

ROLE_USER_MANAGER is missing as a group in FirstDataImporter

Added by Andreas Müller 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
05/07/2021
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

... for details see #9051

Or is it not wanted to have a group for this as default similar to Group_Project_Manager?


Related issues

Related to Edit - bug #9051: Role Project manager should not have right to edit users and creating a new user with missing rights results in two message-boxes New 06/03/2020
Related to Edit - feature request #9613: Use fixed uuids for roles project manager, publish and user manager Closed 05/07/2021

Associated revisions

Revision ee97649b (diff)
Added by Andreas Müller 6 months ago

fix #9612 add user manager as group to firstDataInserter

Revision 695765fe (diff)
Added by Andreas Müller 6 months ago

handle uuids explicitly and ref #9612 fix role user manager uuid

Revision 0c924588 (diff)
Added by Andreas Müller 6 months ago

ref #9613 use fixed role uuids for new GrantedAuthorities being roles and ref #9612 enlarge test data for FirstDataInserter

Revision 2771d5a7 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #9612 removing unrelated test method and clarifying the remainig test method

History

#1 Updated by Andreas Müller 6 months ago

  • Subject changed from ROLE_USER_MANAGER is missing in FirstDataImporter to ROLE_USER_MANAGER is missing as a group in FirstDataImporter
  • Description updated (diff)

#2 Updated by Andreas Müller 6 months ago

  • Status changed from New to In Progress
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • Priority changed from New to Highest
  • % Done changed from 0 to 20

#3 Updated by Andreas Müller 6 months ago

  • Related to bug #9051: Role Project manager should not have right to edit users and creating a new user with missing rights results in two message-boxes added

#4 Updated by Andreas Müller 6 months ago

  • Related to feature request #9613: Use fixed uuids for roles project manager, publish and user manager added

#5 Updated by Andreas Müller 6 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 50

#6 Updated by Andreas Müller 6 months ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

This is fixed and can be reviewed.

#7 Updated by Andreas Kohlbecker 6 months ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 50 to 40

implementation ok, the FirstDataInserterTest however looks like it has never been implemented, seems like a copy of some other test.
Since you have changed some core code, I suggest to implement at least one test that covers addMissingAuthority()

#8 Updated by Andreas Kohlbecker 6 months ago

Andreas Kohlbecker wrote:

implementation ok, the FirstDataInserterTest however looks like it has never been implemented, seems like a copy of some other test.
Since you have changed some core code, I suggest to implement at least one test that covers addMissingAuthority()

I now see that there is another ticket (#9613) to which this rather refers to, please decide yourself in which context you want to deal with this.

#9 Updated by Andreas Müller 6 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

The addMissingAuthority method is a private method that is explicitly tested in testBlankDB by the result dataset "FirstDataInserterTest.testBlankDB-result.xml". This is why I extended the result dataset. With this result dataset I don't think there is a need for testing the method explicitly. Before there was a need because the adding of the authority was tested nowhere.

#10 Updated by Andreas Müller 6 months ago

  • % Done changed from 40 to 50

#11 Updated by Andreas Müller 6 months ago

But I also do not understand what the testInsertData() test method is for. It does not seem to be related to first data inserting. Should we remove it?

#12 Updated by Andreas Kohlbecker 6 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 50 to 100

Ja, die sollte weg, dass die hier keinen Sinn macht, meinte ich auch mit "seems like a copy of some other test."

Den Sinn der anderen Test-Methode habe ich nicht gleich erkannt da ich den Methodennamen falsch interpretiert hatte. Ich hab den leicht geändert und auch noch einen java doc Kommentar beigefügt.

Ich denke wir können das Ticket nun schließen

#13 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)