Project

General

Profile

feature request #9611

Implement setSecundumForSubtree for MAN and ppSyns in TaxEditor

Added by Andreas Müller about 1 month ago. Updated 26 days ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
05/04/2021
Due date:
% Done:

80%

Severity:
blocker

Description

this is a follow up from #9601

Parameters are similar to setPublishForSubtree.

The labels should make clear that this is about err. sec. (MAN) and syn. sec (PP-Syn) and not about sensu (MAN) or sec. (PP-Syn)


Related issues

Related to Edit - bug #9390: Remaining issues for set secundum dialog Feedback 01/18/2021
Related to Edit - bug #9621: New Preference for Default of the SecundumForSubtreeConfigurator New 05/12/2021
Related to Edit - feature request #9622: Improve remoting progress monitor handling In Progress 05/13/2021
Follows Edit - bug #9601: Set secundum for subTree does not work for misapplied names Closed 05/03/2021

Associated revisions

Revision cfae30ae (diff)
Added by Katja Luther about 1 month ago

ref #9611: implement set secundum for MAN and pro parte syn

Revision a3247a01 (diff)
Added by Andreas Müller about 1 month ago

ref #9601, ref #9611 have only a single overwriteExisting parameter for setSecundumForSubtree

Revision a6b03e32 (diff)
Added by Andreas Müller about 1 month ago

ref #9601, ref #9611 by default don't include MAN and ppSyns for setSecundumForSubtree

Revision 7cbe1369 (diff)
Added by Andreas Müller about 1 month ago

ref #9601, ref #9611 by default don't include MAN and ppSyns for setSecundumForSubtree (cont.)

Revision 5fdf87f0 (diff)
Added by Katja Luther about 1 month ago

ref #9611: adapt taxeditor to changes in configurator

Revision 86f920de (diff)
Added by Katja Luther about 1 month ago

ref #9611: adapt handler to changes in method signatur

Revision 8e5f7864 (diff)
Added by Katja Luther 28 days ago

ref #9611: move use shared taxa to the general flags

Revision b2beda87 (diff)
Added by Katja Luther 26 days ago

ref #9611: more space between the specific and the general flags

History

#1 Updated by Andreas Müller about 1 month ago

  • Due date set to 05/04/2021
  • Start date changed from 05/06/2021 to 05/04/2021
  • Follows bug #9601: Set secundum for subTree does not work for misapplied names added

#2 Updated by Andreas Müller about 1 month ago

  • Related to bug #9390: Remaining issues for set secundum dialog added

#3 Updated by Andreas Müller about 1 month ago

  • Description updated (diff)
  • Due date deleted (05/04/2021)
  • Priority changed from New to Highest
  • Severity changed from normal to blocker

This is a blocker as the current behavior by default sets the error sec and the syn sec which might be unexpected for users. If we have no time to implement before release we should better turn the configurator to use false by default.

#4 Updated by Katja Luther about 1 month ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Please review.

#5 Updated by Andreas Müller about 1 month ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Similar to the setPublishForSubtree dialog we should separate those parameters that do hold for all taxon types a bit. In our case it is "delete existing ref details" and "include taxa which are used multiple times". They should come at the end after some space.

A bit problematic ist hte "Overwrite existing sec refs for selected relations option which holds for MAN and PP-Syns. The UI should make this clear somehow. I have no good idea how to do this. Probably the best solution is to have only 1 parameter (similar to "delete ref detail"). I think it is not used a lot anyway so in the rare case that a user wants to explicitly not overwrite synonym syn. secs s*he may run the method 4x (for acc, syn, MAN and ppSyn). Adaptation in cdmlib should be easy.

What do you think?

#6 Updated by Andreas Müller about 1 month ago

  • % Done changed from 0 to 50

#7 Updated by Andreas Müller about 1 month ago

Also I guess by default we should switch off "apply to MAN err. sec." and "apply to ppsyn syn. sec." as most projects do not use these sec. and having it switched on may lead to unwanted data. (this should be done in the configurator default values in cdmlib)

Those projects being used to err. sec. and pp-syn. sec. may understand how to switch it on. Alternatively, in future we could also have a DB preference for the default value.

What do you think?

#8 Updated by Katja Luther about 1 month ago

Andreas Müller wrote:

A bit problematic ist hte "Overwrite existing sec refs for selected relations option which holds for MAN and PP-Syns. The UI should make this clear somehow. I have no good idea how to do this. Probably the best solution is to have only 1 parameter (similar to "delete ref detail"). I think it is not used a lot anyway so in the rare case that a user wants to explicitly not overwrite synonym syn. secs s*he may run the method 4x (for acc, syn, MAN and ppSyn). Adaptation in cdmlib should be easy.

I also thoughth about this when implementing, first I thought about to show two checkboxes.

What do you think?

#9 Updated by Katja Luther about 1 month ago

Andreas Müller wrote:

Also I guess by default we should switch off "apply to MAN err. sec." and "apply to ppsyn syn. sec." as most projects do not use these sec. and having it switched on may lead to unwanted data. (this should be done in the configurator default values in cdmlib)

Those projects being used to err. sec. and pp-syn. sec. may understand how to switch it on. Alternatively, in future we could also have a DB preference for the default value.

What do you think?

I think we should have a preference for the default value for the whole configurator because most users will have a standard workflow for this.

#10 Updated by Andreas Müller about 1 month ago

Katja Luther wrote:

Andreas Müller wrote:

Also I guess by default we should switch off "apply to MAN err. sec." and "apply to ppsyn syn. sec." as most projects do not use these sec. and having it switched on may lead to unwanted data. (this should be done in the configurator default values in cdmlib)

Those projects being used to err. sec. and pp-syn. sec. may understand how to switch it on. Alternatively, in future we could also have a DB preference for the default value.

What do you think?

I think we should have a preference for the default value for the whole configurator because most users will have a standard workflow for this.

Agreed. But we still need a default value for the preference. My suggestion is to NOT set err.sec. and syn.sec. by default. I will implement it this way now. Please let me know if you do not agree.

#11 Updated by Katja Luther about 1 month ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Also I guess by default we should switch off "apply to MAN err. sec." and "apply to ppsyn syn. sec." as most projects do not use these sec. and having it switched on may lead to unwanted data. (this should be done in the configurator default values in cdmlib)

Those projects being used to err. sec. and pp-syn. sec. may understand how to switch it on. Alternatively, in future we could also have a DB preference for the default value.

What do you think?

I think we should have a preference for the default value for the whole configurator because most users will have a standard workflow for this.

Agreed. But we still need a default value for the preference. My suggestion is to NOT set err.sec. and syn.sec. by default. I will implement it this way now. Please let me know if you do not agree.

I think you have more informations about the concrete data in the projects, so I think this is the correct default value.

#12 Updated by Andreas Müller about 1 month ago

Katja Luther wrote:

Andreas Müller wrote:

A bit problematic ist hte "Overwrite existing sec refs for selected relations option which holds for MAN and PP-Syns. The UI should make this clear somehow. I have no good idea how to do this. Probably the best solution is to have only 1 parameter (similar to "delete ref detail"). I think it is not used a lot anyway so in the rare case that a user wants to explicitly not overwrite synonym syn. secs s*he may run the method 4x (for acc, syn, MAN and ppSyn). Adaptation in cdmlib should be easy.

I also thoughth about this when implementing, first I thought about to show two checkboxes.

What do you think?

So do you agree on having only 1 parameter? This will make the UI more simple, at least, which is an advantage. I will implement it this way now. Let me know if you do not agree and have another suggestion.

#13 Updated by Katja Luther about 1 month ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

A bit problematic ist hte "Overwrite existing sec refs for selected relations option which holds for MAN and PP-Syns. The UI should make this clear somehow. I have no good idea how to do this. Probably the best solution is to have only 1 parameter (similar to "delete ref detail"). I think it is not used a lot anyway so in the rare case that a user wants to explicitly not overwrite synonym syn. secs s*he may run the method 4x (for acc, syn, MAN and ppSyn). Adaptation in cdmlib should be easy.

I also thoughth about this when implementing, first I thought about to show two checkboxes.

What do you think?

So do you agree on having only 1 parameter? This will make the UI more simple, at least, which is an advantage. I will implement it this way now. Let me know if you do not agree and have another suggestion.

+1

#14 Updated by Andreas Müller about 1 month ago

implemented. Please adapt UI.

#15 Updated by Andreas Müller about 1 month ago

... and the preference if this is fast. Otherwise open new ticket as it is not really urgent.

#16 Updated by Katja Luther about 1 month ago

Andreas Müller wrote:

implemented. Please adapt UI.

The UI is adapted.

#17 Updated by Katja Luther about 1 month ago

  • Related to bug #9621: New Preference for Default of the SecundumForSubtreeConfigurator added

#18 Updated by Katja Luther about 1 month ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

... and the preference if this is fast. Otherwise open new ticket as it is not really urgent.

I create a new ticket, maybe I am able to implement it before the release but with a new ticket we can close this one.
Please revie the adapted UI.

#19 Updated by Andreas Müller about 1 month ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Katja Luther wrote:

Andreas Müller wrote:

implemented. Please adapt UI.

The UI is adapted.

Can we have more space between Pro Parte and Overwrite existing ... to make clear that the below flags belong to all above selections. (see also dialogue for setPublish)

Also the "multiple-use" flag should be a general flag and not only related to accepted taxa (don't know why we had it only there before)

#20 Updated by Katja Luther 28 days ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

implemented. Please adapt UI.

The UI is adapted.

Can we have more space between Pro Parte and Overwrite existing ... to make clear that the below flags belong to all above selections. (see also dialogue for setPublish)

Also the "multiple-use" flag should be a general flag and not only related to accepted taxa (don't know why we had it only there before)

If it is a general flag I would use the term "object"? Is this ok or is there another term that includes taxa, synonyms etc?

#21 Updated by Andreas Müller 28 days ago

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

implemented. Please adapt UI.

The UI is adapted.

Can we have more space between Pro Parte and Overwrite existing ... to make clear that the below flags belong to all above selections. (see also dialogue for setPublish)

Also the "multiple-use" flag should be a general flag and not only related to accepted taxa (don't know why we had it only there before)

If it is a general flag I would use the term "object"? Is this ok or is there another term that includes taxa, synonyms etc?

No, it should stay "taxa" as this is always related to the accepted taxon (a synonym or a taxon relationship can't be used multiple times, only the accepted taxon.

#22 Updated by Katja Luther 28 days ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

implemented. Please adapt UI.

The UI is adapted.

Can we have more space between Pro Parte and Overwrite existing ... to make clear that the below flags belong to all above selections. (see also dialogue for setPublish)

Also the "multiple-use" flag should be a general flag and not only related to accepted taxa (don't know why we had it only there before)

If it is a general flag I would use the term "object"? Is this ok or is there another term that includes taxa, synonyms etc?

No, it should stay "taxa" as this is always related to the accepted taxon (a synonym or a taxon relationship can't be used multiple times, only the accepted taxon.

ok, this is fixed. please review

#23 Updated by Andreas Müller 28 days ago

  • Target version changed from Release 5.25 to Release 5.23

#24 Updated by Andreas Müller 27 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 80

Andreas Müller wrote:

Katja Luther wrote:
Can we have more space between Pro Parte and Overwrite existing ... to make clear that the below flags belong to all above selections. (see also dialogue for setPublish)

The space issue still seems to be open

#25 Updated by Andreas Müller 27 days ago

#26 Updated by Katja Luther 26 days ago

  • Status changed from Feedback to Closed

Andreas Müller wrote:

Andreas Müller wrote:

Katja Luther wrote:
Can we have more space between Pro Parte and Overwrite existing ... to make clear that the below flags belong to all above selections. (see also dialogue for setPublish)

The space issue still seems to be open

sorry, this is fixed now. So I think we can close this ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)