Project

General

Profile

Actions

bug #9598

closed

Deduplicate NamedAreas with >1 representations and include label in search

Added by Andreas Müller over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
New
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Files

picture595-1.png (5.56 KB) picture595-1.png Katja Luther, 05/03/2021 09:40 AM

Related issues

Related to EDIT - bug #5945: Deduplicate results from termloading by classClosedAndreas Müller

Actions
Related to EDIT - bug #9825: Selection wizards for areas in mulitlanguage instances show every vocabulary twiceClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 1 year ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #2

Updated by Andreas Müller over 1 year ago

  • Subject changed from Deduplicate NamedAreas with >1 representations to Deduplicate NamedAreas with >1 representations and include label in search
Actions #3

Updated by Andreas Müller over 1 year ago

  • Assignee changed from Andreas Müller to Katja Luther

Please review

... and please remove commented code in the respective method if not necessary anymore. Please also have a look to the "count" method in the dao which still looks like the commented code in the other method (but cound currently does not seem to be used currently). We should clean this up.

Actions #4

Updated by Katja Luther over 1 year ago

It should be adapted for the list of vocabularies, too.

The used method is listByTermType()

Actions #5

Updated by Katja Luther over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Katja Luther to Andreas Müller

Katja Luther wrote:

It should be adapted for the list of vocabularies, too.

The used method is listByTermType()

The deduplication of terms works as expected, removed the commented code, so this part of the ticket is resolved and can be closed, I adapted the listByType method in vocabularyDao, could you have a look at it, please.

Actions #6

Updated by Andreas Müller over 1 year ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100

I works.

I changed the code the way that it calls the existing method to avoid redundant code.

As this does not change semantics I think we can close the ticket.

Actions #7

Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.25 to Release 5.23
Actions #8

Updated by Andreas Müller about 1 year ago

  • Related to bug #5945: Deduplicate results from termloading by class added
Actions #9

Updated by Katja Luther about 1 year ago

  • Related to bug #9825: Selection wizards for areas in mulitlanguage instances show every vocabulary twice added
Actions

Also available in: Atom PDF