Project

General

Profile

bug #9598

Deduplicate NamedAreas with >1 representations and include label in search

Added by Andreas Müller about 1 month ago. Updated 28 days ago.

Status:
Closed
Priority:
New
Category:
cdmlib
Target version:
Start date:
05/01/2021
Due date:
% Done:

100%

Severity:
normal
Found in Version:

picture595-1.png View (5.56 KB) Katja Luther, 05/03/2021 09:40 AM

Associated revisions

Revision 587733ce (diff)
Added by Andreas Müller about 1 month ago

fix #9598 add deduplication to DefinedTermDaoImpl.listNamedArea(...)

Revision 0ff7ce5c (diff)
Added by Andreas Müller about 1 month ago

fix #9598 add deduplication to DefinedTermDaoImpl.listNamedAreaByAbbrev(...) rename listNamedArea to list(clazz, ....) to make the method more generic

Revision b9314362 (diff)
Added by Andreas Müller about 1 month ago

fix #9598 add search by label and tests

Revision 62b306e0 (diff)
Added by Katja Luther about 1 month ago

ref #9598: adapt termvocabulary list to avoid duplicates

Revision 013cea82 (diff)
Added by Andreas Müller about 1 month ago

ref #9598 remove redundant code

Revision 74e9f695 (diff)
Added by Andreas Müller about 1 month ago

ref #9598 fix generics for common deduplicate usage

History

#1 Updated by Andreas Müller about 1 month ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Andreas Müller about 1 month ago

  • Subject changed from Deduplicate NamedAreas with >1 representations to Deduplicate NamedAreas with >1 representations and include label in search

#3 Updated by Andreas Müller about 1 month ago

  • Assignee changed from Andreas Müller to Katja Luther

Please review

... and please remove commented code in the respective method if not necessary anymore. Please also have a look to the "count" method in the dao which still looks like the commented code in the other method (but cound currently does not seem to be used currently). We should clean this up.

#4 Updated by Katja Luther about 1 month ago

It should be adapted for the list of vocabularies, too.

The used method is listByTermType()

#5 Updated by Katja Luther about 1 month ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Katja Luther to Andreas Müller

Katja Luther wrote:

It should be adapted for the list of vocabularies, too.

The used method is listByTermType()

The deduplication of terms works as expected, removed the commented code, so this part of the ticket is resolved and can be closed, I adapted the listByType method in vocabularyDao, could you have a look at it, please.

#6 Updated by Andreas Müller about 1 month ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100

I works.

I changed the code the way that it calls the existing method to avoid redundant code.

As this does not change semantics I think we can close the ticket.

#7 Updated by Andreas Müller 28 days ago

  • Target version changed from Release 5.25 to Release 5.23

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)