feature request #9597
closed
Improve formatting of MediaSpecimen in TypeDesignationWorkingSet formatting
Added by Andreas Müller almost 3 years ago.
Updated almost 3 years ago.
Description
copied from #9279
Sources for MediaSpecimen should be formatted in the same way as elsewhere
Example:
- Old non-conformant formatting: ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008))"
- expected formatting: ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)".
- Copied from feature request #9279: Improve type designation formatting and TypeDesignationSetManager added
- Status changed from New to Resolved
- Assignee changed from Andreas Müller to Andreas Kohlbecker
I adapted the formatting of MediaSpecimen type designations sources to the general source handling. This also allows handling the sources in the bibliography with footnotes and generally is more consistent.
So it does not look like ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008))" but like ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)".
Andreas K. and Henning, please review if you think this is correct.
Maybe tests in dataportal need to be adapted accordingly.
- Tags changed from formatting to formatting, type designation
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Kohlbecker to Andreas Müller
please can you clarify what the expected new output is?
I am assuming this representation in the new one ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)", correct?
- Status changed from Feedback to Resolved
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Andreas Kohlbecker wrote:
please can you clarify what the expected new output is?
I am assuming this representation in the new one ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)", correct?
Yes, the changes in TypeDesignationSetManagerTest can give you an idea of what changed.
Mostly it is "in Kohlbecker & Kusber 2008: 33" (new) instead of "p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008)" (old) . The prior uses our default formatting for sources.
- Description updated (diff)
- Description updated (diff)
- Status changed from Resolved to Closed
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 50 to 100
implementation and test case looks ok. As there are no test to be adapted in the dataportal, this ticket can be closed.
- Target version changed from Release 5.25 to Release 5.23
Also available in: Atom
PDF