feature request #9597: Improve formatting of MediaSpecimen in TypeDesignationWorkingSet formatting - EDIT - EDIT Project Management

Actions

Copy link

feature request #9597

closed

Improve formatting of MediaSpecimen in TypeDesignationWorkingSet formatting

Added by Andreas Müller over 2 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Highest

Assignee:

Andreas Müller

Category:

cdmlib

Target version:

Release 5.23

Start date:

Due date:

% Done:

100%

Estimated time:

Severity:

normal

Tags:

type designation formatting

Description

copied from #9279

Sources for MediaSpecimen should be formatted in the same way as elsewhere
Example:

Old non-conformant formatting: ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008))"
expected formatting: ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)".

Related issues

Actions

Copy link

Updated by Andreas Müller over 2 years ago

Copied from feature request #9279: Improve type designation formatting and TypeDesignationSetManager added

Actions

Copy link

Updated by Andreas Müller over 2 years ago

Related to feature request #9596: Open issues for TypeDesignationWorkingSet added

Actions

Copy link

Updated by Andreas Müller over 2 years ago

Related to feature request #5573: Cache Strategy for Media Specimen required added

Actions

Copy link

Updated by Andreas Müller over 2 years ago

Status changed from New to Resolved

Applied in changeset cdmlib|11e24052308c971ec1959f5e8219ff1962a61a7c.

Actions

Copy link

Updated by Andreas Müller over 2 years ago

Assignee changed from Andreas Müller to Andreas Kohlbecker

I adapted the formatting of MediaSpecimen type designations sources to the general source handling. This also allows handling the sources in the bibliography with footnotes and generally is more consistent.

So it does not look like ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008))" but like ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)".

Andreas K. and Henning, please review if you think this is correct.

Maybe tests in dataportal need to be adapted accordingly.

Actions

Copy link

Updated by Andreas Müller over 2 years ago

Related to feature request #7612: CacheStrategy for MediaSpecimens added

Actions

Copy link

Updated by Andreas Müller over 2 years ago

Tags changed from formatting to formatting, type designation

Actions

Copy link

Updated by Andreas Kohlbecker over 2 years ago

Status changed from Resolved to Feedback
Assignee changed from Andreas Kohlbecker to Andreas Müller

please can you clarify what the expected new output is?

I am assuming this representation in the new one ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)", correct?

Actions

Copy link

Updated by Andreas Müller over 2 years ago

Status changed from Feedback to Resolved
Assignee changed from Andreas Müller to Andreas Kohlbecker

Andreas Kohlbecker wrote:

please can you clarify what the expected new output is?

I am assuming this representation in the new one ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)", correct?

Yes, the changes in TypeDesignationSetManagerTest can give you an idea of what changed.

Mostly it is "in Kohlbecker & Kusber 2008: 33" (new) instead of "p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008)" (old) . The prior uses our default formatting for sources.

Actions

Copy link

#10