Project

General

Profile

feature request #9597

Improve formatting of MediaSpecimen in TypeDesignationWorkingSet formatting

Added by Andreas Müller 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
04/30/2021
Due date:
% Done:

100%

Severity:
normal

Description

copied from #9279

Sources for MediaSpecimen should be formatted in the same way as elsewhere
Example:

  • Old non-conformant formatting: ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008))"
  • expected formatting: ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)".

Related issues

Related to Edit - feature request #9596: Open issues for TypeDesignationWorkingSet New 04/30/2021
Related to Edit - feature request #5573: Cache Strategy for Media Specimen required Closed 02/18/2016
Related to Edit - feature request #7612: CacheStrategy for MediaSpecimens Duplicate 07/31/2018
Copied from Edit - feature request #9279: Improve type designation formatting and TypeDesignationSetManager Closed 11/05/2020

Associated revisions

Revision 11e24052 (diff)
Added by Andreas Müller 6 months ago

fix #9597 handle MediaSpecimen and its sources correctly in TypeDesignationSet formatting

Revision b5c91e8c (diff)
Added by Andreas Müller 6 months ago

ref #9597 handle MediaSpecimen and its sources correctly in TypeDesignationSet formatting (cont.)

History

#1 Updated by Andreas Müller 6 months ago

  • Copied from feature request #9279: Improve type designation formatting and TypeDesignationSetManager added

#2 Updated by Andreas Müller 6 months ago

#3 Updated by Andreas Müller 6 months ago

#4 Updated by Andreas Müller 6 months ago

  • Status changed from New to Resolved

#5 Updated by Andreas Müller 6 months ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

I adapted the formatting of MediaSpecimen type designations sources to the general source handling. This also allows handling the sources in the bibliography with footnotes and generally is more consistent.

So it does not look like ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008))" but like ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)".

Andreas K. and Henning, please review if you think this is correct.

Maybe tests in dataportal need to be adapted accordingly.

#6 Updated by Andreas Müller 6 months ago

#7 Updated by Andreas Müller 6 months ago

  • Tags changed from formatting to formatting, type designation

#8 Updated by Andreas Kohlbecker 6 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

please can you clarify what the expected new output is?

I am assuming this representation in the new one ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)", correct?

#9 Updated by Andreas Müller 6 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Andreas Kohlbecker wrote:

please can you clarify what the expected new output is?

I am assuming this representation in the new one ".... Germany, near Bughausen, A.Kohlbecker 81989, 2017 (holotype: [icon] in Kohlbecker & Kusber 2008: 33)", correct?

Yes, the changes in TypeDesignationSetManagerTest can give you an idea of what changed.

Mostly it is "in Kohlbecker & Kusber 2008: 33" (new) instead of "p.33 in Kohlbecker, A. & Kusber, W.H. Algae of the BGBM (2008)" (old) . The prior uses our default formatting for sources.

#10 Updated by Andreas Kohlbecker 6 months ago

  • Description updated (diff)

#11 Updated by Andreas Kohlbecker 6 months ago

  • Description updated (diff)

#12 Updated by Andreas Kohlbecker 6 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 50 to 100

implementation and test case looks ok. As there are no test to be adapted in the dataportal, this ticket can be closed.

#13 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)