task #9594
closed
Use MediaSpecimen as input for MediaSpecimenGeneralDetailElement
Added by Andreas Müller almost 3 years ago.
Updated almost 3 years ago.
Description
It does not make sense to use DerivedUnitFacade here as the specific type is known. Also it the facade creates problems as it injects the DerivedUnitFacadeCacheStrategy into the specimen so the new MediaSpecimenDefaultCacheStrategy can not really be used.
- Status changed from New to Resolved
- Assignee changed from Andreas Müller to Katja Luther
- % Done changed from 0 to 50
we could do something similar for DnaSample
Note: the implementation in specimen list editor leads to a message that the specimen can not be edited in details view. This is wanted as in the list editor always the full hierarchy should be editable including field unit data. This was not possible in the old implementation but the same view format appeared as in the specimen tree editor which is unexpected behavior.
in DetailsViewE4.setInput() there is the following code:
if (input instanceof MediaSpecimen && !(this.activePart.getClass().getSimpleName().equals("BulkEditorE4"))){
This should better be "... this.activePart instanceof BulkEditorE4 " but the bulk editor class was not available here. Can this somehow be adapted to make BulkEditorE4 availble. I did not check this.
- Related to task #9595: Use DerivedUnit or DnaSample for DnaSampleGeneralDetailElement added
Andreas Müller wrote:
in DetailsViewE4.setInput() there is the following code:
if (input instanceof MediaSpecimen && !(this.activePart.getClass().getSimpleName().equals("BulkEditorE4"))){
This should better be "... this.activePart instanceof BulkEditorE4 " but the bulk editor class was not available here. Can this somehow be adapted to make BulkEditorE4 availble. I did not check this.
This can be done by creating and using an interface. I will do this.
- Related to bug #9609: Use DerivedUnit or FieldUnit for DetailsView of tree editor added
- Status changed from Resolved to Closed
- Assignee changed from Katja Luther to Andreas Müller
Implemented the interface and reviewed the mediaspecimen details view. This worked as expected, so we can close this ticket.
- Target version changed from Release 5.25 to Release 5.23
Also available in: Atom
PDF