Project

General

Profile

task #9594

Use MediaSpecimen as input for MediaSpecimenGeneralDetailElement

Added by Andreas Müller 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
New
Category:
taxeditor
Target version:
Start date:
04/29/2021
Due date:
% Done:

50%

Severity:
normal

Description

It does not make sense to use DerivedUnitFacade here as the specific type is known. Also it the facade creates problems as it injects the DerivedUnitFacadeCacheStrategy into the specimen so the new MediaSpecimenDefaultCacheStrategy can not really be used.


Related issues

Related to Edit - feature request #5573: Cache Strategy for Media Specimen required Closed 02/18/2016
Related to Edit - feature request #7612: CacheStrategy for MediaSpecimens Duplicate 07/31/2018
Related to Edit - task #9595: Use DerivedUnit or DnaSample for DnaSampleGeneralDetailElement Closed 04/29/2021
Related to Edit - bug #9609: Use DerivedUnit or FieldUnit for DetailsView of tree editor New 05/06/2021

Associated revisions

Revision d4b9ef81 (diff)
Added by Andreas Müller 6 months ago

ref #9594 use MediaSpecimen as base unit for MediaSpecimenGeneralDetailElement

Revision 0d672864 (diff)
Added by Andreas Müller 6 months ago

ref #9594 use MediaSpecimen as base unit for MediaSpecimenGeneralDetailElement (cont.)

Revision 1cd6de7e (diff)
Added by Andreas Müller 6 months ago

ref #9594 , ref #5573, ref #7612 use MediaSpecimenCacheStrategy in DerivateLabelProvider

Revision 9201d8aa (diff)
Added by Katja Luther 6 months ago

cleanup, fix field unit in details views

History

#1 Updated by Andreas Müller 6 months ago

#2 Updated by Andreas Müller 6 months ago

#3 Updated by Andreas Müller 6 months ago

  • Status changed from New to Resolved
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 50

please review

#4 Updated by Andreas Müller 6 months ago

we could do something similar for DnaSample

#5 Updated by Andreas Müller 6 months ago

Note: the implementation in specimen list editor leads to a message that the specimen can not be edited in details view. This is wanted as in the list editor always the full hierarchy should be editable including field unit data. This was not possible in the old implementation but the same view format appeared as in the specimen tree editor which is unexpected behavior.

#6 Updated by Andreas Müller 6 months ago

in DetailsViewE4.setInput() there is the following code:

if (input instanceof MediaSpecimen && !(this.activePart.getClass().getSimpleName().equals("BulkEditorE4"))){    

This should better be "... this.activePart instanceof BulkEditorE4 " but the bulk editor class was not available here. Can this somehow be adapted to make BulkEditorE4 availble. I did not check this.

#7 Updated by Andreas Müller 6 months ago

  • Related to task #9595: Use DerivedUnit or DnaSample for DnaSampleGeneralDetailElement added

#8 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

in DetailsViewE4.setInput() there is the following code:

if (input instanceof MediaSpecimen && !(this.activePart.getClass().getSimpleName().equals("BulkEditorE4"))){    

This should better be "... this.activePart instanceof BulkEditorE4 " but the bulk editor class was not available here. Can this somehow be adapted to make BulkEditorE4 availble. I did not check this.

This can be done by creating and using an interface. I will do this.

#9 Updated by Katja Luther 6 months ago

  • Related to bug #9609: Use DerivedUnit or FieldUnit for DetailsView of tree editor added

#10 Updated by Katja Luther 6 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller

Implemented the interface and reviewed the mediaspecimen details view. This worked as expected, so we can close this ticket.

#11 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)