Project

General

Profile

Actions
Copy link

bug #9593

closed

Changing and saving a PolytomousKey throws ConcurrentModificationException

Added by Andreas Müller almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.23
Start date:
Due date:
% Done:

90%

Estimated time:
Severity:
normal
Found in Version:
Actions
Copy link
 #1

Updated by Andreas Müller almost 3 years ago

  • Assignee changed from Andreas Müller to Katja Luther
  • Priority changed from New to Highest
  • % Done changed from 0 to 10

This only seems to happen if the sortindex of the PolytomousKey nodes is not up-to-date. After calling refresh on the key saving works.

So it is related to #5681.

Before closing this ticket can you please debug which collection is concurrently modified and why (propably it is the PKNode.children collection but I am not sure why.

Actions
Copy link
 #3

Updated by Katja Luther almost 3 years ago

Andreas Müller wrote:

This only seems to happen if the sortindex of the PolytomousKey nodes is not up-to-date. After calling refresh on the key saving works.

So it is related to #5681.

Before closing this ticket can you please debug which collection is concurrently modified and why (propably it is the PKNode.children collection but I am not sure why.

As the problem disappears after updating the sortindex, the children collection seems to cause the problems.

Actions
Copy link
 #4

Updated by Katja Luther almost 3 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Added the handling of polytomous key in removeNullFromCollection because the editor saves the whole key.

Actions
Copy link
 #6

Updated by Andreas Müller almost 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 10 to 90

Probably this is ok, though I wonder why the root node is not doing the same job as it is merge-cascaded. But as the incorrect sortindex numbers appeared from time to time in PKs this might be the reason.
We have to watch this.

Generally this ticket can be closed.

Only one issue: the commit 4ce176cc6b710274 also contains code which seems to belong to another ticket. Can you please attache the commit also to the other ticket (what ever it is)?

Actions
Copy link
 #7

Updated by Katja Luther almost 3 years ago

  • Status changed from Feedback to Closed

Andreas Müller wrote:

Probably this is ok, though I wonder why the root node is not doing the same job as it is merge-cascaded. But as the incorrect sortindex numbers appeared from time to time in PKs this might be the reason.
We have to watch this.

Generally this ticket can be closed.

Only one issue: the commit 4ce176cc6b710274 also contains code which seems to belong to another ticket. Can you please attache the commit also to the other ticket (what ever it is)?

I removed it

Actions
Copy link
 #8

Updated by Andreas Müller almost 3 years ago

  • Target version changed from Release 5.25 to Release 5.23
Actions
Copy link

Also available in: Atom PDF