Project

General

Profile

bug #9593

Changing and saving a PolytomousKey throws ConcurrentModificationException

Added by Andreas Müller 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
04/27/2021
Due date:
% Done:

90%

Severity:
normal
Found in Version:

Associated revisions

Revision 98ac7b26 (diff)
Added by Katja Luther 6 months ago

ref #9593: add polytomouskey handling in PostMergeEntityListener to avoid NULL values

Revision 4ce176cc (diff)
Added by Katja Luther 6 months ago

ref #9593: add polytomouskey handling in PostMergeEntityListener to avoid NULL values - avoid NPE

Revision 78dff9c8 (diff)
Added by Katja Luther 6 months ago

ref #9593: revert some changes in taxonDao not belonging to this ticket

History

#1 Updated by Andreas Müller 6 months ago

  • Assignee changed from Andreas Müller to Katja Luther
  • Priority changed from New to Highest
  • % Done changed from 0 to 10

This only seems to happen if the sortindex of the PolytomousKey nodes is not up-to-date. After calling refresh on the key saving works.

So it is related to #5681.

Before closing this ticket can you please debug which collection is concurrently modified and why (propably it is the PKNode.children collection but I am not sure why.

#3 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

This only seems to happen if the sortindex of the PolytomousKey nodes is not up-to-date. After calling refresh on the key saving works.

So it is related to #5681.

Before closing this ticket can you please debug which collection is concurrently modified and why (propably it is the PKNode.children collection but I am not sure why.

As the problem disappears after updating the sortindex, the children collection seems to cause the problems.

#4 Updated by Katja Luther 6 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Added the handling of polytomous key in removeNullFromCollection because the editor saves the whole key.

#6 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 10 to 90

Probably this is ok, though I wonder why the root node is not doing the same job as it is merge-cascaded. But as the incorrect sortindex numbers appeared from time to time in PKs this might be the reason.
We have to watch this.

Generally this ticket can be closed.

Only one issue: the commit 4ce176cc6b710274 also contains code which seems to belong to another ticket. Can you please attache the commit also to the other ticket (what ever it is)?

#7 Updated by Katja Luther 6 months ago

  • Status changed from Feedback to Closed

Andreas Müller wrote:

Probably this is ok, though I wonder why the root node is not doing the same job as it is merge-cascaded. But as the incorrect sortindex numbers appeared from time to time in PKs this might be the reason.
We have to watch this.

Generally this ticket can be closed.

Only one issue: the commit 4ce176cc6b710274 also contains code which seems to belong to another ticket. Can you please attache the commit also to the other ticket (what ever it is)?

I removed it

#8 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.23

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)