EDIT

Applied in changeset taxeditor|ea94be31fe128ab763b1f1e1ca48a799216f2b20.

this is fixed, please review.

Andreas Müller wrote:

the cancel works now.

However, this is still unclear: "Diese Operation wird den Editor speichern. Ebenso werden alle weiteren ungespeicherten Änderungen gespeichert". What exactly is meant wiht "alle weiteren ungespeicherten Änderungen". Other name editors are not saved but I would expect with this warning.

Anyway, generally I do not understand why we to this at all. I would expect that opening a taxon via navigator that is already open and isDirty will simly set the focus to this editor but nothing else. Why do we need to save it explicitly. This behaviors e.g. from eclipse IDE behavior and for me is unexpected.

You are right, I implemented it this way now. Please review.

This does not seem to work if a taxon is used multiple times. E.g. if you search for "Sectest cdcfd" in rem_conf_am and open it in 1 classification and change it and then try to open it in the other classification it gets saved without warning.
This is due to the inconsistency that the name editor opens only once per taxon but at the same time is related to a taxon node not only a taxon.

As we have almost no data with shared taxa in production this is not a serious problem. However, if possible, in this very rare situation we should keep the previous warning dialogue or do something else that makes the behavior intuitive.

Katja Luther wrote:

Andreas Müller wrote:

This does not seem to work if a taxon is used multiple times. E.g. if you search for "Sectest cdcfd" in rem_conf_am and open it in 1 classification and change it and then try to open it in the other classification it gets saved without warning.
This is due to the inconsistency that the name editor opens only once per taxon but at the same time is related to a taxon node not only a taxon.

As we have almost no data with shared taxa in production this is not a serious problem. However, if possible, in this very rare situation we should keep the previous warning dialogue or do something else that makes the behavior intuitive.

Now it is implemented for shared taxa in the way it was before and for taxa used only once only the focus is set to the selected name editor. We should improve this handling in future and open another editor window for the other taxonnode.

Ok. This works. As reused taxa are extremely rare the solution is fully acceptable. Also we will soon merge TaxonNode and TaxonBase and then fully reusable taxa will not exist anymore anyway.