Project

General

Profile

Actions

bug #9556

closed

occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

Added by Andreas Kohlbecker over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
critical
Found in Version:

Description

see http://localhost:8080/occurrence/8585081c-b73b-440b-b349-582845cf3fb4/fieldUnitDTOs.json

the response data may be filtered with

http http://localhost:8080/occurrence/8585081c-b73b-440b-b349-582845cf3fb4/fieldUnitDTOs.json | jq '.' | grep 'XKCD MASKS 2X (Masks)'   

to see duplicates easily


Related issues

Related to EDIT - bug #9557: implement occurrence/{uuid}/rootUnitDTOs ClosedAndreas Kohlbecker

Actions
Related to EDIT - task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) ClosedAndreas Kohlbecker

Actions
Actions #2

Updated by Andreas Kohlbecker over 1 year ago

  • Related to bug #9557: implement occurrence/{uuid}/rootUnitDTOs added
Actions #3

Updated by Andreas Kohlbecker over 1 year ago

This method is kind of misused: After solving #9557 it is only being used by .DerivedUnitFacadeController.doGetFieldObjectMediaDTO() which again is used by the data portal to retrieve the FieldUnit Media.

  • First of all this method adds an extra overhead by creating DTOs for all intermediate units which are not being used at all.
  • Secondly does this method not deliver media of all FieldUnits, only for the first one that is found, see #9253
Actions #4

Updated by Andreas Kohlbecker over 1 year ago

  • Related to task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) added
Actions #5

Updated by Andreas Kohlbecker over 1 year ago

  • Related to task #9430: revise OccurrenceServiceImpl._findRootUnitDTO(..) supports multiple origin paths added
Actions #6

Updated by Andreas Kohlbecker over 1 year ago

  • Related to deleted (task #9430: revise OccurrenceServiceImpl._findRootUnitDTO(..) supports multiple origin paths)
Actions #7

Updated by Andreas Kohlbecker over 1 year ago

  • Status changed from New to Rejected
  • Target version deleted (Release 5.22)

since the intermediate units are not used at all by consuming methods, they should be skipped completely.

Actions #8

Updated by Andreas Kohlbecker over 1 year ago

  • Status changed from Rejected to Feedback
  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • Target version set to Release 5.22

reopening this issue since loadFieldUnitDTO() is being used in the Taxeditor

@Katja: are the derivatives of the FieldUnitDTO being used in the TaxEditor?

Actions #9

Updated by Andreas Kohlbecker over 1 year ago

  • Category changed from cdmlib-remote to cdmlib

DerivedUnitFacadeController.doGetFieldObjectMediaDTO() is no longer using loadFieldUnitDTO see 3309605f
therefore the Taxeditor is the only component which is using this method.

Actions #10

Updated by Katja Luther over 1 year ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker

Andreas Kohlbecker wrote:

reopening this issue since loadFieldUnitDTO() is being used in the Taxeditor

@Katja: are the derivatives of the FieldUnitDTO being used in the TaxEditor?

no, the derivatives are not used in the editor

Actions #11

Updated by Andreas Kohlbecker over 1 year ago

  • Assignee changed from Andreas Kohlbecker to Katja Luther

so we should modify this service method so that it no longer add the derivatives or is there an alternative service method that can be used instead. In the latter case loadFieldUnitDTO could be removed.

Actions #12

Updated by Katja Luther over 1 year ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker

I removed that the derivatives are added to the fieldUnitDto in loadFieldUnitDto().

Actions #13

Updated by Andreas Kohlbecker over 1 year ago

  • Status changed from Feedback to Resolved
  • % Done changed from 0 to 50

after the 6d3c3fa9 which is rather related to listRootUnitDTOsByAssociatedTaxon() the web services should no longer include duplicate derivatives

Actions #14

Updated by Andreas Kohlbecker over 1 year ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

can be closed now

Actions

Also available in: Atom PDF