Project

General

Profile

feature request #9541

Improve referencing objects handling

Added by Andreas Müller 7 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
03/19/2021
Due date:
% Done:

50%

Severity:
normal

Description

  • DescriptionElementSource, SecundumSource and NomenclaturalStatus do now have a backlink to their referencing main object. Better labels and "open in" can be created for them, so.
  • performance should be improved, currently sorting is done on "description" therefore each label needs to be created during sort, which is at least 1 lazy-initialization call per record if initialization is needed
  • setting module parameters like "referencingObjectsList" is not done synchronized and within 1 command line with a server call. This may result in incorrect data if >1 job is running
  • the total number of records found should be shown
  • each job should be cancelable as often as possible so the jobs should be done in small parts, this is important for human triggered cancel as well as cancel due to focus change
  • tbc

Associated revisions

Revision 844e6554 (diff)
Added by Andreas Müller 7 months ago

ref #9541 improve handling for description main objects

Revision b01e3f90 (diff)
Added by Andreas Müller 7 months ago

ref #9541 utitlity method for KeyStatement

Revision 16922c6f (diff)
Added by Andreas Müller 7 months ago

ref #9541 move distance formatting to own formatting class

Revision 8b7fdba9 (diff)
Added by Andreas Müller 7 months ago

ref #9541 DTOs for referencing objects and server side initialization

Revision dcef45f2 (diff)
Added by Andreas Müller 7 months ago

ref #9541 deproxy target entity and referencing entity

Revision 99de1ab2 (diff)
Added by Andreas Müller 7 months ago

ref #9541 further improve referencing object handling

Revision 58e6cb8f (diff)
Added by Andreas Müller 7 months ago

ref #9541 new referencing objects implementation in TaxEditor

Revision 7d58503b (diff)
Added by Andreas Müller 7 months ago

ref #9541 adapt bulk editor opener for referencing objects

Revision a6dcfe44 (diff)
Added by Andreas Müller 7 months ago

ref #9541 Source for => for

Revision 18bd5760 (diff)
Added by Andreas Müller 7 months ago

ref #9541 fix query on IdentifiableSource and SingleSource

Revision 69dc5be6 (diff)
Added by Andreas Müller 7 months ago

ref #9541 open referencing objects in openIn target

Revision 824ea259 (diff)
Added by Andreas Müller 7 months ago

ref #9541 fix missing OpenIn menu for ordinary CdmBase input

Revision fd6c6dec (diff)
Added by Andreas Müller 7 months ago

ref #9541 use openInTarget for OpenIn (CdmViewerUtilE4)

Revision 2ac111f5 (diff)
Added by Andreas Müller 7 months ago

ref #9541 add getBestOpenInTargetType to ReferencingObjectDto

Revision 880f5390 (diff)
Added by Andreas Müller 7 months ago

ref #9541 refactor Open..Handlers to all use UuidAndTitleCache as input and some more changes and bugfixes

Revision 1f0bb7e2 (diff)
Added by Andreas Müller 7 months ago

ref #9541 q&d add target description for untargeted sources

Revision 771e2ffd (diff)
Added by Andreas Müller 7 months ago

ref #9541 fix potential NPE in distributionDto loading

Revision ca839fe0 (diff)
Added by Andreas Müller 7 months ago

ref #9541 improve label for taxon nodes in ReferencingObjectFormatter

Revision 3ce2af15 (diff)
Added by Andreas Müller 7 months ago

ref #9541 further fixes for referencing objects and related issues

Revision bfb8b043 (diff)
Added by Andreas Müller 6 months ago

fix NPE and handle not existing targetEntity

History

#1 Updated by Andreas Müller 7 months ago

  • Subject changed from Improve labels for referencing objects to Improve referencing objects handling

#2 Updated by Andreas Müller 7 months ago

  • Description updated (diff)
  • % Done changed from 0 to 20

#3 Updated by Andreas Müller 6 months ago

  • Status changed from New to Resolved

#4 Updated by Andreas Müller 6 months ago

  • Description updated (diff)

What I did:

  • moved all referencing objects formatting to cdmlib (ReferencingObjectFormatter) to allow server side formatting and to have formatting at one place (model.format), this is a bit critical because referencing objects formatting is somehow context depending
  • refactored the ReferencingObjectsViewE4 to
    • first load objects without description and without link to target entity
    • load descriptions and target entity in bulk
    • correct handling of synchronized variables (using synchronized and volatile)
    • use only 1 variable (actualUuid) to check if the focus is on a new entity, this variable is synchronized
    • implement "cancel" during bulk load of descriptions and and target entity
  • refactor "open in" framework to be more generic for the different types of entities having the focus (model instances, DTOs, others, ...)
  • allow self referening "Open in ... referencing objects view" to traverse the object graph
  • some more that I forgot

#5 Updated by Andreas Müller 6 months ago

open issues might be:

  • improved formatting for all CdmBase classes (some formatting also seems to have regression, e.g. Distributions)
  • self-referencing "open in" should not work on target but on base entity to really traverse the graph and not jump to the target instance (e.g. jump from DescriptionElementSource reference to the source and not immediately to the taxon itself)
  • improve handling of view label and count
  • formatting and target object computation without initializing model objects
  • filter out instances which are part of the base object, e.g. do not show nomenclatural source of a TaxonName (but show if nomenclatural source is only using the name as original spelling)
  • ...

#6 Updated by Andreas Müller 6 months ago

  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 20 to 50

Can you please review?

Open issues should be moved to new ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)