Project

General

Profile

feature request #9537

Implement ratioToStructure in TaxEditor

Added by Andreas Müller 7 months ago. Updated 6 months ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
03/17/2021
Due date:
% Done:

80%

Severity:
normal
Tags:

Description

for details see #9507.

We also need an according default formatting for the new character.


Related issues

Follows (10 days) Edit - feature request #9507: Add ratioTo structure to Character Closed 03/03/2021

Associated revisions

Revision 74c1395d (diff)
Added by Katja Luther 7 months ago

ref #9537: adapt CharacterDto to ratioTo

Revision e2acbb7a (diff)
Added by Katja Luther 7 months ago

ref #9537: adapt CharacterDto to ratioTo - avoid NPE

Revision 6c8cfbd4 (diff)
Added by Katja Luther 7 months ago

ref #9537: adapt editor to ratioTo in Character

Revision 7d80a1af (diff)
Added by Katja Luther 7 months ago

ref #9537: fix select for characterDto

Revision a8d4957f (diff)
Added by Katja Luther 7 months ago

ref #9537: adapt editor to ratioTo in Character - continue

Revision 2795c3ee (diff)
Added by Katja Luther 7 months ago

ref #9537: fix select for characterDto -continue

Revision fa6d38ce (diff)
Added by Katja Luther 7 months ago

ref #9537: add button to ratioTo element

Revision c0bc149a (diff)
Added by Katja Luther 7 months ago

ref #9537: add button to ratioTo element - l10n changes

Revision 1a6e9489 (diff)
Added by Katja Luther 6 months ago

ref #9537: enable/disable buttons, refresh issue

Revision bd13c880 (diff)
Added by Katja Luther 6 months ago

ref #9537: no warning if no vocabulary is chosen

Revision 948bc8b0 (diff)
Added by Katja Luther 6 months ago

ref #9537: new label for ratio to

Revision bbe2f24e (diff)
Added by Katja Luther 6 months ago

ref #9537: adapt character label for ratio to

History

#1 Updated by Andreas Müller 7 months ago

  • Due date set to 03/15/2021
  • Start date changed from 03/17/2021 to 03/15/2021
  • Follows feature request #9507: Add ratioTo structure to Character added

#2 Updated by Andreas Müller 7 months ago

  • Due date deleted (03/15/2021)
  • Priority changed from New to Highest
  • Start date changed from 03/15/2021 to 03/17/2021

#3 Updated by Andreas Müller 7 months ago

  • Tags changed from additivity to additivity, 5.22

#4 Updated by Andreas Müller 7 months ago

  • Tags changed from additivity, 5.22 to additivity, 5.22, fast

#5 Updated by Katja Luther 7 months ago

  • Status changed from New to In Progress

Implemented a button to add ratio to structure to character.

Still needed is a button in details view to remove the structure.

#6 Updated by Katja Luther 7 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be fixed.

The ratio to structure can be added in character editor by using the button in character editor, remove the structure can be done in details view.

#7 Updated by Katja Luther 7 months ago

  • % Done changed from 0 to 50

#8 Updated by Andreas Müller 6 months ago

  • Tags changed from additivity, 5.22, fast to additivity
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The ratio to is currently only shown after the character editor was saved. It should be shown immediately after pressing the ratio to button.

#9 Updated by Andreas Müller 6 months ago

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is updated. This check should be removed.

#10 Updated by Andreas Müller 6 months ago

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

#11 Updated by Andreas Müller 6 months ago

Finally, if possible, the new button should only be enabeled if a structure and a character node is selected.

#12 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

The ratio to is currently only shown after the character editor was saved. It should be shown immediately after pressing the ratio to button.

this is fixed.

#13 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

Finally, if possible, the new button should only be enabeled if a structure and a character node is selected.

this is fixed

#14 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is updated. This check should be removed.

this is fixed

#15 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

How should this look like? character label + ratioTo-label or character label + "ratio to " + ratioTo-label?

#16 Updated by Andreas Müller 6 months ago

Katja Luther wrote:

Andreas Müller wrote:

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is updated. This check should be removed.

this is fixed

This is still the case

#17 Updated by Andreas Müller 6 months ago

Katja Luther wrote:

Andreas Müller wrote:

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

How should this look like? character label + ratioTo-label or character label + "ratio to " + ratioTo-label?

I suggest "Ratio {char1label}/{char2label} {property}". Alternatively "to" instead of slash.

Norbert, do you have any deviating suggestions?

#18 Updated by Katja Luther 6 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

How should this look like? character label + ratioTo-label or character label + "ratio to " + ratioTo-label?

I suggest "Ratio {char1label}/{char2label} {property}". Alternatively "to" instead of slash.

Norbert, do you have any deviating suggestions?

Now the label looks like this
"Ratio structureLabel1 to structureLabel2 propertyLabel"

#19 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is updated. This check should be removed.

this is fixed

This is still the case

sorry missed to commit the needed file

#20 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 80

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

How should this look like? character label + ratioTo-label or character label + "ratio to " + ratioTo-label?

I suggest "Ratio {char1label}/{char2label} {property}". Alternatively "to" instead of slash.

Norbert, do you have any deviating suggestions?

Now the label looks like this
"Ratio structureLabel1 to structureLabel2 propertyLabel"

I thought about the label again and maybe it is better to use "{property} ratio {char1} to {char2}". If NK does not another suggestion please implement it this way and then we can close the ticket.

#21 Updated by Andreas Müller 6 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I guess this is for review.

#22 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

A final issue is that removing the "ratio to" with titleCache not being protected does not set back the titleCache to the default value (without "ratio").

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)