Project

General

Profile

Actions

feature request #9537

open

Implement ratioToStructure in TaxEditor

Added by Andreas Müller over 1 year ago. Updated over 1 year ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

80%

Estimated time:
Severity:
normal
Tags:

Description

for details see #9507.

We also need an according default formatting for the new character.


Related issues

Follows (10 days) EDIT - feature request #9507: Add ratioTo structure to CharacterClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 1 year ago

  • Due date set to 03/15/2021
  • Start date changed from 03/17/2021 to 03/15/2021
  • Follows feature request #9507: Add ratioTo structure to Character added
Actions #2

Updated by Andreas Müller over 1 year ago

  • Due date deleted (03/15/2021)
  • Priority changed from New to Highest
  • Start date changed from 03/15/2021 to 03/17/2021
Actions #3

Updated by Andreas Müller over 1 year ago

  • Tags changed from additivity to additivity, 5.22
Actions #4

Updated by Andreas Müller over 1 year ago

  • Tags changed from additivity, 5.22 to additivity, 5.22, fast
Actions #5

Updated by Katja Luther over 1 year ago

  • Status changed from New to In Progress

Implemented a button to add ratio to structure to character.

Still needed is a button in details view to remove the structure.

Actions #6

Updated by Katja Luther over 1 year ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be fixed.

The ratio to structure can be added in character editor by using the button in character editor, remove the structure can be done in details view.

Actions #7

Updated by Katja Luther over 1 year ago

  • % Done changed from 0 to 50
Actions #8

Updated by Andreas Müller over 1 year ago

  • Tags changed from additivity, 5.22, fast to additivity
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The ratio to is currently only shown after the character editor was saved. It should be shown immediately after pressing the ratio to button.

Actions #9

Updated by Andreas Müller over 1 year ago

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is updated. This check should be removed.

Actions #10

Updated by Andreas Müller over 1 year ago

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

Actions #11

Updated by Andreas Müller over 1 year ago

Finally, if possible, the new button should only be enabeled if a structure and a character node is selected.

Actions #12

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

The ratio to is currently only shown after the character editor was saved. It should be shown immediately after pressing the ratio to button.

this is fixed.

Actions #13

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

Finally, if possible, the new button should only be enabeled if a structure and a character node is selected.

this is fixed

Actions #14

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is updated. This check should be removed.

this is fixed

Actions #15

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

How should this look like? character label + ratioTo-label or character label + "ratio to " + ratioTo-label?

Actions #16

Updated by Andreas Müller over 1 year ago

Katja Luther wrote:

Andreas Müller wrote:

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is updated. This check should be removed.

this is fixed

This is still the case

Actions #17

Updated by Andreas Müller over 1 year ago

Katja Luther wrote:

Andreas Müller wrote:

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

How should this look like? character label + ratioTo-label or character label + "ratio to " + ratioTo-label?

I suggest "Ratio {char1label}/{char2label} {property}". Alternatively "to" instead of slash.

Norbert, do you have any deviating suggestions?

Actions #18

Updated by Katja Luther over 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

How should this look like? character label + ratioTo-label or character label + "ratio to " + ratioTo-label?

I suggest "Ratio {char1label}/{char2label} {property}". Alternatively "to" instead of slash.

Norbert, do you have any deviating suggestions?

Now the label looks like this
"Ratio structureLabel1 to structureLabel2 propertyLabel"

Actions #19

Updated by Katja Luther over 1 year ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is updated. This check should be removed.

this is fixed

This is still the case

sorry missed to commit the needed file

Actions #20

Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 80

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Also the formatting (label) for the character does not change yet even if it has no protected titleCache.

How should this look like? character label + ratioTo-label or character label + "ratio to " + ratioTo-label?

I suggest "Ratio {char1label}/{char2label} {property}". Alternatively "to" instead of slash.

Norbert, do you have any deviating suggestions?

Now the label looks like this
"Ratio structureLabel1 to structureLabel2 propertyLabel"

I thought about the label again and maybe it is better to use "{property} ratio {char1} to {char2}". If NK does not another suggestion please implement it this way and then we can close the ticket.

Actions #21

Updated by Andreas Müller over 1 year ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I guess this is for review.

Actions #22

Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

A final issue is that removing the "ratio to" with titleCache not being protected does not set back the titleCache to the default value (without "ratio").

Actions

Also available in: Atom PDF