Project

General

Profile

bug #9504

Changing term tree title is not persisted

Added by Andreas Müller 4 months ago. Updated 15 days ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
03/02/2021
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

If I create a new term tree and change the title before saving the title is reset to the default title after saving

Associated revisions

Revision 58bf9462 (diff)
Added by Katja Luther 3 months ago

ref #9504: handle changes of title

Revision f8d807a7 (diff)
Added by Katja Luther 2 months ago

ref #9504: fix saving label changes of newly created term trees

History

#1 Updated by Andreas Müller 3 months ago

  • Priority changed from New to Highest
  • Target version changed from Release 5.21 to Release 5.22

#2 Updated by Andreas Müller 3 months ago

  • Tags set to fast

Not sure if this is fast but I could imagine that it is.

#3 Updated by Katja Luther 3 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 0 to 50

this is fixed

#4 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

This still does not work

#5 Updated by Andreas Müller 3 months ago

By the way, it would good to use an underscore before the default title like "_New feature tree". Also having the focus and selection in the title cache field of the new feature tree. I don't know if this is easy to fix. If not, please open a new ticket.

#6 Updated by Katja Luther 3 months ago

Andreas Müller wrote:

This still does not work

I tested on nightly and it works? Did you update?

#7 Updated by Katja Luther 3 months ago

Andreas Müller wrote:

By the way, it would good to use an underscore before the default title like "_New feature tree". Also having the focus and selection in the title cache field of the new feature tree. I don't know if this is easy to fix. If not, please open a new ticket.

Create a new ticket #9572

#8 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

#9 Updated by Andreas Müller 3 months ago

Katja Luther wrote:

Andreas Müller wrote:

This still does not work

I tested on nightly and it works? Did you update?

Yes I did and I tried again and it does not work.

What I do:

  • Open term tree editor for features in rem_conf_am
  • Select "New Tree" from menu
  • Set focus to newly created tree (item)
  • go to details view and change the shown title from "New feature tree" to "Test persisted" (the new title is immediately visible in the tree)
  • press save
  • wait
  • after a while the title in the tree is reverted to "New feature tree"
  • close and reopen the term tree editor => title is still "New feature tree"

Unfortunately the changeset also includes the name changing of the classes so I can't see in the code what you have done or if there was a misunderstanding

#10 Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Katja Luther

#11 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

Actually I could not find why the newly created tree can not be edited before saving. When the tree is persisted you can edit the title and it is saved. I would put this ticket into 5.23 because with saving before editing the title there is a workaround for this problem.

#12 Updated by Andreas Müller 2 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Maybe we can have a look to this again, now, as there is still some time for the release. If not possible to solve before release move to next version.

#13 Updated by Katja Luther 2 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be fixed now. Please review.

#14 Updated by Andreas Müller 2 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 100

works as expected now

#15 Updated by Andreas Müller 15 days ago

  • Tags deleted (fast)

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)