Project

General

Profile

Actions

bug #9443

closed

Improve handling of TissueSamples and others in SpecimenTreeEditor

Added by Andreas Müller almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

50%

Estimated time:
Severity:
critical
Found in Version:

Description

Tissue Samples are handled stored as DnaSample in specimen tree editor which is not correct as they never can have any of the additional attributes that DnaSample offers.

Also other code needs to be adapted as there is some unnecessary casting to DnaSample involved and also some other restrictions.

Actions #1

Updated by Andreas Müller almost 2 years ago

  • Status changed from New to In Progress
  • Severity changed from normal to critical

The saving as Derived unit has been implemented in 5.19 already (a3b7c1e7f7b79) so it is now high priority to also remove the casting as it otherwise results in CCEs.

Actions #2

Updated by Andreas Müller almost 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 50

Saving as DerivedUnit needs to be reverted as we want to allow also TissueSample to have DNA Sequences attached directly (without having empty DNA Sample records).
So we should better try to implement the merge of DnaSample and DerivedUnit soon (#9455).

Actions #3

Updated by Andreas Müller almost 2 years ago

Still need to check if AddXXX handlers now work as expected and as before.

Actions #4

Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 5.21 to Release 5.20
Actions #5

Updated by Andreas Müller almost 2 years ago

The commit message of the last commit "handling tissue samples as DerivedUnit" was incorrect. Should be "revert handling ..."

Actions #6

Updated by Andreas Müller almost 2 years ago

  • Assignee changed from Andreas Müller to Katja Luther

Katja, can you check the commits of this ticket again if they look ok? Generally this ticket was reverted, however the removed class casts do make sense and therefore can stay, I think. Do you agree?

Can be closed if you agree.

Actions #7

Updated by Katja Luther almost 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller

looks fine and works as expected.

Actions

Also available in: Atom PDF