Project

General

Profile

bug #9443

Improve handling of TissueSamples and others in SpecimenTreeEditor

Added by Andreas Müller 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
02/02/2021
Due date:
% Done:

50%

Severity:
critical
Found in Version:

Description

Tissue Samples are handled stored as DnaSample in specimen tree editor which is not correct as they never can have any of the additional attributes that DnaSample offers.

Also other code needs to be adapted as there is some unnecessary casting to DnaSample involved and also some other restrictions.

Associated revisions

Revision a3b7c1e7 (diff)
Added by Katja Luther 5 months ago

create DerivedUnit of type TissueSample for tissueSamples instead of DNASample

Revision 381249d5 (diff)
Added by Andreas Müller 4 months ago

fix CCE for TissueSample in TissueSampleGeneralDetailElement

Revision ee4252e0 (diff)
Added by Andreas Müller 4 months ago

ref #9443 fix tissue sample handling in SampleDesignationDetailElement

Revision bf23ce59 (diff)
Added by Andreas Müller 4 months ago

ref #9443 fix tissue sample handling in DerivateLabelProvider

Revision aaf285ef (diff)
Added by Andreas Müller 4 months ago

ref #9443 broaden the usecases when media can be added to field or derived unit

Revision 7a03ad62 (diff)
Added by Andreas Müller 4 months ago

ref #9443 broaden the usecases when dnasample can be added to field or derived unit

Revision 05f06f64 (diff)
Added by Andreas Müller 4 months ago

ref #9443, ref #5575 tissue sample as DnaSample generation and initialization of DNA sample cache strategies

Revision 4fc7f502 (diff)
Added by Andreas Müller 4 months ago

ref #9443 handling tissue samples as DerivedUnit

History

#1 Updated by Andreas Müller 4 months ago

  • Status changed from New to In Progress
  • Severity changed from normal to critical

The saving as Derived unit has been implemented in 5.19 already (a3b7c1e7f7b79) so it is now high priority to also remove the casting as it otherwise results in CCEs.

#2 Updated by Andreas Müller 4 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 50

Saving as DerivedUnit needs to be reverted as we want to allow also TissueSample to have DNA Sequences attached directly (without having empty DNA Sample records).
So we should better try to implement the merge of DnaSample and DerivedUnit soon (#9455).

#3 Updated by Andreas Müller 4 months ago

Still need to check if AddXXX handlers now work as expected and as before.

#4 Updated by Andreas Müller 4 months ago

  • Target version changed from Release 5.21 to Release 5.20

#5 Updated by Andreas Müller 4 months ago

The commit message of the last commit "handling tissue samples as DerivedUnit" was incorrect. Should be "revert handling ..."

#6 Updated by Andreas Müller 4 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Katja, can you check the commits of this ticket again if they look ok? Generally this ticket was reverted, however the removed class casts do make sense and therefore can stay, I think. Do you agree?

Can be closed if you agree.

#7 Updated by Katja Luther 4 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller

looks fine and works as expected.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)