Project

General

Profile

bug #9405

task #4338: [MASTER] Handle abbreviated title and protected cache correctly in TaxEditor

Fields set to irrelevant for cache should be set by state only

Added by Andreas Müller 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
01/20/2021
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

follow up from #3737

Currently this is not yet the case as they are set during UI update by calling refresh only on certain fields and depending on the place in code where the update was triggered.


Related issues

Related to Edit - bug #4944: "Protected" indication for references needs to be improved Resolved 05/28/2015
Copied from Edit - bug #3737: Protected caches for taxa and names behave inconsistent Closed 10/17/2013
Copied to Edit - feature request #9417: Advanced issues for cache relevance handling New 01/23/2021

Associated revisions

Revision 202edbff (diff)
Added by Andreas Müller 5 months ago

ref #9405 , ref #4944 refactor the cache protection indication handling in TaxEditor details view elements

Revision c3b6d097 (diff)
Added by Andreas Müller 5 months ago

ref #9405 , ref #4944 fix NPE in CacheRelevanceHelper

Revision 5014c22f (diff)
Added by Andreas Müller 3 months ago

ref #9405, ref #4944 adapt colors for cache protected fields a bit

History

#1 Updated by Andreas Müller 5 months ago

  • Copied from bug #3737: Protected caches for taxa and names behave inconsistent added

#2 Updated by Andreas Müller 5 months ago

  • Subject changed from Fields set to irrelevant should be set by state only to Fields set to irrelevant for cache should be set by state only
  • Status changed from New to In Progress

#3 Updated by Andreas Müller 5 months ago

  • Related to bug #4944: "Protected" indication for references needs to be improved added

#4 Updated by Andreas Müller 5 months ago

This is mostly fixed. Some advanced features stay:

  • trigger updateCacheRelevance() with ToggledText state change listener (probably this is the SelectionListener)
  • improve handling of team members in Team element. (by setting a breakpoint somewhere at TeamMemberElement creation it becomes clearer how to insert registration
  • improve colors
  • handle also for other DetailElements like Collection detail element
  • improve use of ICacheRelevantFormElement in class hierarchies (probably the use can still be reduced)
  • implement RefType dependency (mostly of abbrevTitleCache) in ReferenceDetail view (also depending on cache strategy)
  • Very advanced: use cache strategy to define which fields are relevant

#5 Updated by Andreas Müller 5 months ago

#6 Updated by Andreas Müller 5 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 50

This should be fixed. I moved advanced issues to new ticket #9417. Please review.

This is also related to #4944. Please include this in review.

#8 Updated by Andreas Müller 5 months ago

The general idea of the refactoring is:

  • in a first step all elements which are relevant for a cache get do register the cache the depend on.
  • when the caches change the updateCacheRelevance() method is triggered for all such elements (this is currently still done with a cascading call, but better we should use a state change listener on the toggle/cache field (#9417) in future to make it all still more state dependend.
  • each cache field has a registered color (CacheRelevance), so if 2 different cache fields exist, it can be indicated by color for which cache the field is irrelevant (or for both with 3rd color)
  • fields only indirectly irrelevant (e.g. uninomial for an unprotected namecache but a protected titleCache) use a light color
  • as the relevant elements and sections do not all inherit from the same base classes a helper class CacheRelevanceHelper exists which handled typical method calls (decorator pattern)

#9 Updated by Katja Luther 5 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Andreas Müller

This seems to work correctly (also for references), I only added the colouring of the date field for references to #9417.

#10 Updated by Katja Luther 5 months ago

  • % Done changed from 50 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)