bug #9365
closed
Reuse taxon does not work in new Taxon dialogue
Added by Andreas Müller over 3 years ago.
Updated about 3 years ago.
Description
partly copied from #5114.
If reuse taxon is selected still a new taxon is created.
Also the secundum field should be disabled as long as reuse taxon is selected (it is already filled with the correct secundum).
- Description updated (diff)
- Status changed from New to Resolved
- % Done changed from 0 to 50
- Assignee changed from Katja Luther to Andreas Müller
- Severity changed from normal to blocker
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
- Severity changed from blocker to normal
The disabling of the secundum is still missing.
As you are now using a different method for createNewTaxonNode all the TaxonNode data like source and status are not persisted anymore.
I guess we should combine the 2 methods in a way that they use the same code except for all taxon related data.
So the reuse taxon method fetches the taxon and then runs the taxon node code and the DTO method creates the taxon and then runs the same code for taxon node data. Ofcourse the signature of the first method needs to be adapted, then.
This is fixed with the last commit for #9393
- Related to task #9407: Reuse taxon should check classification before save added
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
Andreas Müller wrote:
As you are now using a different method for createNewTaxonNode all the TaxonNode data like source and status are not persisted anymore.
I guess we should combine the 2 methods in a way that they use the same code except for all taxon related data.
Has this also been fixed? I can't see the code.
- Status changed from Feedback to Resolved
Andreas Müller wrote:
Andreas Müller wrote:
As you are now using a different method for createNewTaxonNode all the TaxonNode data like source and status are not persisted anymore.
I guess we should combine the 2 methods in a way that they use the same code except for all taxon related data.
Has this also been fixed? I can't see the code.
this is fixed, too.
- Assignee changed from Katja Luther to Andreas Müller
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
- % Done changed from 50 to 90
I changed it a bit the way that first it is checked if a taxon is reused, if not a new taxon is created (with according params) and it is checked if a name is reused. If not everything is created a new.
If reuse taxon or name do not exist an exception is thrown (until now a new taxon was created which is unwanted behavior I guess).
Please review updated code. If ok, close ticket.
- Status changed from Feedback to Closed
the looks fine, close the ticket.
Also available in: Atom
PDF