Project

General

Profile

bug #9365

Reuse taxon does not work in new Taxon dialogue

Added by Andreas Müller 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
12/22/2020
Due date:
% Done:

90%

Severity:
normal
Found in Version:

Description

partly copied from #5114.

If reuse taxon is selected still a new taxon is created.

Also the secundum field should be disabled as long as reuse taxon is selected (it is already filled with the correct secundum).


Related issues

Related to Edit - task #9407: Reuse taxon should check classification before save New 01/21/2021

Associated revisions

Revision de6b6edb (diff)
Added by Katja Luther 10 months ago

fix #9365: fix reuse taxon in newTaxonNodeWizard

Revision 39973b73 (diff)
Added by Katja Luther 9 months ago

ref #9393: disable sec selection if reused taxon is used

Revision c113bc55 (diff)
Added by Katja Luther 9 months ago

merge the two create taxon methods

Revision 0b2155a2 (diff)
Added by Andreas Müller 9 months ago

ref #9365 update code for reuse taxon (change order for check name and check taxon and throw exceptions if not exists)

History

#2 Updated by Andreas Müller 10 months ago

  • Description updated (diff)

#3 Updated by Katja Luther 10 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#4 Updated by Katja Luther 10 months ago

  • Assignee changed from Katja Luther to Andreas Müller
  • Severity changed from normal to blocker

please review

#5 Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • Severity changed from blocker to normal

The disabling of the secundum is still missing.

#6 Updated by Andreas Müller 9 months ago

As you are now using a different method for createNewTaxonNode all the TaxonNode data like source and status are not persisted anymore.

I guess we should combine the 2 methods in a way that they use the same code except for all taxon related data.

So the reuse taxon method fetches the taxon and then runs the taxon node code and the DTO method creates the taxon and then runs the same code for taxon node data. Ofcourse the signature of the first method needs to be adapted, then.

#7 Updated by Katja Luther 9 months ago

This is fixed with the last commit for #9393

#8 Updated by Andreas Müller 9 months ago

  • Related to task #9407: Reuse taxon should check classification before save added

#9 Updated by Katja Luther 9 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review.

#10 Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote:

As you are now using a different method for createNewTaxonNode all the TaxonNode data like source and status are not persisted anymore.

I guess we should combine the 2 methods in a way that they use the same code except for all taxon related data.

Has this also been fixed? I can't see the code.

#11 Updated by Katja Luther 9 months ago

  • Status changed from Feedback to Resolved

Andreas Müller wrote:

Andreas Müller wrote:

As you are now using a different method for createNewTaxonNode all the TaxonNode data like source and status are not persisted anymore.

I guess we should combine the 2 methods in a way that they use the same code except for all taxon related data.

Has this also been fixed? I can't see the code.

this is fixed, too.

#12 Updated by Katja Luther 9 months ago

  • Assignee changed from Katja Luther to Andreas Müller

#13 Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 90

I changed it a bit the way that first it is checked if a taxon is reused, if not a new taxon is created (with according params) and it is checked if a name is reused. If not everything is created a new.

If reuse taxon or name do not exist an exception is thrown (until now a new taxon was created which is unwanted behavior I guess).

Please review updated code. If ok, close ticket.

#14 Updated by Katja Luther 9 months ago

  • Status changed from Feedback to Closed

the looks fine, close the ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)