EDIT

Can you add a list to the description, which other operations are planned to have this workflow support?

Also the message seems to mention the old accepted taxon but I think finally we decided that here the old accepted taxon secundum doesn't matter. We only compare the new parent and the old synonym/new taxon.

Tested change accepted to synonym (with default preference)

Old parent sec1, oldAcc sec1, newAcc sec1 => warning (FALSE) if all 3 secundum are the same no reason for a warning
Old parent sec1, oldAcc sec2, newAcc sec1 => warning => keep => newAcc sec2 (OK)
Old parent sec1, oldAcc sec2, newAcc sec1 => warning => from acc => newAcc sec1 (OK)
Old parent sec1, oldAcc sec2, newAcc sec1 => warning => select sec3 => newAcc sec3 (OK)
Old parent sec1, oldAcc sec1, newAcc sec2 => warning => keep => newAcc sec1 (OK)
Old parent sec1, oldAcc sec1, newAcc sec2 => warning => from acc => newAcc sec1 (FALSE)
Old parent sec1, oldAcc sec1, newAcc sec2 => warning => select sec3 => newAcc sec3 (OK)
Old parent sec1, oldAcc sec2, newAcc sec2 => warning (FALSE)

There are 3 incorrect handlings

More tests are possible, with null values and with differing old parent

Tested change synonym to accepted taxon (with default preference)

OldAcc sec1, oldSyn sec1, newParent sec1 => newAcc null (FALSE!!, this is critical because core functionality)
OldAcc sec1, oldSyn sec2, newParent sec1 => warning => keep => newAcc sec2 (OK)
OldAcc sec1, oldSyn sec2, newParent sec1 => warning => from parent => newAcc sec1 (OK)
OldAcc sec1, oldSyn sec2, newParent sec1 => warning => select sec3 => newAcc sec3 (OK)
OldAcc sec1, oldSyn sec1, newParent sec2 => warning => keep => newAcc sec1 (OK)
OldAcc sec1, oldSyn sec1, newParent sec2 => warning => from parent => newAcc sec2 (OK)
OldAcc sec1, oldSyn sec1, newParent sec2 => warning => select sec3 => newAcc sec3 (OK)
OldAcc sec1, oldSyn sec2, newParent sec2 => newAcc null (FALSE!!)
OldAcc sec1, oldSyn null, newParent sec2 => warning => keep => newAcc null (OK)
OldAcc sec1, oldSyn null, newParent sec2 => warning => from parent => newAcc sec2 (OK)
OldAcc sec1, oldSyn sec2, newParent null => warning => keep => newAcc sec2 (OK)
OldAcc sec1, oldSyn sec2, newParent null => warning => from parent => newAcc null (OK)
OldAcc sec1, oldSyn null, newParent null => no warning, newAcc null (OK)

the deleting of the secundum if oldSyn and new parent secundum are same is the critical issue here

Further tested change accepted to synonym (with default preference)

Old parent sec2, oldAcc null, newAcc sec1 => warning => keep => newSyn sec1 (FALSE, should be null)
Old parent sec2, oldAcc null, newAcc sec1 => warning => from acc => newSyn sec1 (OK)
Old parent sec2, oldAcc null, newAcc sec1 => warning => select sec3 => newSyn sec3 (OK)

Katja, can you please run the same type of tests for

• move synonym to another taxon
• move accepted to new parent

and report the results here?

Andreas Müller wrote:

The preference says

Is it true that it is only for these 2 operations or should we adapt the label?

actually yes.

I test all other preferences (except for default preference) for change "synonym to accepted taxon" and "change taxon to synonym" and they all seem to work as expected

Andreas Müller wrote:

I test all other preferences (except for default preference) for change "synonym to accepted taxon" and "change taxon to synonym" and they all seem to work as expected

Ok, from your answer to the previous question I think this makes no sence as it is probably not yet implemented.

Probably we should should split the ticket then as this might be to much work for the upcoming release?

I have not checked but I guess that the secundum of other synonyms in the homotypic group is probably not checked yet? Similar to #8767#note-37

Andreas Müller wrote:

I have not checked but I guess that the secundum of other synonyms in the homotypic group is probably not checked yet? Similar to #8767#note-37

There is another question still not handled, should they all get the same sec? If they had different sec references before, or does this not exist?

Katja Luther wrote:

Andreas Müller wrote:

I have not checked but I guess that the secundum of other synonyms in the homotypic group is probably not checked yet? Similar to #8767#note-37

There is another question still not handled, should they all get the same sec? If they had different sec references before, or does this not exist?

I guess this exists as someone later may have added a synonym homotypic to a heterotypic synonym which existed not in the original treatment.

How to handle: depending on the decision I guess the same rule should be used for each synonym. So "keep" will keep ALL secundums, take from new parent will set secundum for ALL synonyms and the same for "select new sedundum".

Andreas Müller wrote:

If an accepted taxon is converted to a synonym (for an accepted taxon with same sec) its homotypic synonym having the same sec looses the sec !

oldAcc sec1, oldAccHom sec1, newAcc sec1 => no warning, newSyn sec1, newSynHom null (FALSE should be newSynHom sec1)

this is fixed.
also fixed for change synonym to accepted taxon

For default preference "Keep when same"

Synonym to accepted, keep

syn ref1, homotypic syn ref2, parent ref3 -> newTaxon ref1, syn2 ref2, parent ref3 (OK)
syn ref1, hom. syn null, parent ref1 -> newTaxon ref1, hom. syn null, parent ref1 (OK)
syn null, homotypic syn ref2, parent ref3 -> newTaxon null, syn2 ref2, parent ref3 (OK)
syn ref1, homotypic syn ref2, parent null-> newTaxon ref1, syn2 ref2, parent null(OK)
syn ref1, hom. syn ref2, parent ref1 -> newTaxon ref1, hom. syn ref1, parent ref1 (OK)

Synonym to accepted, use parent sec

syn null, homotypic syn null, parent ref3 -> newTaxon ref3, syn2 ref3, parent ref3 (OK)
syn ref1, hom. syn ref2, parent null-> newTaxon null, hom. syn null, parent null(OK)
syn null, homotypic syn null, parent ref3 -> newTaxon ref3, syn2 ref3, parent ref3 (OK)
syn ref1, hom. syn ref2, parent ref1 -> newTaxon ref1, hom. syn ref1, parent ref1 (OK)

Synonym to accepted, choose sec:

syn null, homotypic syn ref1, parent ref2, choose ref3 -> newTaxon ref3, syn2 ref3, parent ref2 (OK)
syn ref1, hom. syn ref1, parent null, choose ref3-> newTaxon ref3, hom. syn ref3, parent null(OK)

For Accepted to synonym it is more difficult to check the homotypical group because we only have the taxonnode DTO. Therefore I checked only the old accepted and the new synonym. The decision is used for all moved taxonbases.

Accepted to synonym, keep:

oldAcc sec1, acc sec2: syn sec1, acc sec2 (OK)
oldAcc sec1, acc sec1: syn sec1, acc sec1 (without warning , OK)
oldAcc null, acc sec1: syn null, acc sec1 (OK)
oldAcc sec1, acc null: syn sec1, acc null (OK)

accepted to syn, use parent sec:

oldAcc sec1, acc sec2: syn sec2, acc sec2 (OK)
oldAcc sec1, acc sec1: syn sec1, acc sec1 (without warning OK)
oldAcc null, acc sec1: syn sec1, acc sec1 (OK)
oldAcc sec1, acc null: syn null, acc null (OK)

accepted to syn, choose new sec if secs are different:

oldAcc sec1, acc sec2 choosed sec3: syn sec3, acc sec2 (OK)
oldAcc sec1, acc sec1: syn sec1, acc sec1 (without warning and without selection OK)
oldAcc null, acc sec1, choosed sec3:: syn sec3, acc sec1 (OK)
oldAcc sec1, acc null, choosed sec3:: syn sec3, acc null (OK)