Project

General

Profile

Actions

feature request #9332

closed

Rename TypeDesignationBase.source to .designationSource

Added by Andreas Müller over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

as simple "source" creates confusion as there are also the general sources attached to TypeDesignationBase.


Related issues

Related to EDIT - feature request #6581: Make all microreferenced references OriginalSourcesClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 3 years ago

  • Priority changed from New to Highest
Actions #2

Updated by Andreas Müller about 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

This is solved in cdmlib but we need to check if it works in TaxEditor and vaadin

Actions #3

Updated by Andreas Müller about 3 years ago

  • Status changed from Resolved to Closed
  • Target version changed from CDM UML 5.43 to Release 5.22
  • % Done changed from 50 to 100
Actions #4

Updated by Andreas Müller about 3 years ago

Actions #5

Updated by Andreas Kohlbecker about 3 years ago

  • Status changed from Closed to Resolved
  • % Done changed from 100 to 40

the renamed field is causing LIEs in cdm-vaadin, so this ticket is not fully solved.

e.g.

http://test.e-taxonomy.eu/cdmserver/phycobank/app/registration#!workingset/4e40184e-815c-4fd2-abe1-570040dde8ef

Caused by: org.hibernate.LazyInitializationException: failed to lazily initialize a collection of role: eu.etaxonomy.cdm.model.reference.OriginalSourceBase.annotations, could not initialize proxy - no Session
    at org.hibernate.collection.internal.AbstractPersistentCollection.throwLazyInitializationException(AbstractPersistentCollection.java:584)
    at org.hibernate.collection.internal.AbstractPersistentCollection.withTemporarySessionIfNeeded(AbstractPersistentCollection.java:201)
    at org.hibernate.collection.internal.AbstractPersistentCollection.readSize(AbstractPersistentCollection.java:145)
    at org.hibernate.collection.internal.PersistentSet.isEmpty(PersistentSet.java:149)
    at eu.etaxonomy.cdm.model.common.AnnotatableEntity.checkEmpty(AnnotatableEntity.java:180)
    at eu.etaxonomy.cdm.model.reference.OriginalSourceBase.checkEmpty(OriginalSourceBase.java:293)
    at eu.etaxonomy.cdm.model.reference.NamedSourceBase.checkEmpty(NamedSourceBase.java:88)
    at eu.etaxonomy.cdm.model.name.TypeDesignationBase.checkNullSource(TypeDesignationBase.java:302)
    at eu.etaxonomy.cdm.model.name.TypeDesignationBase.setCitation_aroundBody6(TypeDesignationBase.java:267)
    at eu.etaxonomy.cdm.model.name.TypeDesignationBase.setCitation_aroundBody7$advice(TypeDesignationBase.java:46)
    at eu.etaxonomy.cdm.model.name.TypeDesignationBase.setCitation(TypeDesignationBase.java:1)
    at eu.etaxonomy.cdm.vaadin.model.registration.SpecimenTypeDesignationDTO.setDesignationReference(SpecimenTypeDesignationDTO.java:222)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

Apparently all init-strategies for name and specimen type designations still need to be adaptet.

Actions #6

Updated by Andreas Kohlbecker about 3 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 40 to 100

should be fixed now

Actions

Also available in: Atom PDF