Project

General

Profile

Actions

feature request #9324

closed

Enable designation reference editing in name type designation

Added by Wolf-Henning Kusber about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

Main issues:

6: enable to select an available section (new names) or create a new section (for e.g. lecto- or neotypes) - SOLVED in #9301
7: no idea if we need the editon of references here (I would say: no). - see discussion below
8: citation detail --> is not needed for phycobank since we will create dedicated sections. Allow to hide this field per configuration parameter - TODO

Further issues:
1: This might be not a button, but an entry in the dropdown. Warning: if seleted, it can be combined with a type status
2: This might be not a button, but an entry in the dropdown (same warning)
3: This makes for PhycoBank not much sense, because then we have no data to enter. Possible usage, if a type is given, but not marked as "here designated" this structure might be used (discussion needed).
4: The dropdown may interfer with the buttons at the top.
5: If a status is selected this cannot be made undone. - SOLVED


Files

picture949-1.png (43.3 KB) picture949-1.png Wolf-Henning Kusber, 11/25/2020 07:15 PM

Related issues

Related to EDIT - bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by defaultClosedAndreas Kohlbecker

Actions
Copied to EDIT - bug #9453: Implement NameDesignationBase.hasDesignationSource() which takes isRejected and isConserved into account NewWolf-Henning Kusber

Actions
Actions #1

Updated by Andreas Kohlbecker almost 2 years ago

  • Priority changed from Priority13 to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.19
Actions #2

Updated by Andreas Kohlbecker almost 2 years ago

  • Description updated (diff)
Actions #3

Updated by Andreas Kohlbecker almost 2 years ago

  • Target version changed from Release 5.19 to Release 5.21
Actions #4

Updated by Andreas Kohlbecker almost 2 years ago

  • Description updated (diff)
Actions #5

Updated by Andreas Kohlbecker almost 2 years ago

  • Related to bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by default added
Actions #6

Updated by Andreas Kohlbecker almost 2 years ago

  • Description updated (diff)

7: no idea if we need the editon of references here (I would say: no).

editing of references is enabled be default, but could be disabled if really needed.

Points 1 to 4 are subject to another ticket and should be discussed separately. @Hennnig: could you please open a new ticket for this?

Actions #7

Updated by Andreas Kohlbecker almost 2 years ago

  • Subject changed from Enable section in name type designation to Enable deignation reference editing in name type designation
  • Status changed from New to Resolved
  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber
  • % Done changed from 0 to 50

allowing null selection for type status in name type designation editor implemented.

so this ticket can be reviewed

Actions #8

Updated by Andreas Kohlbecker almost 2 years ago

  • Description updated (diff)
Actions #9

Updated by Wolf-Henning Kusber almost 2 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 70

Allowing null selection for type status in name type designation editor implemented.
Is functioning as expected.

Note 1: Rejected type and Conserved type have a reference.
Note 2: A reference given for e.g. a lectotype for a name type in preparation is safed. In a second step the status is set to orignial designation: The Reference disappears but, as far as I can see, this causes no problems.
Note 3: proposed types for rejection/conservation with references are missing.

Actions #10

Updated by Andreas Kohlbecker almost 2 years ago

  • Subject changed from Enable deignation reference editing in name type designation to Enable designation reference editing in name type designation
Actions #11

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

Wolf-Henning Kusber wrote:

Allowing null selection for type status in name type designation editor implemented.
Is functioning as expected.

Note 1: Rejected type and Conserved type have a reference.

--> copied to #9453

Note 2: A reference given for e.g. a lectotype for a name type in preparation is safed. In a second step the status is set to orignial designation: The Reference disappears but, as far as I can see, this causes no problems.

OK, good!

Note 3: proposed types for rejection/conservation with references are missing.

These flags are separate from the states in the cdm model. As far as my understanding goes, these are not type status per se. Is the application of a type status and one of these two flags mutually exclusive? Does the same also account for "not designated"?

Actions #12

Updated by Andreas Kohlbecker almost 2 years ago

  • Copied to bug #9453: Implement NameDesignationBase.hasDesignationSource() which takes isRejected and isConserved into account added
Actions #13

Updated by Wolf-Henning Kusber almost 2 years ago

example for Note 3: proposed types for rejection/conservation with references are missing.

species

Achnanthes quadricauda Turpin in Mém. Mus. Hist. Nat. 16: 311. 1828.
Typus: [specimen from strain] Hungary, Lake Belsö-tó, Hegewald 1971/256 (Kernforschungsanlage Jülich, Germany) (typ. cons.).

Genus

Astasia Dujard., Hist. Nat. Zoophyt.: 353, 356. 1841.
Typus: A. limpida Dujard. (typ. cons.).

Auricula Hill, Brit. Herb.: 98. 31 Mar 1756 [Angiosp.: Primul. / Primul.].
Typus: non designatus.

Actions #14

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 70 to 100

Note 3: proposed types for rejection/conservation with references are missing.

we (Henning & Andreas) decided to postpone this discussion.

So this ticket is complete.

Actions #15

Updated by Andreas Kohlbecker almost 2 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
Actions #16

Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 5.21 to Release 5.20
Actions

Also available in: Atom PDF