Project

General

Profile

Actions

feature request #9301

closed

SpecimenTypeDesignationEditor: Add fields for citation and citationDetail

Added by Andreas Kohlbecker about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

for all TypeDesignations where typeStatus.hasDesignationSource() == true field for citation and citationDetail need to be available.

As this will increase the width of the SpecimenTypeDesignationDTORow we will need a better list editor which allows for more complex layouts per item.


Related issues

Related to EDIT - bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by defaultClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #9408: SpecimenTypeDesignation collection editor with grid-form per item instead of looong rowsNewAndreas Kohlbecker

Actions
Related to EDIT - bug #8140: Update list of type designation status which allow an explicit sourceClosedWolf-Henning Kusber

Actions
Has duplicate EDIT - feature request #9325: Enable section in specimen type designationDuplicateAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Kohlbecker about 2 years ago

  • Related to bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by default added
Actions #2

Updated by Andreas Kohlbecker almost 2 years ago

  • Description updated (diff)
  • Target version changed from Unassigned CDM tickets to Release 5.19
Actions #3

Updated by Andreas Kohlbecker almost 2 years ago

  • Priority changed from New to Highest
Actions #4

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #5

Updated by Andreas Kohlbecker almost 2 years ago

  • Related to feature request #9408: SpecimenTypeDesignation collection editor with grid-form per item instead of looong rows added
Actions #6

Updated by Andreas Kohlbecker almost 2 years ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

improvements to the layout will be done in #9408

The requested fields are now added and can be tested.

Actions #7

Updated by Wolf-Henning Kusber almost 2 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 70

The fields are shown, if needed.

The selection of type status (all checked) in SpecimenTypDesignationEditor is fine,
except of the different treatment of paralectotype (enabled) and paraneotype (disabled).
Even though some persons designate paratypes, it is normally something, interpreted later, not designated by the authors. May be all paratypes should be disabled for designation reference and detail.

The display in Vaadin as short citation (only family name(s) and year is fine.

See also review of #9290
Only the references in used in the Working set = Reference of the designation plus all sections within the Reference of the registration working set should be available for selection, not more.

Problems arise when differing references are selected, or selected references of unpublished registrations have been changed (Validation errors, that cannot be handled by users or curators).

Actions #8

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Resolved to In Progress
  • % Done changed from 70 to 40
Actions #9

Updated by Andreas Kohlbecker almost 2 years ago

  • Target version changed from Release 5.19 to Release 5.21
Actions #10

Updated by Andreas Kohlbecker almost 2 years ago

Actions #11

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 40 to 50

can be reviewed

Actions #12

Updated by Andreas Kohlbecker almost 2 years ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber
Actions #13

Updated by Wolf-Henning Kusber almost 2 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 90

Works as expected.

paralectotype (enabled)-> reference should be disabled like the other paratypes (see above)

Actions #14

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100

Wolf-Henning Kusber wrote:

Works as expected.

paralectotype (enabled)-> reference should be disabled like the other paratypes (see above)

The decision to treat paralectotypes that way has been made in #8140 and is "hard-coded" in the cdmlib. This ticket is still open. I am copying your comment to that ticket.

Actions #15

Updated by Andreas Kohlbecker almost 2 years ago

  • Related to bug #8140: Update list of type designation status which allow an explicit source added
Actions #16

Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 5.21 to Release 5.20
Actions

Also available in: Atom PDF