Project

General

Profile

feature request #9301

SpecimenTypeDesignationEditor: Add fields for citation and citationDetail

Added by Andreas Kohlbecker 3 months ago. Updated 19 days ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
11/13/2020
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

for all TypeDesignations where typeStatus.hasDesignationSource() == true field for citation and citationDetail need to be available.

As this will increase the width of the SpecimenTypeDesignationDTORow we will need a better list editor which allows for more complex layouts per item.


Related issues

Related to Edit - bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by default Closed 11/10/2020
Related to Edit - feature request #9408: SpecimenTypeDesignation collection editor with grid-form per item instead of looong rows New 01/21/2021
Related to Edit - bug #8140: Update list of type designation status which allow an explicit source Feedback 02/25/2019
Duplicated by Edit - feature request #9325: Enable section in specimen type designation Duplicate 11/25/2020

Associated revisions

Revision 06db1b37 (diff)
Added by Andreas Kohlbecker about 1 month ago

fix #9301 adding designationReference and detail to specimen type designation editor

Revision 5f44e659 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9301 extending init-strategy to include typeDesignation.source.*

Revision ff00d7e8 (diff)
Added by Andreas Kohlbecker 30 days ago

ref #9301 static helper method to find the nom. act of a registration

Revision 7e1a46e1 (diff)
Added by Andreas Kohlbecker 30 days ago

ref #9301 limiting designation sources to the publication unit and sub sections

History

#1 Updated by Andreas Kohlbecker 3 months ago

  • Related to bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by default added

#2 Updated by Andreas Kohlbecker about 1 month ago

  • Description updated (diff)
  • Target version changed from Unassigned CDM tickets to Release 5.19

#3 Updated by Andreas Kohlbecker about 1 month ago

  • Priority changed from New to Highest

#4 Updated by Andreas Kohlbecker about 1 month ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#5 Updated by Andreas Kohlbecker about 1 month ago

  • Related to feature request #9408: SpecimenTypeDesignation collection editor with grid-form per item instead of looong rows added

#6 Updated by Andreas Kohlbecker about 1 month ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

improvements to the layout will be done in #9408

The requested fields are now added and can be tested.

#7 Updated by Wolf-Henning Kusber about 1 month ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 70

The fields are shown, if needed.

The selection of type status (all checked) in SpecimenTypDesignationEditor is fine,
except of the different treatment of paralectotype (enabled) and paraneotype (disabled).
Even though some persons designate paratypes, it is normally something, interpreted later, not designated by the authors. May be all paratypes should be disabled for designation reference and detail.

The display in Vaadin as short citation (only family name(s) and year is fine.

See also review of #9290
Only the references in used in the Working set = Reference of the designation plus all sections within the Reference of the registration working set should be available for selection, not more.

Problems arise when differing references are selected, or selected references of unpublished registrations have been changed (Validation errors, that cannot be handled by users or curators).

#8 Updated by Andreas Kohlbecker 30 days ago

  • Status changed from Resolved to In Progress
  • % Done changed from 70 to 40

#9 Updated by Andreas Kohlbecker 27 days ago

  • Target version changed from Release 5.19 to Release 5.21

#10 Updated by Andreas Kohlbecker 24 days ago

#11 Updated by Andreas Kohlbecker 24 days ago

  • Status changed from In Progress to Resolved
  • % Done changed from 40 to 50

can be reviewed

#12 Updated by Andreas Kohlbecker 24 days ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

#13 Updated by Wolf-Henning Kusber 20 days ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 90

Works as expected.

paralectotype (enabled)-> reference should be disabled like the other paratypes (see above)

#14 Updated by Andreas Kohlbecker 20 days ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100

Wolf-Henning Kusber wrote:

Works as expected.

paralectotype (enabled)-> reference should be disabled like the other paratypes (see above)

The decision to treat paralectotypes that way has been made in #8140 and is "hard-coded" in the cdmlib. This ticket is still open. I am copying your comment to that ticket.

#15 Updated by Andreas Kohlbecker 20 days ago

  • Related to bug #8140: Update list of type designation status which allow an explicit source added

#16 Updated by Andreas Müller 19 days ago

  • Target version changed from Release 5.21 to Release 5.20

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)