Project

General

Profile

Actions

bug #9290

closed

stop setting Registration.citation as citation for TypeDesignations in all type editors by default

Added by Andreas Kohlbecker about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:
Tags:

Description

As shown in the analysis ( TaxonName and Typedesignation citations unequal_diff.xlsx ) using the Registration.citation as citation for TypeDesignations currently causes inconsistencies.

In many cases the Name.nomenclaturalReference is a Section of an Article. Due to the mechanism currently implemented the TypeDesignations receive the Article instead, the article which is the in-reference of the section. This could be corrected for all the found inconsistent cases bout would impose a complex management in the UI to adjust the typeDesignation.citation in case the section reference in the name is being changed.

It is better to stop using the Registration.citation as citation for TypeDesignations in all type editors since this does not conform to the intended use of the TypeDesignations.citation property.

This also involves to hide the citation and ciation detail for all NameTypes which have NameTypeDesignationStatus.hasDesignationSource() == false

Update (2020-11-13):

There is a crucial misconception in the SpecimenTypeDesignationWorkingSetDTO:

The SpecimenTypeDesignationWorkingsetEditorPresenter.loadBeanById(Object identifier) receives in the identifier object the referenceId from the RegistrationWorkingsetPresenter.onTypeDesignationWorkingsetAdd(TypeDesignationWorkingsetEditorAction event) method where the reference of the RegistrationWorkingset (e.g. Article) is passed to the type designation workingset:

identifierSet = new TypeDesignationWorkingsetEditorIdSet(
        event.getRegistrationUuid(),
        getView().getCitationUuid(), // FIXME This may pass the reference (e.g. Article) from RegistrationWorkingsetView
                    // to the TypeDesignationWorkingset even if the nomenclatural act is a Section !!! --> #9290
        typifiedNameUuid
        );

The SpecimenTypeDesignationWorkingSetServiceImpl.save(SpecimenTypeDesignationWorkingSetDTO<? extends VersionableEntity> dto) in erroneously saves the citation with each of the SpecimenTypeDesignations.

This is the cause for in inconsistend data which has been shown in the Excel sheet.

For a solution to this problem the following is needed:

  1. 'SpecimenTypeDesignationWorkingSetServiceImpl.save(SpecimenTypeDesignationWorkingSetDTO<? extends VersionableEntity> dto)': Stop setting the citation before saving. DONE
  2. If the citation is somehow really for the workflow and there is no way to chanage this, we should rather pass the registration reference in RegistrationWorkingsetPresenter.onTypeDesignationWorkingsetAdd(TypeDesignationWorkingsetEditorAction event) DONE
  3. SpecimenTypeDesignationEditor: Add fields for citation and citationDetail --> #9301 DONE

Files


Related issues

Related to EDIT - task #9291: Clear all unnecesary TypeDesignation.citation entities and citationDetailsClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #9301: SpecimenTypeDesignationEditor: Add fields for citation and citationDetailClosedAndreas Kohlbecker

Actions
Related to EDIT - bug #9302: Phycobank related issues for TypeDesignation formattingIn ProgressAndreas Müller

Actions
Related to EDIT - task #9308: Supress "designated by" reference in portal in registration ListView and RegistrationWorkingSetEditorClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #9324: Enable designation reference editing in name type designationClosedAndreas Kohlbecker

Actions
Related to EDIT - bug #9468: specimen type of existing name cannot be savedWorksformeAndreas Kohlbecker

Actions
Related to EDIT - bug #9568: TypeSpecimenEditor: Selection of a reference of an typified imageClosedAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Kohlbecker about 2 years ago

  • Related to task #9291: Clear all unnecesary TypeDesignation.citation entities and citationDetails added
Actions #2

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #3

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #4

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #5

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #6

Updated by Andreas Kohlbecker about 2 years ago

Update to the Excel file.

Now the reference type is also shown.

"Irregular" Reference Types are highlighted.

Actions #7

Updated by Andreas Kohlbecker about 2 years ago

  • File deleted (TaxonName and Typedesignation citations unequal_diff.xlsx)
Actions #8

Updated by Andreas Kohlbecker about 2 years ago

  • Related to feature request #9301: SpecimenTypeDesignationEditor: Add fields for citation and citationDetail added
Actions #9

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #10

Updated by Andreas Müller about 2 years ago

  • Related to bug #9302: Phycobank related issues for TypeDesignation formatting added
Actions #11

Updated by Andreas Kohlbecker about 2 years ago

  • Related to task #9308: Supress "designated by" reference in portal in registration ListView and RegistrationWorkingSetEditor added
Actions #12

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

Hi Henning, could you please make some tests in the test-server to make sure the changes are not causing problems with exiting specimen- and name-type-designations and if creating new ones works well.

The "Citation"-field in the name type designation editor has been re-labeled to "Designation reference" in order to better clarify its purpose. Are you ok with this or do you prefer something else?

BTW: The "Designation reference" still cant be edited. this is subject to another ticket: #9301

Actions #13

Updated by Andreas Kohlbecker almost 2 years ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber
Actions #14

Updated by Wolf-Henning Kusber almost 2 years ago

re-labeled to "Designation reference": perfect

function is there but not user-friendly

Only the references in used in the Working set = Reference of the designation plus all sections within the Reference of the registration working set should be available for selection, not more.

Problems arise when differing references are selected, or selected references of unpublished registrations have been changed (Validation errors, that cannot be handled by users or curators).

Actions #15

Updated by Wolf-Henning Kusber almost 2 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 70

Selection disabled/enabled in SpecimenTypeDesignationEditor see #9301
Selection disabled/enabled in NameTypeDesignationEditor is correct.

Actions #16

Updated by Wolf-Henning Kusber almost 2 years ago

Published Specimen Types which are holotypes are displayed as "designated by" in Vaadin. For new names this is now impossible. Workaround: unlock the record, open type, safe type, than the unnecessary "designated by" is gone.

Actions #17

Updated by Andreas Kohlbecker almost 2 years ago

  • Subject changed from stop using the Registration.citation as citation for TypeDesignations in all type editors to stop setting Registration.citation as citation for TypeDesignations in all type editors by default
Actions #18

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Resolved to In Progress
  • % Done changed from 70 to 50
Actions #19

Updated by Andreas Kohlbecker almost 2 years ago

  • Target version changed from Release 5.19 to Release 5.21
Actions #20

Updated by Andreas Kohlbecker almost 2 years ago

Actions #21

Updated by Andreas Kohlbecker almost 2 years ago

Actions #22

Updated by Andreas Kohlbecker almost 2 years ago

Actions #23

Updated by Andreas Kohlbecker almost 2 years ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

this ticket is fully solved now, please review

Actions #24

Updated by Wolf-Henning Kusber almost 2 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 100

Reference is now selectable in relevant cases, but not anymore a default.

Actions #25

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Resolved to Closed
Actions #26

Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 5.21 to Release 5.20
Actions #27

Updated by Andreas Kohlbecker almost 2 years ago

  • Related to bug #9468: specimen type of existing name cannot be saved added
Actions #28

Updated by Andreas Kohlbecker over 1 year ago

  • Related to bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image added
Actions

Also available in: Atom PDF