Project

General

Profile

bug #9290

stop setting Registration.citation as citation for TypeDesignations in all type editors by default

Added by Andreas Kohlbecker 12 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
11/10/2020
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

As shown in the analysis ( TaxonName and Typedesignation citations unequal_diff.xlsx ) using the Registration.citation as citation for TypeDesignations currently causes inconsistencies.

In many cases the Name.nomenclaturalReference is a Section of an Article. Due to the mechanism currently implemented the TypeDesignations receive the Article instead, the article which is the in-reference of the section. This could be corrected for all the found inconsistent cases bout would impose a complex management in the UI to adjust the typeDesignation.citation in case the section reference in the name is being changed.

It is better to stop using the Registration.citation as citation for TypeDesignations in all type editors since this does not conform to the intended use of the TypeDesignations.citation property.

This also involves to hide the citation and ciation detail for all NameTypes which have NameTypeDesignationStatus.hasDesignationSource() == false

Update (2020-11-13):

There is a crucial misconception in the SpecimenTypeDesignationWorkingSetDTO:

The SpecimenTypeDesignationWorkingsetEditorPresenter.loadBeanById(Object identifier) receives in the identifier object the referenceId from the RegistrationWorkingsetPresenter.onTypeDesignationWorkingsetAdd(TypeDesignationWorkingsetEditorAction event) method where the reference of the RegistrationWorkingset (e.g. Article) is passed to the type designation workingset:

identifierSet = new TypeDesignationWorkingsetEditorIdSet(
        event.getRegistrationUuid(),
        getView().getCitationUuid(), // FIXME This may pass the reference (e.g. Article) from RegistrationWorkingsetView
                    // to the TypeDesignationWorkingset even if the nomenclatural act is a Section !!! --> #9290
        typifiedNameUuid
        );

The SpecimenTypeDesignationWorkingSetServiceImpl.save(SpecimenTypeDesignationWorkingSetDTO<? extends VersionableEntity> dto) in erroneously saves the citation with each of the SpecimenTypeDesignations.

This is the cause for in inconsistend data which has been shown in the Excel sheet.

For a solution to this problem the following is needed:

  1. 'SpecimenTypeDesignationWorkingSetServiceImpl.save(SpecimenTypeDesignationWorkingSetDTO<? extends VersionableEntity> dto)': Stop setting the citation before saving. DONE
  2. If the citation is somehow really for the workflow and there is no way to chanage this, we should rather pass the registration reference in RegistrationWorkingsetPresenter.onTypeDesignationWorkingsetAdd(TypeDesignationWorkingsetEditorAction event) DONE
  3. SpecimenTypeDesignationEditor: Add fields for citation and citationDetail --> #9301 DONE

TaxonName and Typedesignation citations unequal_diff.xlsx (163 KB) Andreas Kohlbecker, 11/13/2020 04:35 PM


Related issues

Related to Edit - task #9291: Clear all unnecesary TypeDesignation.citation entities and citationDetails Closed 11/10/2020
Related to Edit - feature request #9301: SpecimenTypeDesignationEditor: Add fields for citation and citationDetail Closed 11/13/2020
Related to Edit - bug #9302: Phycobank related issues for TypeDesignation formatting In Progress 11/14/2020
Related to Edit - task #9308: Supress "designated by" reference in portal in registration ListView and RegistrationWorkingSetEditor Closed 11/16/2020
Related to Edit - feature request #9324: Enable designation reference editing in name type designation Closed 11/25/2020
Related to Edit - bug #9468: specimen type of existing name cannot be saved Worksforme 02/15/2021
Related to Edit - bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image Closed 03/30/2021

Associated revisions

Revision da219650 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9290 comment on typdesignation citation problem

Revision 508b8f01 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 NameTypeDesignationEditor now using designation reference correctly

Revision 91e53109 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 SpecimenTypeDesignationEditor now using designation reference correctly

Revision cc9c04a4 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 cleaning up

Revision 0b71a670 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 making TypeDesignationWorkingsetEditorIdSet --> TypeDesignationWorkingsetIds more clear

Revision d7d6bc83 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 making TypeDesignationWorkingsetEditorIdSet --> TypeDesignationWorkingsetIds more clear

Revision c27b3a19 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 castTo method for TypedEntityReference

Revision 303a8ebc (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 limiting designation sources to the publication unit and sub sections in NameTypeDesignationEditor

Revision 8822b122 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 limiting available designation status types for nom acts without a name - SpecimenTypeDesignationEditor

Revision f756340a (diff)
Added by Andreas Kohlbecker 9 months ago

ref #9290 limiting available designation status types for nom acts without a name - NameTypeDesignationEditor & improving previous code

History

#1 Updated by Andreas Kohlbecker 12 months ago

  • Related to task #9291: Clear all unnecesary TypeDesignation.citation entities and citationDetails added

#2 Updated by Andreas Kohlbecker 12 months ago

  • Description updated (diff)

#3 Updated by Andreas Kohlbecker 12 months ago

  • Description updated (diff)

#4 Updated by Andreas Kohlbecker 12 months ago

  • Description updated (diff)

#5 Updated by Andreas Kohlbecker 12 months ago

  • Description updated (diff)

#6 Updated by Andreas Kohlbecker 11 months ago

Update to the Excel file.

Now the reference type is also shown.

"Irregular" Reference Types are highlighted.

#7 Updated by Andreas Kohlbecker 11 months ago

  • File deleted (TaxonName and Typedesignation citations unequal_diff.xlsx)

#8 Updated by Andreas Kohlbecker 11 months ago

  • Related to feature request #9301: SpecimenTypeDesignationEditor: Add fields for citation and citationDetail added

#9 Updated by Andreas Kohlbecker 11 months ago

  • Description updated (diff)

#10 Updated by Andreas Müller 11 months ago

  • Related to bug #9302: Phycobank related issues for TypeDesignation formatting added

#11 Updated by Andreas Kohlbecker 11 months ago

  • Related to task #9308: Supress "designated by" reference in portal in registration ListView and RegistrationWorkingSetEditor added

#12 Updated by Andreas Kohlbecker 9 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

Hi Henning, could you please make some tests in the test-server to make sure the changes are not causing problems with exiting specimen- and name-type-designations and if creating new ones works well.

The "Citation"-field in the name type designation editor has been re-labeled to "Designation reference" in order to better clarify its purpose. Are you ok with this or do you prefer something else?

BTW: The "Designation reference" still cant be edited. this is subject to another ticket: #9301

#13 Updated by Andreas Kohlbecker 9 months ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

#14 Updated by Wolf-Henning Kusber 9 months ago

re-labeled to "Designation reference": perfect

function is there but not user-friendly

Only the references in used in the Working set = Reference of the designation plus all sections within the Reference of the registration working set should be available for selection, not more.

Problems arise when differing references are selected, or selected references of unpublished registrations have been changed (Validation errors, that cannot be handled by users or curators).

#15 Updated by Wolf-Henning Kusber 9 months ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 70

Selection disabled/enabled in SpecimenTypeDesignationEditor see #9301
Selection disabled/enabled in NameTypeDesignationEditor is correct.

#16 Updated by Wolf-Henning Kusber 9 months ago

Published Specimen Types which are holotypes are displayed as "designated by" in Vaadin. For new names this is now impossible. Workaround: unlock the record, open type, safe type, than the unnecessary "designated by" is gone.

#17 Updated by Andreas Kohlbecker 9 months ago

  • Subject changed from stop using the Registration.citation as citation for TypeDesignations in all type editors to stop setting Registration.citation as citation for TypeDesignations in all type editors by default

#18 Updated by Andreas Kohlbecker 9 months ago

  • Status changed from Resolved to In Progress
  • % Done changed from 70 to 50

#19 Updated by Andreas Kohlbecker 9 months ago

  • Target version changed from Release 5.19 to Release 5.21

#20 Updated by Andreas Kohlbecker 9 months ago

#21 Updated by Andreas Kohlbecker 9 months ago

#22 Updated by Andreas Kohlbecker 9 months ago

#23 Updated by Andreas Kohlbecker 9 months ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

this ticket is fully solved now, please review

#24 Updated by Wolf-Henning Kusber 9 months ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 100

Reference is now selectable in relevant cases, but not anymore a default.

#25 Updated by Andreas Kohlbecker 9 months ago

  • Status changed from Resolved to Closed

#26 Updated by Andreas Müller 9 months ago

  • Target version changed from Release 5.21 to Release 5.20

#27 Updated by Andreas Kohlbecker 8 months ago

  • Related to bug #9468: specimen type of existing name cannot be saved added

#28 Updated by Andreas Kohlbecker 6 months ago

  • Related to bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)