EDIT

Applied in changeset cdmlib|593c7701c265521b6e3701942e0f6c7756304963.

please review

The above requirement works as expected but I do not fully agree to the requirement. I think we discussed this some time ago already.

In caryo_spp context it might be true that it is better to remove the sec completely and expect the user to enter a new one.

However, in most usecases we use the same sec more or less all over the place. Also the sec is usually inheritet from the parent. For these (90% of the) usecases it is not nice if suddenly a taxon does not have a sec anymore. It is not so critical for databases where really ALL sec are the same, but e.g. in E+M only subtrees share the same sec. And the sec is important in E+M as it tells who is responsible for this taxon. At the same time I don't think Eckhard would realize that the sec was set to null.

But I agree that taking the sec from the old parent is a bit strange. I would expect to keep it or to take it from the new taxon.

However, as this is really a source of error and different expectations exist in different projects I think we should handle it via preferences and/or via a dialogue.
We already do this for the handling of publish flag:

But for the new sec there are more options:

• Always delete sec (without warning)
• warning, with option to immediately select new sec (buttons for old sec, new parent sec, old parent sec, or reference select dialog)
• Keep without warning if syn sec and new parent sec (and old parent sec(?) are the same, warn otherwise (this handles the default usecase very well)
• Keep always
• Always use new parent sec
• Always use old parent sec (???).

The last one is maybe not necessary.

A "hot fix" version is implemented now. The new accepted taxon keeps the secundum reference of the former synonym and if the new parent has a different sec a message appears.

Now there is only a statement saying "The new taxon and the parent does not have the same secundum reference". But you have to select yes and no, where it is unclear what happens when clicking yes or no.
Better we should have either

• 1 button "OK" and the dialog needs to be a warning not a question. Statement should be prolonged with "Please change secundum manually if necessary".
• 2 statemens with "old synonym", "new parent". WIth statement added: "Please select where to take the secundum reference from."
• 3 buttons, like 2 but with option "no secundum"
• 4 buttons, like 3 but with additional option "old accepted taxon" (but this is not very likely to happen)

Additional possibilities are a "Cancel" button or even a button to immediately select any other reference which opens the reference select dialog.

Please decide what can be implemented without much effort for this release. All the rest will go to the new ticket #9340.

First version was implemented now.

I think we can close this ticket. All the rest will be done in the follow up ticket.