https://dev.e-taxonomy.eu/redmine/https://dev.e-taxonomy.eu/redmine/redmine/favicon.ico?14691914852020-11-02T08:15:03ZEDIT Project ManagementEDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=557752020-11-02T08:15:03ZKatja Luther
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>50</i></li></ul><p>Applied in changeset <a class="changeset" title="fix #9267: add no sec reference to newly created taxon moved from synonym" href="https://dev.e-taxonomy.eu/redmine/projects/edit/repository/cdmlib/revisions/593c7701c265521b6e3701942e0f6c7756304963">cdmlib|593c7701c265521b6e3701942e0f6c7756304963</a>.</p>
EDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=557762020-11-02T08:17:47ZKatja Luther
<ul><li><strong>Assignee</strong> changed from <i>Katja Luther</i> to <i>Andreas Müller</i></li></ul><p>please review</p>
EDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=557872020-11-02T12:40:57ZAndreas Müller
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/redmine/journals/55787/diff?detail_id=69591">diff</a>)</li></ul> EDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=563232020-11-27T14:42:00ZAndreas Müller
<ul><li><strong>File</strong> <a href="/redmine/attachments/1963">picture395-1.png</a> <a class="icon-only icon-download" title="Download" href="/redmine/attachments/download/1963/picture395-1.png">picture395-1.png</a> added</li><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Katja Luther</i></li></ul><p>The above requirement works as expected but I do not fully agree to the requirement. I think we discussed this some time ago already.</p>
<p>In caryo_spp context it might be true that it is better to remove the sec completely and expect the user to enter a new one.</p>
<p>However, in most usecases we use the same sec more or less all over the place. Also the sec is usually inheritet from the parent. For these (90% of the) usecases it is not nice if suddenly a taxon does not have a sec anymore. It is not so critical for databases where really ALL sec are the same, but e.g. in E+M only subtrees share the same sec. And the sec is important in E+M as it tells who is responsible for this taxon. At the same time I don't think Eckhard would realize that the sec was set to null.</p>
<p>But I agree that taking the sec from the old parent is a bit strange. I would expect to keep it or to take it from the new taxon.</p>
<p>However, as this is really a source of error and different expectations exist in different projects I think we should handle it via preferences and/or via a dialogue.<br>
We already do this for the handling of publish flag: </p>
<p><img src="https://dev.e-taxonomy.eu/redmine/attachments/download/1963/picture395-1.png" alt="" /></p>
<p>But for the new sec there are more options:</p>
<ul>
<li>Always delete sec (without warning)</li>
<li>warning, with option to immediately select new sec (buttons for old sec, new parent sec, old parent sec, or reference select dialog)</li>
<li>Keep without warning if syn sec and new parent sec (and old parent sec(?) are the same, warn otherwise (this handles the default usecase very well)</li>
<li>Keep always</li>
<li>Always use new parent sec</li>
<li>Always use old parent sec (???).</li>
</ul>
<p>The last one is maybe not necessary.</p>
EDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=563242020-11-27T14:50:17ZAndreas Müller
<ul></ul><p>By the way, as the above action is a taxon split, in future there will be the need of more user interaction during this action anyway (in terms of concept identifier/relation) questions, factual data handling, etc.).</p>
<p>So, in general, having a user feedback dialogue should be an acceptable solution to indicate that some decision is needed from the user here.<br>
However, I think this is really something we need a preference for. </p>
EDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=565672020-12-03T12:55:56ZKatja Luther
<ul><li><strong>Assignee</strong> changed from <i>Katja Luther</i> to <i>Andreas Müller</i></li></ul><p>A "hot fix" version is implemented now. The new accepted taxon keeps the secundum reference of the former synonym and if the new parent has a different sec a message appears.</p>
EDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=565752020-12-03T14:32:20ZAndreas Müller
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Katja Luther</i></li></ul><p>Now there is only a statement saying "The new taxon and the parent does not have the same secundum reference". But you have to select yes and no, where it is unclear what happens when clicking yes or no.<br>
Better we should have either</p>
<ul>
<li>1 button "OK" and the dialog needs to be a warning not a question. Statement should be prolonged with "Please change secundum manually if necessary".</li>
<li>2 statemens with "old synonym", "new parent". WIth statement added: "Please select where to take the secundum reference from."</li>
<li>3 buttons, like 2 but with option "no secundum"</li>
<li>4 buttons, like 3 but with additional option "old accepted taxon" (but this is not very likely to happen)</li>
</ul>
<p>Additional possibilities are a "Cancel" button or even a button to immediately select any other reference which opens the reference select dialog.</p>
<p>Please decide what can be implemented without much effort for this release. All the rest will go to the new ticket <a class="issue tracker-5 status-5 priority-11 priority-default closed" title="feature request: Workflow support for secundum handling when making synonym a new accepted taxon (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/9340">#9340</a>. </p>
EDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=565762020-12-03T14:36:23ZAndreas Müller
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-5 status-5 priority-11 priority-default closed" href="/redmine/issues/9340">feature request #9340</a>: Workflow support for secundum handling when making synonym a new accepted taxon</i> added</li></ul> EDIT - bug #9267: No sec reference for move change Synonym to accepted Taxonhttps://dev.e-taxonomy.eu/redmine/issues/9267?journal_id=566202020-12-03T17:30:08ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>First version was implemented now.</p>
<p>I think we can close this ticket. All the rest will be done in the follow up ticket.</p>