Project

General

Profile

bug #9267

No sec reference for move change Synonym to accepted Taxon

Added by Katja Luther 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
cdmlib
Target version:
Start date:
11/02/2020
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

mail WGB:

mir ist aufgefallen, dass beim Umwandeln eines Synonyms in einen akzeptierten Namen dem neuen Taxon eine sec.-Ref. zugeordnet wird, die ich höchstens in so weit nachvollziehen kann, als dass ich sie kürzlich benutzt habe. Es ist weder die des höheren Taxons, in das das neue Taxon gestellt wurde, noch die ursprüngliche syn.-sec. Ref. Beides wäre auch nicht gut – ich ziehe vor, hier keine automatische Übertragung vorzunehmen.
...
doch, mir ist jetzt aufgefallen, dass offenbar die sec.-Ref. genommen wird, die beim ursprünglich akzeptierten Namen des Synonyms benutzt wurde!

picture395-1.png View (2.77 KB) Andreas Müller, 11/27/2020 03:42 PM


Related issues

Copied to Edit - feature request #9340: Workflow support for secundum handling when making synonym a new accepted taxon Feedback 12/03/2020

Associated revisions

Revision 593c7701 (diff)
Added by Katja Luther 4 months ago

fix #9267: add no sec reference to newly created taxon moved from synonym

Revision bb2b5493 (diff)
Added by Katja Luther 3 months ago

ref #9267: add message if sec of new taxon differs from sec of new parent

Revision 3385926d (diff)
Added by Katja Luther 3 months ago

ref #9267: set sec of new taxon to sec of synonym

Revision 8bdc7bb8 (diff)
Added by Katja Luther 3 months ago

ref #9267: warning message instead of confirm message box

History

#1 Updated by Katja Luther 4 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Katja Luther 4 months ago

  • Assignee changed from Katja Luther to Andreas Müller

please review

#3 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#4 Updated by Andreas Müller 3 months ago

  • File picture395-1.png View added
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The above requirement works as expected but I do not fully agree to the requirement. I think we discussed this some time ago already.

In caryo_spp context it might be true that it is better to remove the sec completely and expect the user to enter a new one.

However, in most usecases we use the same sec more or less all over the place. Also the sec is usually inheritet from the parent. For these (90% of the) usecases it is not nice if suddenly a taxon does not have a sec anymore. It is not so critical for databases where really ALL sec are the same, but e.g. in E+M only subtrees share the same sec. And the sec is important in E+M as it tells who is responsible for this taxon. At the same time I don't think Eckhard would realize that the sec was set to null.

But I agree that taking the sec from the old parent is a bit strange. I would expect to keep it or to take it from the new taxon.

However, as this is really a source of error and different expectations exist in different projects I think we should handle it via preferences and/or via a dialogue.
We already do this for the handling of publish flag:

But for the new sec there are more options:

  • Always delete sec (without warning)
  • warning, with option to immediately select new sec (buttons for old sec, new parent sec, old parent sec, or reference select dialog)
  • Keep without warning if syn sec and new parent sec (and old parent sec(?) are the same, warn otherwise (this handles the default usecase very well)
  • Keep always
  • Always use new parent sec
  • Always use old parent sec (???).

The last one is maybe not necessary.

#5 Updated by Andreas Müller 3 months ago

By the way, as the above action is a taxon split, in future there will be the need of more user interaction during this action anyway (in terms of concept identifier/relation) questions, factual data handling, etc.).

So, in general, having a user feedback dialogue should be an acceptable solution to indicate that some decision is needed from the user here.
However, I think this is really something we need a preference for.

#6 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

A "hot fix" version is implemented now. The new accepted taxon keeps the secundum reference of the former synonym and if the new parent has a different sec a message appears.

#7 Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Now there is only a statement saying "The new taxon and the parent does not have the same secundum reference". But you have to select yes and no, where it is unclear what happens when clicking yes or no.
Better we should have either

  • 1 button "OK" and the dialog needs to be a warning not a question. Statement should be prolonged with "Please change secundum manually if necessary".
  • 2 statemens with "old synonym", "new parent". WIth statement added: "Please select where to take the secundum reference from."
  • 3 buttons, like 2 but with option "no secundum"
  • 4 buttons, like 3 but with additional option "old accepted taxon" (but this is not very likely to happen)

Additional possibilities are a "Cancel" button or even a button to immediately select any other reference which opens the reference select dialog.

Please decide what can be implemented without much effort for this release. All the rest will go to the new ticket #9340.

#8 Updated by Andreas Müller 3 months ago

  • Copied to feature request #9340: Workflow support for secundum handling when making synonym a new accepted taxon added

#9 Updated by Andreas Müller 3 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100

First version was implemented now.

I think we can close this ticket. All the rest will be done in the follow up ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)