task #9265
Adapt dataportal to new protologue handling
100%
Description
Protologues are now handled as external links of the nomenclatural source (#6589). The dataportals (and maybe webservices?) need to be adapted accordingly.
Related issues
Associated revisions
ref #9265 switching to NomenclaturalSource.links for protologues
ref #9265 switching to NomenclaturalSource.links for protologues - comment
ref #9265 getting citationDetail from NomenclaturalSource
ref #9265 implementing protologueLinks web service
ref #9265 introducing NomenclaturalSourceBeanProcessor to add nomenclaturalCitation to web service responses
ref #9265 making use of nomenclaturalSource->nomenclaturalCitation
ref #9265 making use of nomenclaturalSource->nomenclaturalCitation - extending initStrategy
ref #9265 adapting test to improved nomRef citation string generation
ref #9265 reverting to old nomRef retrival strategy and fixing bugs
ref #9265 removing NomenclaturalSourceBeanProcessor since it causes many hard to controll LazyInitializationExcptions in web services
History
#1 Updated by Andreas Müller 3 months ago
- Related to feature request #6589: Handle protologue as original source with URI link added
#2 Updated by Andreas Müller 3 months ago
- Description updated (diff)
#3 Updated by Andreas Kohlbecker 2 months ago
- Description updated (diff)
#4 Updated by Andreas Kohlbecker 2 months ago
- Status changed from New to In Progress
There is no specific web service for protologues so only the dataportal needs to be adapted.
#5 Updated by Andreas Kohlbecker 2 months ago
- Related to task #9319: adapt name render templates to new nomenclatural source which also contain protologues as external links added
#6 Updated by Andreas Kohlbecker 2 months ago
- Status changed from In Progress to Feedback
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 0 to 20
this is basically implemented, tests are pending.
One question in advance: ExternalLink has the property description, how should this be handled in case of the protologues? I suggest using foot notes in this case. This should be feasible for all other situations in which ExternalLinks occur also.
#7 Updated by Andreas Müller 2 months ago
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Andreas Kohlbecker wrote:
this is basically implemented, tests are pending.
One question in advance: ExternalLink has the property
description, how should this be handled in case of the protologues? I suggest using foot notes in this case. This should be feasible for all other situations in which ExternalLinks occur also.
As discussed in stand up I am not sure what the best solution is. Probably we should ask the users (the description was original WGBs idea) what they expect. It is even possible that it should not be displayed at all and is only meant as internal note). This is a general issue for all ExternalLinks, not only for nomenclatural sources. I think we should open a new ticket for this.
#8 Updated by Andreas Kohlbecker 2 months ago
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 20 to 40
new ticket for discussion on display of ExternalLink.description: #9323
#9 Updated by Andreas Kohlbecker 2 months ago
- Status changed from Feedback to Resolved
- Assignee changed from Andreas Müller to Andreas Kohlbecker
#10 Updated by Andreas Kohlbecker 2 months ago
- Copied to task #9323: discuss display of ExternalLink.description added
#11 Updated by Andreas Kohlbecker 2 months ago
- Related to feature request #4644: json lib incorrectly serializes values containig the characters [, ], {, } added
#12 Updated by Andreas Kohlbecker about 2 months ago
- Status changed from Resolved to Closed
- % Done changed from 40 to 100
cant see that there is still something missing and thus closing this ticket
#13 Updated by Andreas Kohlbecker about 2 months ago
- Status changed from Closed to In Progress
- % Done changed from 100 to 40
now I found the missing bit.
In cdm-dataportal|f9b5740e33ff94ab9e1703774379f5d67d103649 the apparently imcomplete implementation for displaying of ADDITIONAL_PUBLICATION name features has been removed
since it was rarely used (#6589#note-27) and to be improved after solving #9320. The now removed implementation however was an important requirement for the flora of cuba #8851 and must therefore not be removed.
#14 Updated by Andreas Kohlbecker about 2 months ago
- Related to feature request #9320: Move additional publication information to nomenclatural source added
#15 Updated by Andreas Kohlbecker about 2 months ago
- Related to bug #8851: display of name facts not appropriate in all cases added
#16 Updated by Andreas Kohlbecker about 2 months ago
- Status changed from In Progress to Closed
- % Done changed from 40 to 100
now that #8851 is solved the functionality which has been removed while working on this ticket is restored, so we can close it.
