Project

General

Profile

task #9265

Adapt dataportal to new protologue handling

Added by Andreas Müller 12 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
10/29/2020
Due date:
% Done:

100%

Severity:
blocker

Description

Protologues are now handled as external links of the nomenclatural source (#6589). The dataportals (and maybe webservices?) need to be adapted accordingly.


Related issues

Related to Edit - feature request #6589: Handle protologue as original source with URI link Closed 04/24/2017
Related to Edit - task #9319: adapt name render templates to new nomenclatural source which also contain protologues as external links New 11/24/2020
Related to Edit - feature request #4644: json lib incorrectly serializes values containig the characters [, ], {, } New 02/09/2015
Related to Edit - feature request #9320: Move additional publication information to nomenclatural source In Progress 11/25/2020
Related to Edit - bug #8851: display of name facts not appropriate in all cases Closed 02/20/2020
Copied to Edit - task #9323: discuss display of ExternalLink.description New 11/25/2020

Associated revisions

Revision f9b5740e (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 switching to NomenclaturalSource.links for protologues

Revision df2b235a (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 switching to NomenclaturalSource.links for protologues - comment

Revision d5de0b1f (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 getting citationDetail from NomenclaturalSource

Revision c11d7e10 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 implementing test for nom-ref and protologues, also preparing for ref #9319

Revision a8393f17 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 implementing test for nom-ref and protologues, also preparing for ref #9319 - 2

Revision 61e84a73 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 implementing protologueLinks web service

Revision aa06c1f1 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 introducing NomenclaturalSourceBeanProcessor to add nomenclaturalCitation to web service responses

Revision 4fa58f06 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 making use of nomenclaturalSource->nomenclaturalCitation

Revision 562f293f (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 making use of nomenclaturalSource->nomenclaturalCitation - extending initStrategy

Revision beb7ecbe (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 adapting test to improved nomRef citation string generation

Revision 9c96ba36 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 reverting to old nomRef retrival strategy and fixing bugs

Revision f2198885 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #9265 removing NomenclaturalSourceBeanProcessor since it causes many hard to controll LazyInitializationExcptions in web services

Revision e024a603 (diff)
Added by Andreas Kohlbecker 11 months ago

ref #8851, ref #9265 improved re-implementation of name desciptions (annotations and sources still pending)

History

#1 Updated by Andreas Müller 12 months ago

#2 Updated by Andreas Müller 12 months ago

  • Description updated (diff)

#3 Updated by Andreas Kohlbecker 11 months ago

  • Description updated (diff)

#4 Updated by Andreas Kohlbecker 11 months ago

  • Status changed from New to In Progress

There is no specific web service for protologues so only the dataportal needs to be adapted.

#5 Updated by Andreas Kohlbecker 11 months ago

  • Related to task #9319: adapt name render templates to new nomenclatural source which also contain protologues as external links added

#6 Updated by Andreas Kohlbecker 11 months ago

  • Status changed from In Progress to Feedback
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 0 to 20

this is basically implemented, tests are pending.

One question in advance: ExternalLink has the property description, how should this be handled in case of the protologues? I suggest using foot notes in this case. This should be feasible for all other situations in which ExternalLinks occur also.

#7 Updated by Andreas Müller 11 months ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Andreas Kohlbecker wrote:

this is basically implemented, tests are pending.

One question in advance: ExternalLink has the property description, how should this be handled in case of the protologues? I suggest using foot notes in this case. This should be feasible for all other situations in which ExternalLinks occur also.

As discussed in stand up I am not sure what the best solution is. Probably we should ask the users (the description was original WGBs idea) what they expect. It is even possible that it should not be displayed at all and is only meant as internal note). This is a general issue for all ExternalLinks, not only for nomenclatural sources. I think we should open a new ticket for this.

#8 Updated by Andreas Kohlbecker 11 months ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 20 to 40

new ticket for discussion on display of ExternalLink.description: #9323

#9 Updated by Andreas Kohlbecker 11 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

#10 Updated by Andreas Kohlbecker 11 months ago

  • Copied to task #9323: discuss display of ExternalLink.description added

#11 Updated by Andreas Kohlbecker 11 months ago

  • Related to feature request #4644: json lib incorrectly serializes values containig the characters [, ], {, } added

#12 Updated by Andreas Kohlbecker 11 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 40 to 100

cant see that there is still something missing and thus closing this ticket

#13 Updated by Andreas Kohlbecker 11 months ago

  • Status changed from Closed to In Progress
  • % Done changed from 100 to 40

now I found the missing bit.

In cdm-dataportal|f9b5740e33ff94ab9e1703774379f5d67d103649 the apparently imcomplete implementation for displaying of ADDITIONAL_PUBLICATION name features has been removed
since it was rarely used (#6589#note-27) and to be improved after solving #9320. The now removed implementation however was an important requirement for the flora of cuba #8851 and must therefore not be removed.

#14 Updated by Andreas Kohlbecker 11 months ago

  • Related to feature request #9320: Move additional publication information to nomenclatural source added

#15 Updated by Andreas Kohlbecker 11 months ago

  • Related to bug #8851: display of name facts not appropriate in all cases added

#16 Updated by Andreas Kohlbecker 11 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 40 to 100

now that #8851 is solved the functionality which has been removed while working on this ticket is restored, so we can close it.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)