EDIT

Hi Katja & AM, the current implementation partially filters for DerivedUnits of the type SpecimenOrObservationType.PreservedSpecimen.
I think that this was a requirement only for the campanula project and that it should not be active by default.

Do you agree?

Furthermore is the filtering incomplete, since it is only applied to the first level of derivatives of a FieldUnit.

Andreas Kohlbecker wrote:

Hi Katja & AM, the current implementation partially filters for DerivedUnits of the type SpecimenOrObservationType.PreservedSpecimen.
I think that this was a requirement only for the campanula project and that it should not be active by default.

Do you agree?

Furthermore is the filtering incomplete, since it is only applied to the fist level of derivatives of a FieldUnit.

I agree, this problem we had on several points because campanula was only interested in preserved specimen but for example observations were missing.

@AM: what do you think?

Katja Luther wrote:

Andreas Kohlbecker wrote:

Hi Katja & AM, the current implementation partially filters for DerivedUnits of the type SpecimenOrObservationType.PreservedSpecimen.
I think that this was a requirement only for the campanula project and that it should not be active by default.

Do you agree?

Furthermore is the filtering incomplete, since it is only applied to the fist level of derivatives of a FieldUnit.

I agree, this problem we had on several points because campanula was only interested in preserved specimen but for example observations were missing.

@AM: what do you think?

To be honest I was never in touch with this code and therefore it is difficult to answer. But generally to me it also looks like it does not make sense to filter the derivates of FieldUnitDTO hardcoded. Better we should allow to configure this by an additional parameter in assembleFieldUnitDTO(...) which allows filtering if needed for some reason (though it is difficult to think on a usecase for this).

Definetly we should also allow to show data which e.g. has only a field unit and DNA data. We have such data already in Cactaceae (and the filter is probably the reason why the data does not show up correctly sometimes).

But ofcourse we need to be careful to adapt all clients of the method so they know how to handle other derivates. E.g. the specimen table developed for Campanula may have problems doing so but should (see Cactaceae example above). But maybe this is anyway not an issue once the different methods are all unified.

can be closed as open taks are copied to #9389