Project

General

Profile

bug #9257

revise filtering in OccurrenceServiceImpl.assembleFieldUnitDTO(FieldUnit fieldUnit) by SpecimenOrObservationType.PreservedSpecimen

Added by Andreas Kohlbecker 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
10/15/2020
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

see FIXME comment in method


Related issues

Related to Edit - task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) Closed 10/15/2020
Copied to Edit - task #9389: further improvement and revision of derivative filtering by type and DerivedUnitDTO Closed 01/15/2021

Associated revisions

Revision 06b2c5f6 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #9252 ref #9257 exposing SpecimenOrObservationType filter to factory method and better flag handling

Revision aa52b6f0 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #9257 comments including questions on missing filtering in the DrivedUnitDTO construction

History

#1 Updated by Andreas Kohlbecker 8 months ago

  • Related to task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) added

#2 Updated by Andreas Kohlbecker 8 months ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Katja Luther

Hi Katja & AM, the current implementation partially filters for DerivedUnits of the type SpecimenOrObservationType.PreservedSpecimen.
I think that this was a requirement only for the campanula project and that it should not be active by default.

Do you agree?

Furthermore is the filtering incomplete, since it is only applied to the first level of derivatives of a FieldUnit.

#3 Updated by Katja Luther 7 months ago

  • Assignee changed from Katja Luther to Andreas Müller

Andreas Kohlbecker wrote:

Hi Katja & AM, the current implementation partially filters for DerivedUnits of the type SpecimenOrObservationType.PreservedSpecimen.
I think that this was a requirement only for the campanula project and that it should not be active by default.

Do you agree?

Furthermore is the filtering incomplete, since it is only applied to the fist level of derivatives of a FieldUnit.

I agree, this problem we had on several points because campanula was only interested in preserved specimen but for example observations were missing.

@AM: what do you think?

#4 Updated by Andreas Müller 6 months ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Katja Luther wrote:

Andreas Kohlbecker wrote:

Hi Katja & AM, the current implementation partially filters for DerivedUnits of the type SpecimenOrObservationType.PreservedSpecimen.
I think that this was a requirement only for the campanula project and that it should not be active by default.

Do you agree?

Furthermore is the filtering incomplete, since it is only applied to the fist level of derivatives of a FieldUnit.

I agree, this problem we had on several points because campanula was only interested in preserved specimen but for example observations were missing.

@AM: what do you think?

To be honest I was never in touch with this code and therefore it is difficult to answer. But generally to me it also looks like it does not make sense to filter the derivates of FieldUnitDTO hardcoded. Better we should allow to configure this by an additional parameter in assembleFieldUnitDTO(...) which allows filtering if needed for some reason (though it is difficult to think on a usecase for this).

Definetly we should also allow to show data which e.g. has only a field unit and DNA data. We have such data already in Cactaceae (and the filter is probably the reason why the data does not show up correctly sometimes).

But ofcourse we need to be careful to adapt all clients of the method so they know how to handle other derivates. E.g. the specimen table developed for Campanula may have problems doing so but should (see Cactaceae example above). But maybe this is anyway not an issue once the different methods are all unified.

#5 Updated by Andreas Kohlbecker 5 months ago

  • Copied to task #9389: further improvement and revision of derivative filtering by type and DerivedUnitDTO added

#6 Updated by Andreas Kohlbecker 5 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

can be closed as open taks are copied to #9389

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)