Project

General

Profile

task #9253

revise OccurrenceServiceImpl.findFieldUnitDTO(..)

Added by Andreas Kohlbecker about 1 month ago. Updated about 1 month ago.

Status:
In Progress
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
10/15/2020
Due date:
% Done:

40%

Severity:
normal
Tags:

Description

This intended function of FieldUnitDTO OccurrenceServiceImpl.findFieldUnitDTO(DerivateDTO derivedUnitDTO, Collection<FieldUnitDTO> fieldUnits, HashMap<UUID, DerivateDTO> alreadyCollectedSpecimen) is quite unclear, not only because the documentation is missing (#8458), but also since the method is confuses reagarding the method signature: All detected fieldunits are added to the Collection<FieldUnitDTO> fieldUnits passed as parameter but one of the field units is returned. From the description of #8423 supports the impression that this method covers two distinct functionalities at the same.

TODO: refactor the method to make its clarify its purpose and converns.


Related issues

Related to Edit - task #8458: document FieldUnitDTOOccurrenceServiceImpl.findFieldUnitDTO() In Progress 08/12/2019
Related to Edit - bug #8423: OccurrenceServiceImpl.findFieldUnitDTO() fails to merge derivation paths when a FieldUnit has two derivatives Resolved 07/30/2019
Related to Edit - task #9252: Harmonize SpecimenOrOberservationBase related DTOs Closed 10/14/2020
Related to Edit - task #8419: harmonization of the different specimen representations New 07/25/2019
Related to Edit - bug #9257: revise filtering in OccurrenceServiceImpl.assembleFieldUnitDTO(FieldUnit fieldUnit) by SpecimenOrObservationType.PreservedSpecimen Feedback 10/15/2020

Associated revisions

Revision ddef3633 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9253 todo comment

Revision b1a675d1 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #8423 ref #9253, ref #9252 fixing duplicate addition of DerivedUnitDTOs

Revision 5d299395 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9253 cleaning up caller of OccurrenceServiceImpl.findFieldUnitDTO(..)

Revision ba48bce0 (diff)
Added by Andreas Kohlbecker 15 days ago

ref #9253 removing initstrategy from DTO service method

Revision 398413cc (diff)
Added by Andreas Kohlbecker 15 days ago

ref #9253 removing initstrategy from DTO service method - cleaning up

History

#1 Updated by Andreas Kohlbecker about 1 month ago

  • Description updated (diff)

#2 Updated by Andreas Kohlbecker about 1 month ago

  • Related to task #8458: document FieldUnitDTOOccurrenceServiceImpl.findFieldUnitDTO() added

#3 Updated by Andreas Kohlbecker about 1 month ago

  • Related to bug #8423: OccurrenceServiceImpl.findFieldUnitDTO() fails to merge derivation paths when a FieldUnit has two derivatives added

#4 Updated by Andreas Kohlbecker about 1 month ago

  • Related to task #9252: Harmonize SpecimenOrOberservationBase related DTOs added

#5 Updated by Andreas Kohlbecker about 1 month ago

  • Related to task #8419: harmonization of the different specimen representations added

#6 Updated by Andreas Kohlbecker about 1 month ago

  • Related to bug #9257: revise filtering in OccurrenceServiceImpl.assembleFieldUnitDTO(FieldUnit fieldUnit) by SpecimenOrObservationType.PreservedSpecimen added

#7 Updated by Andreas Kohlbecker about 1 month ago

  • % Done changed from 0 to 40

#8 Updated by Andreas Kohlbecker about 1 month ago

  • Status changed from New to In Progress

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)