Project

General

Profile

Actions

task #9252

closed

Harmonize SpecimenOrOberservationBase related DTOs

Added by Andreas Kohlbecker over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

Problems with the current implementations:

  • Naming:
    • PreservedSpecimenDTO should be named DerivedUnitDTO
    • DerivateDTO should be named SpecimenOrOberservationDTO
  • Terms:
    • term representations need to be localized
    • fields containing localized term representations are to be named {fieldname}_L10n
  • Factory methods
    • clear naming etc....
    • construction of DTO should be done in factory methods instead of having this code in service methods and utilizing setters to populate the DTO with field values , see
      • OccurrenceServiceImpl.assembleFieldUnitDTO(FieldUnit fieldUnit)
      • OccurrenceServiceImpl.findFieldUnitDTO(SpecimenOrObservationBaseDTO, Collection<FieldUnitDTO>, HashMap<UUID, SpecimenOrObservationBaseDTO>)
      • OccurrenceServiceImpl.loadFieldUnitDTO(UUID)
  • DTO classes should extend TypeEntityReference instead of UuidAndTitleCache

Solving this ticket is a prerequisite for straight forward harmonization of the different specimen representations #8419

Additional:

  • add missing fields (example values for Glenodinium apiculatum as in integration reference db)
    • Stored under: Glenodinium apiculatum Ehrenb. - DONE
    • Original label info: Glenodimium spec. determination pending. - DONE
    • Determinations: Glenodinium apiculatum Ehrenb., 2016-12-01, Kohlbecker, A., - DONE
    • Exsiccatum: D. Veloper - DONE

Last TODOS:

SpecimenOrObservationBaseDTO

  • use IEnumTerm for recordBase - DONE
  • rename property derivates to derivatives - DONE
  • use DTO for Set<IdentifiableSource> sources ==> copied to #9293
  • remove the deprecated getListLabel() property - DONE

Related issues

Related to EDIT - task #8419: Harmonization of the different specimen representationsIn ProgressAndreas Kohlbecker

Actions
Related to EDIT - task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) ClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #9258: Use Partial for date in FieldUnitDTOClosedAndreas Kohlbecker

Actions
Related to EDIT - task #9259: reduce fields in TermBase json serializations ClosedAndreas Kohlbecker

Actions
Related to EDIT - task #9293: Use use DTO for Set<IdentifiableSource> sources in SpecimenOrObservationBaseDTONewAndreas Kohlbecker

Actions
Related to EDIT - bug #9238: pure entities in DerivateDTO.derivates may cause LIEs ClosedAndreas Kohlbecker

Actions
Copied to EDIT - task #9276: improve DerivateDataDTONewAndreas Kohlbecker

Actions
Actions

Also available in: Atom PDF