Project

General

Profile

task #9252

Harmonize SpecimenOrOberservationBase related DTOs

Added by Andreas Kohlbecker about 2 months ago. Updated 17 days ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
10/14/2020
Due date:
% Done:

100%

Severity:
normal

Description

Problems with the current implementations:

  • Naming:
    • PreservedSpecimenDTO should be named DerivedUnitDTO
    • DerivateDTO should be named SpecimenOrOberservationDTO
  • Terms:
    • term representations need to be localized
    • fields containing localized term representations are to be named {fieldname}_L10n
  • Factory methods
    • clear naming etc....
    • construction of DTO should be done in factory methods instead of having this code in service methods and utilizing setters to populate the DTO with field values , see
      • OccurrenceServiceImpl.assembleFieldUnitDTO(FieldUnit fieldUnit)
      • OccurrenceServiceImpl.findFieldUnitDTO(SpecimenOrObservationBaseDTO, Collection<FieldUnitDTO>, HashMap<UUID, SpecimenOrObservationBaseDTO>)
      • OccurrenceServiceImpl.loadFieldUnitDTO(UUID)
  • DTO classes should extend TypeEntityReference instead of UuidAndTitleCache

Solving this ticket is a prerequisite for straight forward harmonization of the different specimen representations #8419

Additional:

  • add missing fields (example values for Glenodinium apiculatum as in integration reference db)
    • Stored under: Glenodinium apiculatum Ehrenb. - DONE
    • Original label info: Glenodimium spec. determination pending. - DONE
    • Determinations: Glenodinium apiculatum Ehrenb., 2016-12-01, Kohlbecker, A., - DONE
    • Exsiccatum: D. Veloper - DONE

Last TODOS:

SpecimenOrObservationBaseDTO

  • use IEnumTerm for recordBase - DONE
  • rename property derivates to derivatives - DONE
  • use DTO for Set<IdentifiableSource> sources ==> copied to #9293
  • remove the deprecated getListLabel() property - DONE

Related issues

Related to Edit - task #8419: harmonization of the different specimen representations New 07/25/2019
Related to Edit - task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) In Progress 10/15/2020
Related to Edit - feature request #9258: Use Partial for date in FieldUnitDTO Closed 10/16/2020
Related to Edit - task #9259: reduce fields in TermBase json serializations Closed 10/19/2020
Related to Edit - task #9293: Use use DTO for Set<IdentifiableSource> sources in SpecimenOrObservationBaseDTO New 11/12/2020
Related to Edit - bug #9238: pure entities in DerivateDTO.derivates may cause LIEs Closed 10/02/2020
Copied to Edit - task #9276: improve DerivateDataDTO New 11/04/2020

Associated revisions

Revision f99e8546 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 harmonizing SpecimenOrOberservationBase related DTOs

Revision 005402b8 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 harmonizing SpecimenOrOberservationBase related DTOs

Revision 0979f889 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 harmonizing SpecimenOrOberservationBase related DTOs - renaming classes

Revision ca486eb2 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 harmonizing SpecimenOrOberservationBase related DTOs - adapting portal to renamed classes

Revision a72a8bbf (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 adapting texedior to renamed DTO classes

Revision 8dcc00a3 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 adapting service method no new DTO name

Revision 06b2c5f6 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 ref #9257 exposing SpecimenOrObservationType filter to factory method and better flag handling

Revision a9527b12 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 determinig hasTypes from actual data and fixing type probelms in methods

Revision 5830e16a (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 adapting specimen tree view to more data coming witgh FieldUnitDTO

Revision 7d539adb (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #9252 supressing FieldUnitDTO fields in specimen tree view

Revision 970272ed (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 basing SpecimenOrObservationBaseDTO on TypedEntityReference

Revision b1a675d1 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #8423 ref #9253, ref #9252 fixing duplicate addition of DerivedUnitDTOs

Revision 69b6c2b3 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #8419 ref #9252 introducing specimenIdentifier field in DTO and experimental accessionNumber cleanup

Revision eacf1ee2 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252, ref #8423 adapting specimen tree view to fixed derivate path mergring and other changes

Revision c15eb727 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 localizing kind of unit in SpecimenOrObservationBaseDTO

Revision 2e893626 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 localizing kind of unit in SpecimenOrObservationBaseDTO - adapting portal

Revision 7e0e6396 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 using DefinedTermBase for term fields in DTOs and TypedEdityRefernce for indentifications

Revision d1088a53 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 adapting portal to latest DTO changes

Revision ce9ce745 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 adapting test

Revision de30431b (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 maving fieldUnitDTO creation into transactional context

Revision afcf5f85 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 maving fieldUnitDTO creation into transactional context - fixing careless mistake

Revision e1779d28 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 adding id as propery to recover lost UuidAndTitleCache property for the taxeditor

Revision 0eb187f5 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 adapting Taxeditor to moodified DTOs

Revision 7502200f (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 adapting Taxeditor to modified DTOs - 2

Revision d9b0c185 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 using TypedEntityReference for DerivedUnitDTO.associatedTaxa

Revision 33d3036f (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 adding mostSignificantIdentifier to DerivedUnitDTO

Revision 604416f3 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 adapting Taxeditor to modified DTOs - 3

Revision 9c9b6874 (diff)
Added by Andreas Kohlbecker about 1 month ago

ref #9252 adding MediaSpecimen.media to DerivedUnitDTO.listOfMedia

Revision 54b7f04e (diff)
Added by Andreas Kohlbecker 25 days ago

ref #9252 documenting further needed refactoring

Revision 25dfcf2f (diff)
Added by Andreas Kohlbecker 25 days ago

ref #9252 using IEnumTerm for recordBase

Revision 8a605860 (diff)
Added by Andreas Kohlbecker 25 days ago

ref #9252 using IEnumTerm for recordBase - adapting dataportal

Revision 03b91810 (diff)
Added by Andreas Kohlbecker 25 days ago

ref #9252 removing deprecated property listLabel

Revision f51e4e4e (diff)
Added by Andreas Kohlbecker 25 days ago

ref #9252 removing deprecated property listLabel - adapting dataportal

Revision 0ff8cbcf (diff)
Added by Andreas Kohlbecker 25 days ago

ref #9252 renaming property derivates to derivatives - adapting dataportal

Revision 002cdd32 (diff)
Added by Andreas Kohlbecker 25 days ago

ref #9252 renaming property derivates to derivatives

Revision d5d943cb (diff)
Added by Andreas Kohlbecker 23 days ago

ref #9252 adapting portal to latest DTO changes

Revision 9ad46d6b (diff)
Added by Andreas Kohlbecker 23 days ago

ref #9252 piping baseofRecord through KeyTermValueProcessor

History

#1 Updated by Andreas Kohlbecker about 2 months ago

  • Related to task #8419: harmonization of the different specimen representations added

#2 Updated by Andreas Kohlbecker about 2 months ago

  • Description updated (diff)

#3 Updated by Andreas Kohlbecker about 2 months ago

  • Description updated (diff)

#4 Updated by Andreas Kohlbecker about 2 months ago

  • Description updated (diff)

#5 Updated by Andreas Kohlbecker about 2 months ago

  • Related to task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) added

#6 Updated by Andreas Kohlbecker about 2 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 40

#7 Updated by Andreas Kohlbecker about 2 months ago

now only the term related tasks are left to do

#8 Updated by Andreas Kohlbecker about 1 month ago

#9 Updated by Andreas Kohlbecker about 1 month ago

  • Description updated (diff)

#10 Updated by Andreas Kohlbecker about 1 month ago

  • Description updated (diff)

#11 Updated by Andreas Kohlbecker about 1 month ago

  • Status changed from In Progress to Resolved
  • % Done changed from 40 to 50

should be solved now, needs review

#12 Updated by Andreas Kohlbecker about 1 month ago

  • Related to task #9259: reduce fields in TermBase json serializations added

#13 Updated by Andreas Kohlbecker 25 days ago

  • Description updated (diff)

#14 Updated by Andreas Kohlbecker 25 days ago

  • Copied to task #9276: improve DerivateDataDTO added

#15 Updated by Andreas Kohlbecker 25 days ago

  • Description updated (diff)

tasks regarding DerivateDataDTO copied to other ticket

#16 Updated by Andreas Kohlbecker 25 days ago

  • Description updated (diff)

#17 Updated by Andreas Kohlbecker 25 days ago

  • Description updated (diff)

#18 Updated by Andreas Kohlbecker 17 days ago

  • Related to task #9293: Use use DTO for Set<IdentifiableSource> sources in SpecimenOrObservationBaseDTO added

#19 Updated by Andreas Kohlbecker 17 days ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

this ticket is either completed or open tasks are copied to new tickets, so it can be closed

#20 Updated by Andreas Kohlbecker 17 days ago

  • Related to bug #9238: pure entities in DerivateDTO.derivates may cause LIEs added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)