Project

General

Profile

Actions

task #9252

closed

Harmonize SpecimenOrOberservationBase related DTOs

Added by Andreas Kohlbecker about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

Problems with the current implementations:

  • Naming:
    • PreservedSpecimenDTO should be named DerivedUnitDTO
    • DerivateDTO should be named SpecimenOrOberservationDTO
  • Terms:
    • term representations need to be localized
    • fields containing localized term representations are to be named {fieldname}_L10n
  • Factory methods
    • clear naming etc....
    • construction of DTO should be done in factory methods instead of having this code in service methods and utilizing setters to populate the DTO with field values , see
      • OccurrenceServiceImpl.assembleFieldUnitDTO(FieldUnit fieldUnit)
      • OccurrenceServiceImpl.findFieldUnitDTO(SpecimenOrObservationBaseDTO, Collection<FieldUnitDTO>, HashMap<UUID, SpecimenOrObservationBaseDTO>)
      • OccurrenceServiceImpl.loadFieldUnitDTO(UUID)
  • DTO classes should extend TypeEntityReference instead of UuidAndTitleCache

Solving this ticket is a prerequisite for straight forward harmonization of the different specimen representations #8419

Additional:

  • add missing fields (example values for Glenodinium apiculatum as in integration reference db)
    • Stored under: Glenodinium apiculatum Ehrenb. - DONE
    • Original label info: Glenodimium spec. determination pending. - DONE
    • Determinations: Glenodinium apiculatum Ehrenb., 2016-12-01, Kohlbecker, A., - DONE
    • Exsiccatum: D. Veloper - DONE

Last TODOS:

SpecimenOrObservationBaseDTO

  • use IEnumTerm for recordBase - DONE
  • rename property derivates to derivatives - DONE
  • use DTO for Set<IdentifiableSource> sources ==> copied to #9293
  • remove the deprecated getListLabel() property - DONE

Related issues

Related to EDIT - task #8419: Harmonization of the different specimen representationsIn ProgressAndreas Kohlbecker

Actions
Related to EDIT - task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) ClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #9258: Use Partial for date in FieldUnitDTOClosedAndreas Kohlbecker

Actions
Related to EDIT - task #9259: reduce fields in TermBase json serializations ClosedAndreas Kohlbecker

Actions
Related to EDIT - task #9293: Use use DTO for Set<IdentifiableSource> sources in SpecimenOrObservationBaseDTONewAndreas Kohlbecker

Actions
Related to EDIT - bug #9238: pure entities in DerivateDTO.derivates may cause LIEs ClosedAndreas Kohlbecker

Actions
Copied to EDIT - task #9276: improve DerivateDataDTONewAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Kohlbecker about 2 years ago

  • Related to task #8419: Harmonization of the different specimen representations added
Actions #2

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #3

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #4

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #5

Updated by Andreas Kohlbecker about 2 years ago

  • Related to task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) added
Actions #6

Updated by Andreas Kohlbecker about 2 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 40
Actions #7

Updated by Andreas Kohlbecker about 2 years ago

now only the term related tasks are left to do

Actions #8

Updated by Andreas Kohlbecker about 2 years ago

Actions #9

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #10

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #11

Updated by Andreas Kohlbecker about 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 40 to 50

should be solved now, needs review

Actions #12

Updated by Andreas Kohlbecker about 2 years ago

  • Related to task #9259: reduce fields in TermBase json serializations added
Actions #13

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #14

Updated by Andreas Kohlbecker about 2 years ago

  • Copied to task #9276: improve DerivateDataDTO added
Actions #15

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)

tasks regarding DerivateDataDTO copied to other ticket

Actions #16

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #17

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
Actions #18

Updated by Andreas Kohlbecker about 2 years ago

  • Related to task #9293: Use use DTO for Set<IdentifiableSource> sources in SpecimenOrObservationBaseDTO added
Actions #19

Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

this ticket is either completed or open tasks are copied to new tickets, so it can be closed

Actions #20

Updated by Andreas Kohlbecker about 2 years ago

  • Related to bug #9238: pure entities in DerivateDTO.derivates may cause LIEs added
Actions

Also available in: Atom PDF