Actions
task #9252
closedHarmonize SpecimenOrOberservationBase related DTOs
Start date:
Due date:
% Done:
100%
Estimated time:
Severity:
normal
Description
Problems with the current implementations:
- Naming:
- PreservedSpecimenDTO should be named DerivedUnitDTO
- DerivateDTO should be named SpecimenOrOberservationDTO
- Terms:
- term representations need to be localized
- fields containing localized term representations are to be named
{fieldname}_L10n
- Factory methods
- clear naming etc....
- construction of DTO should be done in factory methods instead of having this code in service methods and utilizing setters to populate the DTO with field values , see
OccurrenceServiceImpl.assembleFieldUnitDTO(FieldUnit fieldUnit)
OccurrenceServiceImpl.findFieldUnitDTO(SpecimenOrObservationBaseDTO, Collection<FieldUnitDTO>, HashMap<UUID, SpecimenOrObservationBaseDTO>)
OccurrenceServiceImpl.loadFieldUnitDTO(UUID)
- DTO classes should extend TypeEntityReference instead of UuidAndTitleCache
Solving this ticket is a prerequisite for straight forward harmonization of the different specimen representations #8419
Additional:
- add missing fields (example values for Glenodinium apiculatum as in integration reference db)
- Stored under: Glenodinium apiculatum Ehrenb. - DONE
- Original label info: Glenodimium spec. determination pending. - DONE
- Determinations: Glenodinium apiculatum Ehrenb., 2016-12-01, Kohlbecker, A., - DONE
- Exsiccatum: D. Veloper - DONE
Last TODOS:
SpecimenOrObservationBaseDTO
- use IEnumTerm for recordBase - DONE
- rename property derivates to derivatives - DONE
- use DTO for
Set<IdentifiableSource> sources
==> copied to #9293 - remove the deprecated
getListLabel()
property - DONE
Related issues
Updated by Andreas Kohlbecker over 3 years ago
- Related to task #8419: Harmonization of the different specimen representations added
Updated by Andreas Kohlbecker over 3 years ago
- Related to task #9253: revise OccurrenceServiceImpl.findFieldUnitDTO(..) added
Updated by Andreas Kohlbecker over 3 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 40
Updated by Andreas Kohlbecker over 3 years ago
now only the term related tasks are left to do
Updated by Andreas Kohlbecker over 3 years ago
- Related to feature request #9258: Use Partial for date in FieldUnitDTO added
Updated by Andreas Kohlbecker over 3 years ago
- Status changed from In Progress to Resolved
- % Done changed from 40 to 50
should be solved now, needs review
Updated by Andreas Kohlbecker over 3 years ago
- Related to task #9259: reduce fields in TermBase json serializations added
Updated by Andreas Kohlbecker over 3 years ago
- Copied to task #9276: improve DerivateDataDTO added
Updated by Andreas Kohlbecker over 3 years ago
- Description updated (diff)
tasks regarding DerivateDataDTO copied to other ticket
Updated by Andreas Kohlbecker over 3 years ago
- Related to task #9293: Use use DTO for Set<IdentifiableSource> sources in SpecimenOrObservationBaseDTO added
Updated by Andreas Kohlbecker over 3 years ago
- Description updated (diff)
- Status changed from Resolved to Closed
- % Done changed from 50 to 100
this ticket is either completed or open tasks are copied to new tickets, so it can be closed
Updated by Andreas Kohlbecker over 3 years ago
- Related to bug #9238: pure entities in DerivateDTO.derivates may cause LIEs added
Actions