feature request #922: Implement compareTo method in IdentifiableEntity properly - EDIT - EDIT Project Management

Custom queries

5.33
cdm-dataportal (open)
last 7 days tickets
mine in current release
phycobank
phycobank-index-closed
phycobank-registration-closed
potentially missed issues
recently updated
Release3.7
Release3.8
Release4.0
Release4.1
Release4.10
Release4.11
Release4.12
Release4.13
Release4.14
Release4.16
Release4.2
Release4.3
Release4.4
Release4.5
Release4.6
Release4.7
Release4.8
Release4.9
Release4.9
Release5.0
Release5.1
Release5.10
Release5.11
Release5.12
Release5.13
Release5.14
Release5.15
Release5.16
Release5.17
Release5.18
Release5.19
Release5.2
Release5.20
Release5.21
Release5.22
Release5.23
Release5.24
Release5.25
Release5.26
Release5.27
Release5.28
Release5.29
Release5.3
Release5.30
Release5.31
Release5.32
Release5.33
Release5.34
Release5.35
Release5.36
Release5.37
Release5.38
Release5.39
Release5.4
Release5.40
Release5.41
Release5.5
Release5.6
Release5.7
Release5.8
Release5.9
Remoting-Versions
Taxeditor-UX (Platform Etablierung)

Actions

Copy link

feature request #922

closed

Implement compareTo method in IdentifiableEntity properly

Added by Andreas Müller over 14 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Priority12

Assignee:

Andreas Müller

Category:

cdmlib

Target version:

Release 4.6

Start date:

Due date:

% Done:

100%

Estimated time:

Severity:

major

Description

At the moment there is just one method that uses case differentiation instead of using the inheritance.

Either overwrite compoareTo or use abstract methods to get relevant information from subclasses

Related issues

Related to EDIT - bug #6311: Refactor IdentifiableEntity.compareTo method

Rejected

Andreas Müller

Actions

Related to EDIT - task #6401: Update working environment to jdk 1.8

Closed

Patrick Plitzner

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Andreas Müller over 14 years ago

Implementing compareTo in identifiable entity by implementing Comparable creates problems in OrderedTermBase (OrderedTermBase is identifiable now, too). Therefore we should rethink this implementation. Do we really need to compare ident.entities of different classes?

Actions

Copy link

Updated by Katja Luther over 14 years ago

Assignee changed from Anahit Babadshanjan to k.luther -
Target version changed from CDM lib Release 2.0 to CDM lib Release 2.3

Actions

Copy link

Updated by Andreas Müller about 7 years ago

Related to bug #6311: Refactor IdentifiableEntity.compareTo method added

Actions

Copy link

Updated by Andreas Müller about 7 years ago

Description updated (diff)
Status changed from New to Resolved
Target version changed from cdmlib - Old Next Major Release to Release 4.6
% Done changed from 0 to 80

Revision showed that

the method was never used by different classes and therefore the parameter does not need to be IdentifiableEntity
the method was only used by TaxonNameBase and TaxonBase but created problems with the very similar compareTo method in DefinedTermBase

Therefore we moved the method down to TaxonNameBase and TaxonBase and implemented it properly for each of these classes. Also it was renamed to avoid mistakes thinking it implements Comparable (#4232, #6311).

The semantics was only slightly changed were NPEs were expected otherwise.

Actions

Copy link

Updated by Andreas Müller about 7 years ago

Related to task #6401: Update working environment to jdk 1.8 added

Actions

Copy link

Updated by Katja Luther about 7 years ago

Status changed from Resolved to Feedback
Assignee changed from Katja Luther to Andreas Müller

Looks fine, the only thing that should be moved, are the tests for the new methods. At the moment the methods are still tested in IdentifiableEntityTest class.

Actions

Copy link