Project

General

Profile

Actions

task #9206

closed

Solve cglib vs. cglib-nodep

Added by Andreas Müller over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

Cglib and cglib-nodep are very similar libraries as they both include the cglib part but cglib-nodep also includes classes from asm. This has been done to be version independent from asm but has the drawback that it is not extendable (https://github.com/cglib/cglib/wiki ) .
We expect that cglib-nodep is sufficient for cdmlib and will test this.
All dependecies to cglib should be excluded therefore.

This is also to avoid multiple locations warnings from maven.

Also hibernate-cglib-repack probably can be removed. It is anyway only linked by cdmlib-remote. And it is not clear why.

For information on how cglib-nodep is build see: https://github.com/cglib/cglib/blob/master/cglib-nodep/pom.xml


Related issues

Related to EDIT - feature request #9204: Update cdmlib and taxeditor dependenciesClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 2 years ago

Actions #2

Updated by Andreas Müller over 2 years ago

  • Description updated (diff)
Actions #3

Updated by Andreas Müller over 2 years ago

  • Description updated (diff)
Actions #4

Updated by Andreas Müller over 2 years ago

  • Status changed from New to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • % Done changed from 0 to 50

This should be fixed. Andreas K., can you please review and especially check if the removal of hibernate-cglib-repack is ok? I can't see why it should be still needed.

Actions #5

Updated by Andreas Kohlbecker almost 2 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

the dependency to hibernate-cglib-repack was introduced by ben on Wed Feb 25 2009.
I don't see any further need for this, since it only mediates a transient dependency to cglib:cglib-nodep which is included anyway more explicitely and cdmlib builds and works properly without it.
Therefore I am closing this issue as solved.

Actions #6

Updated by Andreas Kohlbecker almost 2 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller
Actions

Also available in: Atom PDF