EDIT

Is this for review?

yes, please check whether everything still works.

The finish button does not seem to work anymore (when using clone).

Andreas Müller wrote:

The "New" button is missing.

Shouldn't the new button should be removed in #9119?

Entering a name (or other information) now is very fast. It was slow before because I think there was always done some duplication check after each key stroke. It is good that it is faster now but I am afraid some functionality got lost.

Katja Luther wrote:

Andreas Müller wrote:

The "New" button is missing.

Shouldn't the new button should be removed in #9119?

#9119 is about schema create and update, not about create new datasource.
Also it was closed in 5.17 but in 5.17 the New button still existed.

Andreas Müller wrote:

Entering a name (or other information) now is very fast. It was slow before because I think there was always done some duplication check after each key stroke. It is good that it is faster now but I am afraid some functionality got lost.

if a database with same name already exist, you get a message and it is not possible to finish

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

The "New" button is missing.

Shouldn't the new button should be removed in #9119?

#9119 is about schema create and update, not about create new datasource.
Also it was closed in 5.17 but in 5.17 the New button still existed.

sorry, I added the menu item again.

Andreas Müller wrote:

The finish button does not seem to work anymore (when using clone).

This is caused by java.lang.NoClassDefFoundError: com/mchange/v2/ser/Indirector, this is only the case for mysql databases, for h2 it works as expected.

Katja Luther wrote:

Andreas Müller wrote:

The finish button does not seem to work anymore (when using clone).

This is caused by java.lang.NoClassDefFoundError: com/mchange/v2/ser/Indirector, this is only the case for mysql databases, for h2 it works as expected.

Looks like mchange-commons-java is missing (https://stackoverflow.com/questions/28977313/caused-byjava-lang-noclassdefrounderrorcom-mchange-v2-ser-indirector). I will try to fix this in dependencies.

Katja Luther wrote:

Andreas Müller wrote:

The finish button does not seem to work anymore (when using clone).

This is caused by java.lang.NoClassDefFoundError: com/mchange/v2/ser/Indirector, this is only the case for mysql databases, for h2 it works as expected.

The dependency mchange-commons-java which includes com/mchange/v2/ser/Indirector definetely exists for taxeditor.local. Can you please check the stacktrace which class loader tries to use it. So can you provide the full stack trace.

Also the question is why the exception is swallowed. Shouldn't it be thrown?

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

The finish button does not seem to work anymore (when using clone).

This is caused by java.lang.NoClassDefFoundError: com/mchange/v2/ser/Indirector, this is only the case for mysql databases, for h2 it works as expected.

The dependency mchange-commons-java which includes com/mchange/v2/ser/Indirector definetely exists for taxeditor.local. Can you please check the stacktrace which class loader tries to use it. So can you provide the full stack trace.

Also the question is why the exception is swallowed. Shouldn't it be thrown?

The exception is catched in rcp code (Window.class), there is no stacktrace but the detail message is: "com.mchange.v2.ser.Indirector cannot be found by eu.etaxonomy.taxeditor.cdmlib_5.18.0.qualifier"

and the classLoader is EquinoxClassLoader

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:
and the classLoader is EquinoxClassLoader

Equinox is probably the Classloader for all. What I meant is, to wich module does it belong, taxeditor.local, taxeditor.cdmlib or even another (do I understand correctly that each model has its own classloader?

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

The "New" button is missing.
...
sorry, I added the menu item again.

Can you move it to the top. That is where it was before.

done