Project

General

Profile

Actions

task #9189

closed

Move datasource view to taxeditor.local

Added by Andreas Müller over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

As the datasource view is only needed for local mgd. it can be moved to taxeditor.webapp

This way maybe the datasource dependencies can be used from taxeditor.webapp too and can be removed in taxeditor.cdmlib.

Also when handling taxeditor.webapp as loadable plugin these dependencies are not needed at all anymore.

This also includes the dialogues opened within the datasource view.

Problems need to be solved:

after moving all datasource/managed server related classes results in problems concerning the login dialog because it uses these classes.

Therefore we need another login dialog containing the managed server in webapp which is used when the webapp plugin is loaded.


Files

picture929-1.png (3.75 KB) picture929-1.png Andreas Müller, 12/01/2020 11:12 AM

Related issues

Related to EDIT - feature request #5752: Reduce TaxEditor sizeClosedAndreas Müller

Actions
Related to EDIT - feature request #9154: Further reduce TaxEditor size by cleaning up dependencies and making taxeditor.webapp plugin optionalNewKatja Luther

Actions
Related to EDIT - task #9119: Remove schema create and schema update functionality from datsource viewClosedKatja Luther

Actions
Related to EDIT - feature request #9190: Make taxeditor.local a loadable plugin not installed by defaultIn ProgressKatja Luther

Actions
Related to EDIT - feature request #9204: Update cdmlib and taxeditor dependenciesClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 2 years ago

Actions #2

Updated by Andreas Müller over 2 years ago

  • Related to feature request #9154: Further reduce TaxEditor size by cleaning up dependencies and making taxeditor.webapp plugin optional added
Actions #3

Updated by Andreas Müller over 2 years ago

  • Related to task #9119: Remove schema create and schema update functionality from datsource view added
Actions #4

Updated by Katja Luther over 2 years ago

  • Target version changed from Release 5.18 to Release 5.19
Actions #5

Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.19 to Release 5.18
Actions #6

Updated by Andreas Müller over 2 years ago

  • Related to feature request #9190: Make taxeditor.local a loadable plugin not installed by default added
Actions #7

Updated by Andreas Müller over 2 years ago

Actions #8

Updated by Andreas Müller over 2 years ago

  • Priority changed from New to Highest
Actions #9

Updated by Katja Luther over 2 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
Actions #10

Updated by Katja Luther about 2 years ago

  • Status changed from In Progress to Resolved
Actions #11

Updated by Andreas Müller about 2 years ago

Is this for review?

Actions #12

Updated by Katja Luther about 2 years ago

yes, please check whether everything still works.

Actions #13

Updated by Katja Luther about 2 years ago

  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 0 to 60
Actions #14

Updated by Andreas Müller about 2 years ago

Title translations are missing:

Actions #15

Updated by Andreas Müller about 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The "New" button is missing.

Actions #16

Updated by Andreas Müller about 2 years ago

The finish button does not seem to work anymore (when using clone).

Actions #17

Updated by Katja Luther about 2 years ago

Andreas Müller wrote:

The "New" button is missing.

Shouldn't the new button should be removed in #9119?

Actions #18

Updated by Andreas Müller about 2 years ago

Entering a name (or other information) now is very fast. It was slow before because I think there was always done some duplication check after each key stroke. It is good that it is faster now but I am afraid some functionality got lost.

Actions #19

Updated by Andreas Müller about 2 years ago

Katja Luther wrote:

Andreas Müller wrote:

The "New" button is missing.

Shouldn't the new button should be removed in #9119?

#9119 is about schema create and update, not about create new datasource.
Also it was closed in 5.17 but in 5.17 the New button still existed.

Actions #20

Updated by Katja Luther about 2 years ago

Andreas Müller wrote:

Entering a name (or other information) now is very fast. It was slow before because I think there was always done some duplication check after each key stroke. It is good that it is faster now but I am afraid some functionality got lost.

if a database with same name already exist, you get a message and it is not possible to finish

Actions #21

Updated by Katja Luther about 2 years ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

The "New" button is missing.

Shouldn't the new button should be removed in #9119?

#9119 is about schema create and update, not about create new datasource.
Also it was closed in 5.17 but in 5.17 the New button still existed.

sorry, I added the menu item again.

Actions #22

Updated by Katja Luther about 2 years ago

Andreas Müller wrote:

The finish button does not seem to work anymore (when using clone).

This is caused by java.lang.NoClassDefFoundError: com/mchange/v2/ser/Indirector, this is only the case for mysql databases, for h2 it works as expected.

Actions #23

Updated by Andreas Müller about 2 years ago

Katja Luther wrote:

Andreas Müller wrote:

The finish button does not seem to work anymore (when using clone).

This is caused by java.lang.NoClassDefFoundError: com/mchange/v2/ser/Indirector, this is only the case for mysql databases, for h2 it works as expected.

Looks like mchange-commons-java is missing (https://stackoverflow.com/questions/28977313/caused-byjava-lang-noclassdefrounderrorcom-mchange-v2-ser-indirector). I will try to fix this in dependencies.

Actions #24

Updated by Andreas Müller about 2 years ago

Katja Luther wrote:

Andreas Müller wrote:

The finish button does not seem to work anymore (when using clone).

This is caused by java.lang.NoClassDefFoundError: com/mchange/v2/ser/Indirector, this is only the case for mysql databases, for h2 it works as expected.

The dependency mchange-commons-java which includes com/mchange/v2/ser/Indirector definetely exists for taxeditor.local. Can you please check the stacktrace which class loader tries to use it. So can you provide the full stack trace.

Also the question is why the exception is swallowed. Shouldn't it be thrown?

Actions #25

Updated by Katja Luther about 2 years ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

The finish button does not seem to work anymore (when using clone).

This is caused by java.lang.NoClassDefFoundError: com/mchange/v2/ser/Indirector, this is only the case for mysql databases, for h2 it works as expected.

The dependency mchange-commons-java which includes com/mchange/v2/ser/Indirector definetely exists for taxeditor.local. Can you please check the stacktrace which class loader tries to use it. So can you provide the full stack trace.

Also the question is why the exception is swallowed. Shouldn't it be thrown?

The exception is catched in rcp code (Window.class), there is no stacktrace but the detail message is: "com.mchange.v2.ser.Indirector cannot be found by eu.etaxonomy.taxeditor.cdmlib_5.18.0.qualifier"

and the classLoader is EquinoxClassLoader

Actions #26

Updated by Andreas Müller about 2 years ago

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:
and the classLoader is EquinoxClassLoader

Equinox is probably the Classloader for all. What I meant is, to wich module does it belong, taxeditor.local, taxeditor.cdmlib or even another (do I understand correctly that each model has its own classloader?

Actions #27

Updated by Andreas Müller about 2 years ago

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

The "New" button is missing.
...
sorry, I added the menu item again.

Can you move it to the top. That is where it was before.

done

Actions #28

Updated by Andreas Müller about 2 years ago

  • Subject changed from Move datasource view to taxeditor.webapp to Move datasource view to taxeditor.local
Actions #29

Updated by Andreas Müller about 2 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 60 to 100

This works now but there are still open issues to solve before all cdmlib-db stuff can fully migrate to taxeditor.local. Handled in #9341

Actions

Also available in: Atom PDF