bug #9168: NameFeature selection in preferences are not shown - EDIT - EDIT Project Management

Custom queries

5.33
cdm-dataportal (open)
last 7 days tickets
mine in current release
phycobank
phycobank-index-closed
phycobank-registration-closed
potentially missed issues
recently updated
Release3.7
Release3.8
Release4.0
Release4.1
Release4.10
Release4.11
Release4.12
Release4.13
Release4.14
Release4.16
Release4.2
Release4.3
Release4.4
Release4.5
Release4.6
Release4.7
Release4.8
Release4.9
Release4.9
Release5.0
Release5.1
Release5.10
Release5.11
Release5.12
Release5.13
Release5.14
Release5.15
Release5.16
Release5.17
Release5.18
Release5.19
Release5.2
Release5.20
Release5.21
Release5.22
Release5.23
Release5.24
Release5.25
Release5.26
Release5.27
Release5.28
Release5.29
Release5.3
Release5.30
Release5.31
Release5.32
Release5.33
Release5.34
Release5.35
Release5.36
Release5.37
Release5.38
Release5.39
Release5.4
Release5.40
Release5.41
Release5.5
Release5.6
Release5.7
Release5.8
Release5.9
Remoting-Versions
Taxeditor-UX (Platform Etablierung)

Actions

Copy link

bug #9168

closed

NameFeature selection in preferences are not shown

Added by Katja Luther over 3 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Highest

Assignee:

Katja Luther

Category:

taxeditor

Target version:

Release 5.17

Start date:

Due date:

% Done:

100%

Estimated time:

Severity:

normal

Found in Version:

Description

The preference of the selected name features are not shown in the preference page, this is because the checkedElements are termDtos and the elements of the tree are featureDtos.

Another issue:
After changing the name feature preferences, already open factual data views are not updated and the newly created facts are not displayed.

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Katja Luther over 3 years ago

Status changed from New to Resolved
% Done changed from 0 to 50

Applied in changeset taxeditor|1e1ccbfcfc9f8d45eb9f30fc08ad7eee51ce7282.

Actions

Copy link

Updated by Katja Luther over 3 years ago

Description updated (diff)
Status changed from Resolved to New
Assignee changed from Katja Luther to Andreas Müller
% Done changed from 50 to 0

Both issues are solved, please review

Actions

Copy link

Updated by Katja Luther over 3 years ago

Status changed from New to Resolved
% Done changed from 0 to 50

Applied in changeset taxeditor|0881e7341dea9cd5127bccae6473439442ac8814.

Actions

Copy link

Updated by Andreas Müller over 3 years ago

Status changed from Resolved to Feedback
Assignee changed from Andreas Müller to Katja Luther
Priority changed from New to Highest

when adding a new name fact (after changing the preferences) I got:

last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/term.service
last remote request client time : 2020-08-12T15:48:23.165
last remote request response header time : Wed, 12 Aug 2020 15:48:23 GMT
client error time : 2020-08-12T15:48:23.447
login : admin
editor version : 5.17.0.202008121156
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.15.2.0.20200611
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
    at org.eclipse.swt.SWT.error(SWT.java:4533)
    at org.eclipse.swt.SWT.error(SWT.java:4448)
    at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
    at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
    at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
    at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
    at eu.etaxonomy.taxeditor.Application.start(Application.java:20)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
Caused by: java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.editor.view.descriptive.e4.FactualDataPartE4.changed(FactualDataPartE4.java:211)
    at eu.etaxonomy.taxeditor.view.e4.AbstractCdmEditorPartE4.postOperation(AbstractCdmEditorPartE4.java:355)
    at eu.etaxonomy.taxeditor.operation.AbstractPostOperation.postExecute(AbstractPostOperation.java:77)
    at eu.etaxonomy.taxeditor.editor.view.descriptive.operation.CreateDescriptionElementOperation.execute(CreateDescriptionElementOperation.java:122)
    at eu.etaxonomy.taxeditor.model.AbstractUtility.lambda$3(AbstractUtility.java:148)
    at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:162)
    at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:154)
    at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
    at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
    ... 23 more

Actions

Copy link

Updated by Andreas Müller over 3 years ago

The new code (even the 'cleaned code') contains a lot of commented code. Can we remove this code (or leave a note why this commented code should be kept)?

Actions

Copy link