https://dev.e-taxonomy.eu/redmine/https://dev.e-taxonomy.eu/redmine/redmine/favicon.ico?14691914852020-07-10T14:45:58ZEDIT Project ManagementEDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=547052020-07-10T14:45:58ZAndreas Müller
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/redmine/journals/54705/diff?detail_id=68281">diff</a>)</li></ul> EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=566742020-12-04T08:03:34ZKatja Luther
<ul><li><strong>Target version</strong> changed from <i>Release 5.18</i> to <i>Release 5.19</i></li></ul> EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=568852020-12-17T10:30:49ZKatja Luther
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> changed from <i>Katja Luther</i> to <i>Andreas Müller</i></li></ul><p>This should be fixed. Please review.</p>
EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=568862020-12-17T10:36:12ZKatja Luther
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>50</i></li></ul><p>Applied in changeset <a class="changeset" title="fix #9142: fix doubled entries in agent selection dialog" href="https://dev.e-taxonomy.eu/redmine/projects/edit/repository/taxeditor/revisions/359b77dda6efc328563cfd93e63aee841662b4e7">taxeditor|359b77dda6efc328563cfd93e63aee841662b4e7</a>.</p>
EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=568872020-12-17T10:39:54ZAndreas Müller
<ul></ul><p>can you shortly explain what the problem was and why the commit fixes it?</p>
EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=568882020-12-17T10:49:16ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Katja Luther</i></li></ul> EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=568892020-12-18T09:54:13ZKatja Luther
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>Assignee</strong> changed from <i>Katja Luther</i> to <i>Andreas Müller</i></li></ul><p>First I thought it was because the search method was called twice but the real cause was the wrong implementation of the getUuidAndAbbrevTitleCache method.</p>
EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=568922020-12-18T10:14:04ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Katja Luther</i></li></ul><p>Thats what I thought. It is actually not really a wrong implementation of the method but due to the above described strange behavior of hibernate when using eager loading.</p>
<p>By the way can't we remove the commented line?</p>
<p>Also I wonder if not the more correct way to filter for classes is to use the class parameter in HQL as described here (<a href="https://docs.jboss.org/hibernate/orm/3.5/reference/de-DE/html/queryhql.html#queryhql-where">https://docs.jboss.org/hibernate/orm/3.5/reference/de-DE/html/queryhql.html#queryhql-where</a>) or here (<a href="https://stackoverflow.com/questions/8911894/hql-query-for-multiple-types-classes">https://stackoverflow.com/questions/8911894/hql-query-for-multiple-types-classes</a>). I guess this way you can also use abstract superclasses like TeamOrPersonBase and do not have to distinguish each case. The current implementation is dangerous whenever the might be a new AgentBase subclass in future and probably does even now not work if you pass "AgenBase.class" as parameter which is a legal argument.</p>
EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=568932020-12-18T10:25:38ZKatja Luther
<ul><li><strong>Assignee</strong> changed from <i>Katja Luther</i> to <i>Andreas Müller</i></li></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Thats what I thought. It is actually not really a wrong implementation of the method but due to the above described strange behavior of hibernate when using eager loading.</p>
<p>By the way can't we remove the commented line?</p>
<p>Also I wonder if not the more correct way to filter for classes is to use the class parameter in HQL as described here (<a href="https://docs.jboss.org/hibernate/orm/3.5/reference/de-DE/html/queryhql.html#queryhql-where">https://docs.jboss.org/hibernate/orm/3.5/reference/de-DE/html/queryhql.html#queryhql-where</a>) or here (<a href="https://stackoverflow.com/questions/8911894/hql-query-for-multiple-types-classes">https://stackoverflow.com/questions/8911894/hql-query-for-multiple-types-classes</a>). I guess this way you can also use abstract superclasses like TeamOrPersonBase and do not have to distinguish each case. The current implementation is dangerous whenever the might be a new AgentBase subclass in future and probably does even now not work if you pass "AgenBase.class" as parameter which is a legal argument.</p>
</blockquote>
<p>I already thought about it, but thought that TeamOrPersonBase would not work, but it work. I changed the implementation in this way, please have a look.</p>
EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=574572021-01-21T15:37:14ZAndreas Müller
<ul></ul><p>Katja Luther wrote:</p>
<blockquote>
<p>Andreas Müller wrote:</p>
<blockquote>
<p>Thats what I thought. It is actually not really a wrong implementation of the method but due to the above described strange behavior of hibernate when using eager loading.</p>
<p>By the way can't we remove the commented line?</p>
<p>Also I wonder if not the more correct way to filter for classes is to use the class parameter in HQL as described here (<a href="https://docs.jboss.org/hibernate/orm/3.5/reference/de-DE/html/queryhql.html#queryhql-where">https://docs.jboss.org/hibernate/orm/3.5/reference/de-DE/html/queryhql.html#queryhql-where</a>) or here (<a href="https://stackoverflow.com/questions/8911894/hql-query-for-multiple-types-classes">https://stackoverflow.com/questions/8911894/hql-query-for-multiple-types-classes</a>). I guess this way you can also use abstract superclasses like TeamOrPersonBase and do not have to distinguish each case. The current implementation is dangerous whenever the might be a new AgentBase subclass in future and probably does even now not work if you pass "AgenBase.class" as parameter which is a legal argument.</p>
</blockquote>
<p>I already thought about it, but thought that TeamOrPersonBase would not work, but it work. I changed the implementation in this way, please have a look.</p>
</blockquote>
<p>I cleaned up the query code a bit further to make it simpler.</p>
EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=574582021-01-21T17:04:59ZAndreas Müller
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Katja Luther</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>90</i></li></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>By the way can't we remove the commented line?</p>
</blockquote>
<p>I deleted the line and also cleaned up the TaxEditor code further.</p>
<p>There is still the commented code for "createFilter()" starting at line 110. Can this be removed?</p>
<p>The ticket can be closed then.</p>
EDIT - bug #9142: The Agent search dialog shows duplicated entrieshttps://dev.e-taxonomy.eu/redmine/issues/9142?journal_id=574982021-01-22T11:16:28ZKatja Luther
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Closed</i></li></ul><p>cleaned the code and close ticket.</p>