Project

General

Profile

bug #9103

missing exception handling in TaxoNodeDto

Added by Andreas Kohlbecker 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Highest
Assignee:
Category:
cdmlib
Target version:
Start date:
06/26/2020
Due date:
% Done:

50%

Severity:
normal
Found in Version:

Description

see

try{
                TaxonNode parent = taxonNode.getParent();
                parentUUID = parent == null? null:parent.getUuid();
            }catch(Exception e){
                parentUUID = null;
            }

            sortIndex = taxonNode.getSortIndex();
            try{
                classificationUUID = taxonNode.getClassification().getUuid();

            }catch(Exception e){
                classificationUUID = null;
            }

LazyInitializationException are caught here, which can lean to missing data due to improper initialization.

Associated revisions

Revision 5d89c869 (diff)
Added by Andreas Kohlbecker about 1 month ago

fix #9103 letting LIEs bubble up

Revision b68da265 (diff)
Added by Andreas Kohlbecker 18 days ago

ref #9103 adding missing init strategy element to TaxonController

History

#1 Updated by Andreas Kohlbecker 3 months ago

@Katja: has far as I could see, this stems from you, was there any urgent reason for this?

#2 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from New to Feedback

#3 Updated by Katja Luther about 1 month ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker

sorry, I don't know anymore why I did this.

#4 Updated by Andreas Kohlbecker about 1 month ago

  • Status changed from Feedback to Resolved

Ok, so we should fix this right after the release by a proper implementation which

  1. checks for taxonNode.getClassification() == null and avoids catching exception
  2. remove the try .. catch in case of taxonNode.getParent() completely

This should be done quickly after the release to give problems time to pop up!

I'll keep this in the 5.17 milestone as resolved so that it can be done during the milestone cleanup.

#5 Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.18 to Release 5.17

#6 Updated by Andreas Kohlbecker about 1 month ago

  • % Done changed from 0 to 50

#7 Updated by Andreas Kohlbecker about 1 month ago

  • Assignee changed from Andreas Kohlbecker to Katja Luther
  • Priority changed from New to Highest
  • Target version changed from Release 5.17 to Release 5.18

done, please review

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)