Project

General

Profile

feature request #8990

Implement flowering periods (temporal facts) in TaxEditor

Added by Andreas Müller 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
04/30/2020
Due date:
% Done:

100%

Severity:
major

Description

This includes

  • a new field "supportsTemporalData" in the Feature details view
  • a new details view for the new DescriptionElementBase subclass TemporalData

label provider for factual data view needs to be adapted!


Related issues

Related to Edit - feature request #8802: Implement flowering period for Flora of Cyprus Closed 01/14/2020
Related to Edit - feature request #8989: Implement flowering periods (temporal facts) in dataportal New 04/30/2020
Related to Edit - feature request #9072: Layout issues temporal data details view New 06/16/2020
Copied to Edit - feature request #9071: Implement formatter for TimePeriod, VerbatimTimePeriod and ExtendedTimePeriod Resolved 06/16/2020

Associated revisions

Revision 6c9baadc (diff)
Added by Katja Luther 5 months ago

ref #8990: add temporal data to editor

Revision 58ed6b7d (diff)
Added by Katja Luther 5 months ago

ref #8990: add temporal data to editor - adapt date element

Revision bfa4bcb7 (diff)
Added by Katja Luther 4 months ago

ref #8990: add formatter for extendedTimeperiod

Revision c9e66e15 (diff)
Added by Katja Luther 4 months ago

ref #8990: use the extendedTimePeriodPartialFormatter

Revision 7df3e4dd (diff)
Added by Katja Luther 4 months ago

ref #8990: add formatter for extendedTimeperiod - minor

Revision f266536e (diff)
Added by Andreas Müller 4 months ago

ref #8990 fix NPE in getTemporalDataText

Revision cfddafff (diff)
Added by Andreas Müller 4 months ago

ref #8990 fix NPE in getTemporalDataText (cont.)

History

#1 Updated by Andreas Müller 6 months ago

#2 Updated by Andreas Müller 6 months ago

#3 Updated by Andreas Müller 5 months ago

  • Description updated (diff)
  • Severity changed from normal to major

#4 Updated by Katja Luther 5 months ago

  • Description updated (diff)
  • Status changed from New to In Progress

#5 Updated by Katja Luther 4 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

a first implementation is available, please review.

#6 Updated by Andreas Müller 4 months ago

There was still an NPE in the DescriptionHelper. I tried to fix this in f266536e

#7 Updated by Andreas Müller 4 months ago

Maybe we can still improve the layout by not redundantly using "Month" and "Day" but instead having a theses labels as column headers. This will save space.

Also a possible line break in the labels "Extreme Start" and "Extreme End" could help to support even small (in width) details views.

#8 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 30

Andreas Müller wrote:

There was still an NPE in the DescriptionHelper. I tried to fix this in f266536e

This works now. Katja, could you please check if the fixes are correct?

#9 Updated by Andreas Müller 4 months ago

  • Copied to feature request #9071: Implement formatter for TimePeriod, VerbatimTimePeriod and ExtendedTimePeriod added

#10 Updated by Andreas Müller 4 months ago

An improved formatter is handled in #9071

#11 Updated by Andreas Müller 4 months ago

  • % Done changed from 30 to 80

Andreas Müller wrote:

Maybe we can still improve the layout by not redundantly using "Month" and "Day" but instead having a theses labels as column headers. This will save space.

Also a possible line break in the labels "Extreme Start" and "Extreme End" could help to support even small (in width) details views.

These are minor issues. If we decide to implement them we can also move them to a new ticket if necessary.

#12 Updated by Katja Luther 4 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 30

Andreas Müller wrote:

Andreas Müller wrote:

There was still an NPE in the DescriptionHelper. I tried to fix this in f266536e

This works now. Katja, could you please check if the fixes are correct?

looks good. The remaining layout issues I move to a new ticket.(#9072)

#13 Updated by Katja Luther 4 months ago

#14 Updated by Andreas Müller 4 months ago

  • Subject changed from Implement flowering seasons (temporal facts) in TaxEditor to Implement flowering periods (temporal facts) in TaxEditor

#15 Updated by Andreas Müller 4 months ago

  • % Done changed from 30 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)