Project

General

Profile

Actions

feature request #8990

closed

Implement flowering periods (temporal facts) in TaxEditor

Added by Andreas Müller over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
major

Description

This includes

  • a new field "supportsTemporalData" in the Feature details view
  • a new details view for the new DescriptionElementBase subclass TemporalData

label provider for factual data view needs to be adapted!


Related issues

Related to EDIT - feature request #8802: Implement flowering period for Flora of CyprusClosedAndreas Müller

Actions
Related to EDIT - feature request #8989: Implement flowering periods (temporal facts) in dataportalClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #9072: Layout issues temporal data details viewNewKatja Luther

Actions
Copied to EDIT - feature request #9071: Implement formatter for TimePeriod, VerbatimTimePeriod and ExtendedTimePeriodClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 2 years ago

Actions #2

Updated by Andreas Müller over 2 years ago

Actions #3

Updated by Andreas Müller over 2 years ago

  • Description updated (diff)
  • Severity changed from normal to major
Actions #4

Updated by Katja Luther over 2 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
Actions #5

Updated by Katja Luther over 2 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

a first implementation is available, please review.

Actions #6

Updated by Andreas Müller over 2 years ago

There was still an NPE in the DescriptionHelper. I tried to fix this in f266536e

Actions #7

Updated by Andreas Müller over 2 years ago

Maybe we can still improve the layout by not redundantly using "Month" and "Day" but instead having a theses labels as column headers. This will save space.

Also a possible line break in the labels "Extreme Start" and "Extreme End" could help to support even small (in width) details views.

Actions #8

Updated by Andreas Müller over 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 30

Andreas Müller wrote:

There was still an NPE in the DescriptionHelper. I tried to fix this in f266536e

This works now. Katja, could you please check if the fixes are correct?

Actions #9

Updated by Andreas Müller over 2 years ago

  • Copied to feature request #9071: Implement formatter for TimePeriod, VerbatimTimePeriod and ExtendedTimePeriod added
Actions #10

Updated by Andreas Müller over 2 years ago

An improved formatter is handled in #9071

Actions #11

Updated by Andreas Müller over 2 years ago

  • % Done changed from 30 to 80

Andreas Müller wrote:

Maybe we can still improve the layout by not redundantly using "Month" and "Day" but instead having a theses labels as column headers. This will save space.

Also a possible line break in the labels "Extreme Start" and "Extreme End" could help to support even small (in width) details views.

These are minor issues. If we decide to implement them we can also move them to a new ticket if necessary.

Actions #12

Updated by Katja Luther over 2 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 30

Andreas Müller wrote:

Andreas Müller wrote:

There was still an NPE in the DescriptionHelper. I tried to fix this in f266536e

This works now. Katja, could you please check if the fixes are correct?

looks good. The remaining layout issues I move to a new ticket.(#9072)

Actions #13

Updated by Katja Luther over 2 years ago

Actions #14

Updated by Andreas Müller over 2 years ago

  • Subject changed from Implement flowering seasons (temporal facts) in TaxEditor to Implement flowering periods (temporal facts) in TaxEditor
Actions #15

Updated by Andreas Müller over 2 years ago

  • % Done changed from 30 to 100
Actions

Also available in: Atom PDF