Project

General

Profile

Actions

feature request #8930

closed

Publishable objects should show icon if they are unpublished

Added by Andreas Müller about 4 years ago. Updated 2 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

To avoid that someone accidentally switches the publish flag of and generally to immediately now that a taxon is not published.
Maybe we should show these icons also in the name editor and/or the bulk editor (or whereever a taxon is shown, e.g. search results, etc.)

The same should be implemented for doubtful taxa (see comment #1)

Also we should implement it similarly for Descriptions (see also #10206, #10333) and SpecimeOrObservation (see also #7444)


Files

Screenshot 2024-01-24 111112.png (9.75 KB) Screenshot 2024-01-24 111112.png Katja Luther, 01/24/2024 11:11 AM
Screenshot 2024-01-24 111112.png (9.75 KB) Screenshot 2024-01-24 111112.png Katja Luther, 01/24/2024 11:39 AM
Screenshot 2024-01-24 113915.png (5.06 KB) Screenshot 2024-01-24 113915.png Katja Luther, 01/24/2024 11:39 AM
Screenshot 2024-01-24 113948.png (18.3 KB) Screenshot 2024-01-24 113948.png Katja Luther, 01/24/2024 11:41 AM
clipboard-202401250943-swace.png (1002 Bytes) clipboard-202401250943-swace.png Andreas Müller, 01/25/2024 09:43 AM
clipboard-202401251404-hyo18.png (9.51 KB) clipboard-202401251404-hyo18.png Andreas Müller, 01/25/2024 02:04 PM
clipboard-202401260945-lz8ic.png (2.24 KB) clipboard-202401260945-lz8ic.png Andreas Müller, 01/26/2024 09:45 AM
clipboard-202401260945-utifv.png (2.93 KB) clipboard-202401260945-utifv.png Andreas Müller, 01/26/2024 09:45 AM
clipboard-202401260951-6mzzz.png (4.03 KB) clipboard-202401260951-6mzzz.png Andreas Müller, 01/26/2024 09:51 AM

Related issues

Related to EDIT - feature request #10333: Make publish flag editable for DescriptionBaseClosedKatja Luther

Actions
Related to EDIT - feature request #10206: Add publish flag to description baseClosedAndreas Müller

Actions
Related to EDIT - feature request #10334: Evaluate DescriptionBase.publish in webservicesClosedAndreas Müller

Actions
Actions #1

Updated by Katja Luther about 4 years ago

  • Description updated (diff)

mail WB:

In diesem Zusammenhang wollte ich auch anregen, die als doubtful markierten Taxa auch im Navigator mit dem „?“ zu kennzeichnen (die unresolved haben ja zwei). Aber das ist ja schon für den Taxon-Node „placement is doubtful“ Status reserviert. Vermutlich bezieht sich das Doubtful im Details view auf das Taxon und nicht auf den Node? Das wird kein Taxonom beim arbeiten so verstehen.

Actions #2

Updated by Katja Luther almost 4 years ago

  • Target version changed from Release 5.15 to Release 5.18
Actions #3

Updated by Katja Luther over 3 years ago

  • Target version changed from Release 5.18 to Release 5.19
Actions #4

Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 5.19 to Release 5.21
Actions #5

Updated by Andreas Müller about 3 years ago

  • Target version changed from Release 5.21 to Release 5.22
Actions #6

Updated by Andreas Müller about 3 years ago

  • Tags set to fast
Actions #7

Updated by Andreas Müller about 3 years ago

Katja Luther wrote:

mail WB:

In diesem Zusammenhang wollte ich auch anregen, die als doubtful markierten Taxa auch im Navigator mit dem „?“ zu kennzeichnen (die unresolved haben ja zwei). Aber das ist ja schon für den Taxon-Node „placement is doubtful“ Status reserviert. Vermutlich bezieht sich das Doubtful im Details view auf das Taxon und nicht auf den Node? Das wird kein Taxonom beim arbeiten so verstehen.

As a fast solution we may show "?" no matter if the placement is doubtful or the taxon status is doubtful. We will soon discuss the meaning of these flags anyway and until then a somewhat dirty solution is acceptable I think.

Actions #8

Updated by Katja Luther almost 3 years ago

  • Target version changed from Release 5.22 to Release 5.25
Actions #9

Updated by Andreas Müller almost 3 years ago

  • Target version changed from Release 5.25 to Release 5.45
Actions #10

Updated by Andreas Müller 11 months ago

Actions #11

Updated by Andreas Müller 11 months ago

Actions #12

Updated by Andreas Müller 11 months ago

  • Subject changed from Taxon navigator should show icon if a taxon is unpublished to Publishable objects should show icon if they are unpublished
  • Description updated (diff)
Actions #13

Updated by Andreas Müller 11 months ago

  • Priority changed from New to Highest
Actions #14

Updated by Andreas Müller 11 months ago

If it is possible to use unicode we could use https://www.compart.com/de/unicode/U+26D4 (⛔)

Actions #17

Updated by Andreas Müller 3 months ago

  • Target version changed from Release 5.45 to Release 5.42

Maybe this is a no-brainer and it fits to the current milestone (#10334)

Actions #18

Updated by Andreas Müller 3 months ago

Actions #19

Updated by Katja Luther 3 months ago

It works with the unicode symbol, but without colours:

Actions #20

Updated by Katja Luther 3 months ago

  • Status changed from New to In Progress
Actions #21

Updated by Katja Luther 3 months ago

What do you think about this:

in taxon navigator

and this in factual data view:

The science are nearly similar and it is more a warning than a prohibition symbol

Actions #23

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-21:

What do you think about this:

in taxon navigator

and this in factual data view:

The science are nearly similar and it is more a warning than a prohibition symbol

A "warning" usually means that there is something not correct with the data and needs to be fixed. But this is not the case here. Unpublished just meanst that it prohibited to the public so the "prohibition" sign for me is exactly the correct one.

Actions #24

Updated by Katja Luther 3 months ago

So I used the (red) circle as symbol, please review.

Actions #25

Updated by Katja Luther 3 months ago

  • Status changed from In Progress to Resolved
Actions #26

Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #27

Updated by Andreas Müller 3 months ago

  • % Done changed from 0 to 70

Functionality works.

However, this circle is very thin so especially in the navigator it is difficult to recognize as a "prohibited" symbol. Why didn't you use U+26D4 as in the example above (note-19). This for me looks much more intuitive.

Actions #28

Updated by Andreas Müller 3 months ago

In the factual data it is nice that it shows color. The disadvantage seems to be that there is always a larger space in front of the text of all elements in the facts tree. It is not possible to avoid this? We also had symbols for the different types of descriptions (e.g. aggregation) but I do not remember that it is the same there. But maybe I am wrong.
If it is not the same, can't we implement it the same way as the aggregation etc.?

Actions #29

Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

What is the reason that the facts view allows color symbols while the navigator does only allow text based symbols?

Actions #30

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-28:

In the factual data it is nice that it shows color. The disadvantage seems to be that there is always a larger space in front of the text of all elements in the facts tree. It is not possible to avoid this? We also had symbols for the different types of descriptions (e.g. aggregation) but I do not remember that it is the same there. But maybe I am wrong.
If it is not the same, can't we implement it the same way as the aggregation etc.?

I implemented it the same way like the other symbols.

Actions #31

Updated by Andreas Müller 3 months ago

I just realize that probably the "ban" icon is even more adequate: https://fontawesome.com/icons/ban?f=classic&s=solid

Actions #32

Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I was wrong, it is possible to add an image also in navigator, so now I added the same image in the navigator and in the factal data view. Please review.

Actions #33

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-31:

I just realize that probably the "ban" icon is even more adequate: https://fontawesome.com/icons/ban?f=classic&s=solid

Sorry, didn't see this comment. Now it is a "No entry" icon. But I can switch.

Actions #34

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-32:

I was wrong, it is possible to add an image also in navigator, so now I added the same image in the navigator and in the factal data view. Please review.

But then we have the same issue in the navigator as we have for the factual data, that whenever any single image exists the whole tree is shown with "empty" images. E.g.

I guess this was the reason why we originally did not use images in the navigator.

Also the image does not look very nice there it seems to have an issue with the resolution or so.

Also now we have text based symbols for the taxon node state by image based symbols for taxon.publish state. This does not really go together and looks odd.

Therefore I would prefer to switch back to text based symbols in the navigator. To not have it somehow consistent can we also have a colorless symbol in facts view then too? As the facts view uses images also for other reasons it can or even should be image based there, but black/white/grey not red as in the navigator.

Actions #35

Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions #36

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-34:

I guess this was the reason why we originally did not use images in the navigator.

Also the image does not look very nice there it seems to have an issue with the resolution or so.

Also now we have text based symbols for the taxon node state by image based symbols for taxon.publish state. This does not really go together and looks odd.

Therefore I would prefer to switch back to text based symbols in the navigator. To not have it somehow consistent can we also have a colorless symbol in facts view then too? As the facts view uses images also for other reasons it can or even should be image based there, but black/white/grey not red as in the navigator.

I could not find a unicode symbol for the ban image (there is one, but it does not work), so I switched back to the "no entry" symbol. I have to create a new image in black for the factual data view.

Actions #37

Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #38

Updated by Andreas Müller 3 months ago

Katja Luther wrote in #note-36:

Andreas Müller wrote in #note-34:

I guess this was the reason why we originally did not use images in the navigator.

Also the image does not look very nice there it seems to have an issue with the resolution or so.

Also now we have text based symbols for the taxon node state by image based symbols for taxon.publish state. This does not really go together and looks odd.

Therefore I would prefer to switch back to text based symbols in the navigator. To not have it somehow consistent can we also have a colorless symbol in facts view then too? As the facts view uses images also for other reasons it can or even should be image based there, but black/white/grey not red as in the navigator.

I could not find a unicode symbol for the ban image (there is one, but it does not work), so I switched back to the "no entry" symbol. I have to create a new image in black for the factual data view.

The navigator still uses image and not text based symbol so I do maybe not fully understand what exactly you have fixed and why. This implementation not only has the problem of empty spaces but also for some reason has a worse behaviour when trying to expand and collapse the tree. For some reason the symbol (>) is somehow different and the click area that reacts with expanding and collapsing is smaller. This is really annoying and should be changed. Why not simply returning to

This looked good and if color is not possible it is not a big issue.

Actions #39

Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
Actions #40

Updated by Andreas Müller 3 months ago

By the way the strange clicking behaviour also appears in the facts view.

But: it only appears when showing the current unpublished image.

When showing e.g. the aggregation image it does not happen and also the expand symbol (>) is showing correctly and not smaller. So something is different with this implementation / image. Where are the 2 images taken from?

Test for aggregation: rem-conf-am/Mein name subsp. dupltest
Test for unpublished: Mein name subsp. childeins A.Arrhxx.

Actions #41

Updated by Andreas Müller 3 months ago

In navigator it looks fine now with the text based symbol.

Only a minor issue: if there are taxon node status symbols and the unpublished symbol personally I would first put the unpublished and then the node status. I think it looks better

Actions #42

Updated by Katja Luther 3 months ago

Andreas Müller wrote in #note-40:

By the way the strange clicking behaviour also appears in the facts view.

But: it only appears when showing the current unpublished image.

When showing e.g. the aggregation image it does not happen and also the expand symbol (>) is showing correctly and not smaller. So something is different with this implementation / image. Where are the 2 images taken from?

Test for aggregation: rem-conf-am/Mein name subsp. dupltest
Test for unpublished: Mein name subsp. childeins A.Arrhxx.

This is really strange, I used the "unpublished" icon the same way as the other icons. I also compared the sizes and the "aggregated" icon is a little bit larger than the "unpublished" icon. I can try to make it the same size.

Actions #43

Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

The icon for the factual data view is adapted now, it's not perfect but better I think. The behavior of the tree is defined by the jface treeviewer, and it is the same for the already existing images.

Actions #44

Updated by Andreas Müller 2 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 100

For now it looks ok and we can close the ticket.

Actions

Also available in: Atom PDF