Project

General

Profile

Actions
Copy link

feature request #8906

closed

Refactor DNA Sample details view

Added by Katja Luther about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.14
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:
additivity

Description

The DNA Sample details view is not handled like the other derived units by using the derivedUnitFacade.

Related issues

Related to EDIT - bug #8910: Correct handling of preference for determinationsClosedKatja Luther

Actions
Related to EDIT - bug #8946: Refactor DerivedUnit Details viewNewKatja Luther

Actions
Actions
Copy link
 #1

Updated by Katja Luther about 3 years ago

  • Subject changed from Refactor DNA Samole details view to Refactor DNA Sample details view
Actions
Copy link
 #2

Updated by Andreas Müller about 3 years ago

Especially determinations are missing there.

Actions
Copy link
 #3

Updated by Andreas Müller about 3 years ago

By the way the derivedUnitFacace was originally meant to work with the Specimen list editor. For the tree editor it does not really make sense to use the facade so we should discuss how to get away from it.

Actions
Copy link
 #4

Updated by Andreas Müller about 3 years ago

  • Tags set to additivity
  • Target version changed from Unassigned CDM tickets to Release 5.14

As this ticket is important for cleaning up additivity data I put it to the current milestone.

Actions
Copy link
 #5

Updated by Katja Luther about 3 years ago

Andreas Müller wrote:

By the way the derivedUnitFacace was originally meant to work with the Specimen list editor. For the tree editor it does not really make sense to use the facade so we should discuss how to get away from it.

This ticket is about the details view of dnaSample, for the tree editor there is another dto.

Actions
Copy link
 #6

Updated by Andreas Müller about 3 years ago

Katja Luther wrote:

Andreas Müller wrote:

By the way the derivedUnitFacace was originally meant to work with the Specimen list editor. For the tree editor it does not really make sense to use the facade so we should discuss how to get away from it.

This ticket is about the details view of dnaSample, for the tree editor there is another dto.

Yes, sorry, my comment was a bit short. Of course, I was also talking about the details view, but the details view should depend on the editor you use. In the list editor you must use a facade based details view as the list editor represents multiple records simplified by the facade. In the tree editor 1 "row" handles only 1 DB record (+ maybe the according DerivationEvent). Therefore here using a facade does not make sense.
That's all I wanted to mention as I was not sure if you had followed the according discussion as the tree editor was developed by Patrick originally.

Actions
Copy link
 #7

Updated by Katja Luther about 3 years ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

By the way the derivedUnitFacace was originally meant to work with the Specimen list editor. For the tree editor it does not really make sense to use the facade so we should discuss how to get away from it.

This ticket is about the details view of dnaSample, for the tree editor there is another dto.

Yes, sorry, my comment was a bit short. Of course, I was also talking about the details view, but the details view should depend on the editor you use. In the list editor you must use a facade based details view as the list editor represents multiple records simplified by the facade. In the tree editor 1 "row" handles only 1 DB record (+ maybe the according DerivationEvent). Therefore here using a facade does not make sense.
That's all I wanted to mention as I was not sure if you had followed the according discussion as the tree editor was developed by Patrick originally.

Ah, now I got it, for all derived units initially the facade is created and if selection providing part is the tree editor a flag is set to use only the derived unit...

Actions
Copy link
 #8

Updated by Katja Luther almost 3 years ago

  • Status changed from New to Resolved

Now, the dna sample details view is handled analogue to the other derived units. So the determination can be shown, now.

But we should create a new ticket to think about refactoring the details view of specimen in list and tree editor.

Actions
Copy link
 #9

Updated by Katja Luther almost 3 years ago

  • % Done changed from 0 to 50
Actions
Copy link
 #10

Updated by Katja Luther almost 3 years ago

  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 50 to 0
Actions
Copy link
 #11

Updated by Andreas Müller almost 3 years ago

  • Related to bug #8910: Correct handling of preference for determinations added
Actions
Copy link
 #12

Updated by Andreas Müller almost 3 years ago

See #8910#note-5 for a possible regression

Actions
Copy link
 #13

Updated by Andreas Müller almost 3 years ago

  • % Done changed from 0 to 30

Katja Luther wrote:

But we should create a new ticket to think about refactoring the details view of specimen in list and tree editor.

Can you create such a ticket?

Actions
Copy link
 #14

Updated by Andreas Müller almost 3 years ago

For reviewing: is there anything else that is new or changed in the DNA details view beside determinations?

Actions
Copy link
 #15

Updated by Andreas Müller almost 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Determinations work now can we still add "Accession number" below "Barcode" as this is the default id field for imported DNA data?

Actions
Copy link
 #16

Updated by Andreas Müller almost 3 years ago

As also commented in #8910 the show determinations only for field units preference does not yet work for the new DNA Sample determinations.

Actions
Copy link
 #17

Updated by Katja Luther almost 3 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 30 to 50
Actions
Copy link
 #18

Updated by Katja Luther almost 3 years ago

  • Status changed from Resolved to Feedback
  • % Done changed from 50 to 30

Andreas Müller wrote:

Determinations work now can we still add "Accession number" below "Barcode" as this is the default id field for imported DNA data?

this is fixed.

Actions
Copy link
 #19

Updated by Katja Luther almost 3 years ago

Andreas Müller wrote:

As also commented in #8910 the show determinations only for field units preference does not yet work for the new DNA Sample determinations.

this is fixed, too.

Actions
Copy link
 #20

Updated by Katja Luther almost 3 years ago

  • Related to bug #8946: Refactor DerivedUnit Details view added
Actions
Copy link
 #21

Updated by Katja Luther almost 3 years ago

Andreas Müller wrote:

Katja Luther wrote:

But we should create a new ticket to think about refactoring the details view of specimen in list and tree editor.

Can you create such a ticket?

this is #8946

Actions
Copy link
 #22

Updated by Katja Luther almost 3 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review

Actions
Copy link
 #23

Updated by Andreas Müller almost 3 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 30 to 100

Works as expected

Actions
Copy link

Also available in: Atom PDF