Project

General

Profile

bug #8851

display of name facts not appropriate in all cases

Added by Andreas Kohlbecker over 1 year ago. Updated 8 months ago.

Status:
Closed
Priority:
Priority14
Category:
cdm-dataportal
Target version:
Start date:
02/20/2020
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

Hallo,

wir sind bei der Flora von Cuba auf ein Portalausgabeproblem gestoßen, und zwar bei den Name Facts.

Anscheinend werden alle Typen so behandelt wie zusätzliche Nomenklaturreferenzen (siehe Beispiel unten). Das müsste geringfügig geändert werden:

Grundsätzlich fehlt ein Leerzeichen vor der eckigen Klammer

Bei Typ „Additional publication“ kann das „& “ bleiben, ansonsten müsste das weg.

Da wir in der Kuba Flora zahlreiche Hybride und auch alternative Nomenklaturzitate haben, ist diese Bugbehebung dringend – spätestens zum Launch des Florenportals beim nächsten Flora de Cuba meeting in Havanna, 20. April 20.

Das gilt übrigens auch für den fehlerhaften External Link zu NYBG (dort liegen sehr viele Belege aus Kuba). Ich habe schon selbst probiert, den zu korrigieren, bekomme das aber irgendwie nicht hin.

Herzlichen Gruß

Walter

picture435-1.png View (67.1 KB) Andreas Kohlbecker, 02/20/2020 09:16 AM


Related issues

Related to Edit - task #9265: Adapt dataportal to new protologue handling Closed 10/29/2020

Associated revisions

Revision 1c7c424f (diff)
Added by Andreas Kohlbecker over 1 year ago

ref #8851 improving display of name facts

Revision e024a603 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8851, ref #9265 improved re-implementation of name desciptions (annotations and sources still pending)

Revision 79bd5456 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8851 adapting test for name desciptions

Revision f06c22c7 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8851 adding missing space

Revision 04f81145 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8851 adapting side-effected NameRelationshipsTest

Revision c11fa375 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8851 sources and annotations to name descriptions with test

Revision d9fa5913 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8851 extednding init strategy for name descriptions by sources and annotations

Revision 4a70bee8 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8851 adapting test assertions to modified test data

History

#1 Updated by Andreas Kohlbecker over 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20

remaining task to do: implement test

#2 Updated by Andreas Kohlbecker over 1 year ago

  • Target version changed from Release 5.13 to Release 5.14

#3 Updated by Andreas Kohlbecker over 1 year ago

  • Target version changed from Release 5.14 to Release 5.15

#4 Updated by Andreas Kohlbecker about 1 year ago

  • Target version changed from Release 5.15 to Release 5.18

#5 Updated by Andreas Kohlbecker 8 months ago

  • Related to task #9265: Adapt dataportal to new protologue handling added

#6 Updated by Andreas Kohlbecker 8 months ago

to query for relevant data:

SELECT db.DTYPE, db.id, feature.titleCache, deb.DTYPE, osb.id, osb.citation_id, r.titleCache, ls.`text` 
FROM DescriptionBase db 
    JOIN DescriptionElementBase deb ON deb.indescription_id = db.id
    LEFT JOIN DescriptionElementBase_OriginalSourceBase debosb on debosb.DescriptionElementBase_id = deb.id
    LEFT JOIN OriginalSourceBase osb on debosb.sources_id = osb.id 
    LEFT JOIN DescriptionElementBase_LanguageString debls on deb.id = debls.textdata_id 
    LEFT JOIN LanguageString ls on ls.id = debls.multilanguageText_id 
    JOIN DefinedTermBase feature ON feature.id = deb.feature_id
    LEFT JOIN Reference r on r.id = osb.citation_id  WHERE feature.titleCache LIKE '%Additional Pub%' AND db.DTYPE like 'TaxonNameDesc%'

#7 Updated by Andreas Kohlbecker 8 months ago

  • Status changed from In Progress to Closed
  • Priority changed from New to Priority14
  • % Done changed from 20 to 100

#8 Updated by Andreas Müller 8 months ago

Walter, can you have a look after the next release, if this is now all correct?

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)