bug #8815
closed
Clean up TaxonNodeDto and UuidAndTitleCache usage in TaxonNodeService/Dao
Added by Katja Luther over 4 years ago.
Updated about 4 years ago.
Description
In TaxonNodeService and Dao the usage of TaxonNodeDtp and UuidAndTitleCache duplicates some functionality. This should be cleaned up and check for the usage of the methods in tax editor and vaadin implementations.
Note: AreaAndTaxonSettingsConfigWindow and TaxonNodeContainerin cdm-vaadin need to be adapted accordingly.
- Description updated (diff)
- Blocked by task #8834: use TaxonNodeDto instead of UuidAndTitleCache added
- Status changed from New to In Progress
- % Done changed from 0 to 30
- Target version changed from Release 5.13 to Release 5.14
the blocker is moved to 5.14, this ticket also
- Related to bug #8892: Taxon search does not work for names without rank added
- % Done changed from 30 to 50
Hi Katja, I reverted the return types again from UuidAndTitleCache to TaxonNodeDto
Please review.
- Status changed from In Progress to Resolved
Is this ticket fully fixed and for review?
Andreas Müller wrote:
Is this ticket fully fixed and for review?
yes, I wrote this already in comment 7
- Status changed from Resolved to Closed
this seems to work, as there are no problems in the editor and the code looks fine as well.
- Assignee changed from Katja Luther to Andreas Kohlbecker
Andreas Kohlbecker wrote:
Andreas Müller wrote:
Is this ticket fully fixed and for review?
yes, I wrote this already in comment 7
yes, but status was still on "In Progress". Therefore I asked.
Also available in: Atom
PDF