Project

General

Profile

Actions
Copy link

bug #8815

closed

Clean up TaxonNodeDto and UuidAndTitleCache usage in TaxonNodeService/Dao

Added by Katja Luther over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
New
Assignee:
Andreas Kohlbecker
Category:
cdmlib
Target version:
Release 5.14
Start date:
Due date:
% Done:

50%

Estimated time:
Severity:
normal
Found in Version:

Description

In TaxonNodeService and Dao the usage of TaxonNodeDtp and UuidAndTitleCache duplicates some functionality. This should be cleaned up and check for the usage of the methods in tax editor and vaadin implementations.

Note: AreaAndTaxonSettingsConfigWindow and TaxonNodeContainerin cdm-vaadin need to be adapted accordingly.

Related issues

Related to EDIT - bug #8892: Taxon search does not work for names without rankClosedAndreas Kohlbecker

Actions
Blocked by EDIT - task #8834: use TaxonNodeDto instead of UuidAndTitleCache ClosedAndreas Kohlbecker

Actions
Actions
Copy link
 #1

Updated by Andreas Kohlbecker over 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Andreas Kohlbecker over 4 years ago

  • Blocked by task #8834: use TaxonNodeDto instead of UuidAndTitleCache added
Actions
Copy link
 #3

Updated by Andreas Müller over 4 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #4

Updated by Andreas Müller over 4 years ago

  • % Done changed from 0 to 30
Actions
Copy link
 #5

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.13 to Release 5.14

the blocker is moved to 5.14, this ticket also

Actions
Copy link
 #6

Updated by Andreas Kohlbecker over 4 years ago

  • Related to bug #8892: Taxon search does not work for names without rank added
Actions
Copy link
 #7

Updated by Andreas Kohlbecker over 4 years ago

  • % Done changed from 30 to 50

Hi Katja, I reverted the return types again from UuidAndTitleCache to TaxonNodeDto

Please review.

Actions
Copy link
 #8

Updated by Andreas Müller over 4 years ago

  • Status changed from In Progress to Resolved

Is this ticket fully fixed and for review?

Actions
Copy link
 #9

Updated by Andreas Kohlbecker over 4 years ago

Andreas Müller wrote:

Is this ticket fully fixed and for review?

yes, I wrote this already in comment 7

Actions
Copy link
 #10

Updated by Katja Luther over 4 years ago

  • Status changed from Resolved to Closed

this seems to work, as there are no problems in the editor and the code looks fine as well.

Actions
Copy link
 #11

Updated by Katja Luther over 4 years ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker
Actions
Copy link
 #12

Updated by Andreas Müller over 4 years ago

Andreas Kohlbecker wrote:

Andreas Müller wrote:

Is this ticket fully fixed and for review?

yes, I wrote this already in comment 7

yes, but status was still on "In Progress". Therefore I asked.

Actions
Copy link

Also available in: Atom PDF