Project

General

Profile

bug #8815

Clean up TaxonNodeDto and UuidAndTitleCache usage in TaxonNodeService/Dao

Added by Katja Luther 4 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
New
Category:
cdmlib
Target version:
Start date:
01/17/2020
Due date:
% Done:

50%

Severity:
normal
Found in Version:

Description

In TaxonNodeService and Dao the usage of TaxonNodeDtp and UuidAndTitleCache duplicates some functionality. This should be cleaned up and check for the usage of the methods in tax editor and vaadin implementations.

Note: AreaAndTaxonSettingsConfigWindow and TaxonNodeContainerin cdm-vaadin need to be adapted accordingly.


Related issues

Related to Edit - bug #8892: Taxon search does not work for names without rank Closed 03/13/2020
Blocked by Edit - task #8834: use TaxonNodeDto instead of UuidAndTitleCache Closed 01/28/2020

Associated revisions

Revision 99f73393 (diff)
Added by Katja Luther 4 months ago

cleanup taxonnodeDto - UuidAndTitleCache

Revision b140cc54 (diff)
Added by Katja Luther 4 months ago

merge ITaxonNodeService

Revision 8841d740 (diff)
Added by Katja Luther 4 months ago

adapted tests for harmonization of taxonnodeDto usage

Revision 57aa10c6 (diff)
Added by Katja Luther 4 months ago

followup to cleanup of taxonNodeDto/UuidAndTitleCache usage

Revision 75e3aef5 (diff)
Added by Katja Luther 4 months ago

ref #8815: add UuidAndTitleCache methods again in taxonnodeservice

Revision 47c1bab5 (diff)
Added by Katja Luther 4 months ago

ref #8815: add UuidAndTitleCache methods again in taxonnodeservice - continue

Revision e756cd24 (diff)
Added by Andreas Müller 4 months ago

ref #8815 adapt return type for uuidAndTitleCache method in taxonNodeService

Revision 925237ad (diff)
Added by Andreas Kohlbecker about 2 months ago

ref #8815 reverting return types from UuidAndTitleCache to TaxonNodeDto

Revision c2530585 (diff)
Added by Andreas Kohlbecker about 2 months ago

ref ref #8815 adding condition which was lost during conflict resolution

History

#1 Updated by Andreas Kohlbecker 4 months ago

  • Description updated (diff)

#2 Updated by Andreas Kohlbecker 4 months ago

  • Blocked by task #8834: use TaxonNodeDto instead of UuidAndTitleCache added

#3 Updated by Andreas Müller 3 months ago

  • Status changed from New to In Progress

#4 Updated by Andreas Müller 3 months ago

  • % Done changed from 0 to 30

#5 Updated by Katja Luther 3 months ago

  • Target version changed from Release 5.13 to Release 5.14

the blocker is moved to 5.14, this ticket also

#6 Updated by Andreas Kohlbecker 2 months ago

  • Related to bug #8892: Taxon search does not work for names without rank added

#7 Updated by Andreas Kohlbecker about 2 months ago

  • % Done changed from 30 to 50

Hi Katja, I reverted the return types again from UuidAndTitleCache to TaxonNodeDto

Please review.

#8 Updated by Andreas Müller about 2 months ago

  • Status changed from In Progress to Resolved

Is this ticket fully fixed and for review?

#9 Updated by Andreas Kohlbecker about 2 months ago

Andreas Müller wrote:

Is this ticket fully fixed and for review?

yes, I wrote this already in comment 7

#10 Updated by Katja Luther about 2 months ago

  • Status changed from Resolved to Closed

this seems to work, as there are no problems in the editor and the code looks fine as well.

#11 Updated by Katja Luther about 2 months ago

  • Assignee changed from Katja Luther to Andreas Kohlbecker

#12 Updated by Andreas Müller about 2 months ago

Andreas Kohlbecker wrote:

Andreas Müller wrote:

Is this ticket fully fixed and for review?

yes, I wrote this already in comment 7

yes, but status was still on "In Progress". Therefore I asked.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)