bug #8815
Clean up TaxonNodeDto and UuidAndTitleCache usage in TaxonNodeService/Dao
50%
Description
In TaxonNodeService and Dao the usage of TaxonNodeDtp and UuidAndTitleCache duplicates some functionality. This should be cleaned up and check for the usage of the methods in tax editor and vaadin implementations.
Note: AreaAndTaxonSettingsConfigWindow and TaxonNodeContainerin cdm-vaadin need to be adapted accordingly.
Related issues
Associated revisions
cleanup taxonnodeDto - UuidAndTitleCache
merge ITaxonNodeService
adapted tests for harmonization of taxonnodeDto usage
followup to cleanup of taxonNodeDto/UuidAndTitleCache usage
ref #8815: add UuidAndTitleCache methods again in taxonnodeservice
ref #8815: add UuidAndTitleCache methods again in taxonnodeservice - continue
ref #8815 adapt return type for uuidAndTitleCache method in taxonNodeService
ref #8815 reverting return types from UuidAndTitleCache to TaxonNodeDto
ref ref #8815 adding condition which was lost during conflict resolution
History
#1 Updated by Andreas Kohlbecker 7 months ago
- Description updated (diff)
#2 Updated by Andreas Kohlbecker 7 months ago
- Blocked by task #8834: use TaxonNodeDto instead of UuidAndTitleCache added
#3 Updated by Andreas Müller 6 months ago
- Status changed from New to In Progress
#4 Updated by Andreas Müller 6 months ago
- % Done changed from 0 to 30
#5 Updated by Katja Luther 5 months ago
- Target version changed from Release 5.13 to Release 5.14
the blocker is moved to 5.14, this ticket also
#6 Updated by Andreas Kohlbecker 5 months ago
- Related to bug #8892: Taxon search does not work for names without rank added
#7 Updated by Andreas Kohlbecker 5 months ago
- % Done changed from 30 to 50
Hi Katja, I reverted the return types again from UuidAndTitleCache to TaxonNodeDto
Please review.
#8 Updated by Andreas Müller 4 months ago
- Status changed from In Progress to Resolved
Is this ticket fully fixed and for review?
#9 Updated by Andreas Kohlbecker 4 months ago
Andreas Müller wrote:
Is this ticket fully fixed and for review?
yes, I wrote this already in comment 7
#10 Updated by Katja Luther 4 months ago
- Status changed from Resolved to Closed
this seems to work, as there are no problems in the editor and the code looks fine as well.
#11 Updated by Katja Luther 4 months ago
- Assignee changed from Katja Luther to Andreas Kohlbecker
#12 Updated by Andreas Müller 4 months ago
Andreas Kohlbecker wrote:
Andreas Müller wrote:
Is this ticket fully fixed and for review?
yes, I wrote this already in comment 7
yes, but status was still on "In Progress". Therefore I asked.
