Project

General

Profile

bug #8776

Open issues for TermCollection.allowDuplicates handling in TaxEditor

Added by Andreas Müller almost 2 years ago. Updated 5 months ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
08/19/2019
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

  • The error message currently looks like an unhandled error. The message should only inform about the fact that duplicates are not allowed and therefore the selected area could not be added. No stacktrace should be shown (and also no stacktrace should be created! in any logfile as this should be a handled case).
    Also only 1 message should be shown if >1 terms are tried to be added which already exist.
    this was partly fixed and information about the doubled terms are added.

  • copied from #8477: do not allow editing the flag if duplicates exist in the collection

  • when changing the title of the tree the part which handles the details view area which holds the 3 flags (allow duplicates, is flat and order relevant) becomes orange. As these flags are not relevant for the titleCache this should not be the case this seems to be fixed in the meanwhile

  • "Paste" should not be available in context menu if the area already exists in the tree

  • d&d from 1 term tree to another in the same TermTreeEditor does currently not do the check (and therefore duplicates are possible), while d&d from e.g. term editor to term tree editor does check if duplicates exists (same way as described in first issue above)

  • d&d from a vocabulary to the term tree should not be possible if the term is a duplicate


Related issues

Related to Edit - feature request #8476: Implement support for TermCollection.isFlat in TaxEditor Closed 08/16/2019
Related to Edit - feature request #8474: Make TermCollection.orderRelevant usable for TermTrees Closed 08/16/2019
Related to Edit - bug #8774: Reimplement term tree editors to implement the general save strategy Closed 12/17/2019
Related to Edit - bug #7994: Implement allowDuplicates for term trees in TaxEditor Duplicate 01/15/2019
Related to Edit - feature request #9337: Open issues for reimplementation of termtree editors Closed 11/30/2020
Follows Edit - feature request #8477: Implement support for TermCollection.allowDuplicates in TaxEditor Closed 08/16/2019
Copied from Edit - feature request #9643: New menu in term tree editor should have alternatives for flags New 06/01/2021

Associated revisions

Revision a3e8d11d (diff)
Added by Katja Luther 11 months ago

ref #8774: show which terms are duplicates in dialog

Revision b1d5c0e2 (diff)
Added by Katja Luther 5 months ago

ref #8776: disable allowDuplicate flag if tree contains duplicates

Revision f37fa367 (diff)
Added by Katja Luther 5 months ago

ref #8776: fix d&d for not allow duplicates

Revision b208934b (diff)
Added by Katja Luther 5 months ago

ref #8776: paste should only available if it is allowed.

Revision e7849426 (diff)
Added by Katja Luther 5 months ago

ref #8776: revert d&d check for duplicates

Revision bfcdd64e (diff)
Added by Katja Luther 5 months ago

ref #8776: fix d&d check for duplicates

Revision 9020f8ff (diff)
Added by Katja Luther 5 months ago

ref #8776: add all terms of the hierarchy to the list of the treeDto

Revision 093e7cd5 (diff)
Added by Katja Luther 5 months ago

ref #8776, #9630: d&d from voc to tree and disable time period if fact is disabled

Revision 37f2b410 (diff)
Added by Katja Luther 5 months ago

ref #8776: fix contains duplicates in dto

Revision 02c718f2 (diff)
Added by Katja Luther 5 months ago

ref #8776: correct enable/disable allowDuplicates

History

#1 Updated by Andreas Müller almost 2 years ago

  • Description updated (diff)

#2 Updated by Andreas Müller almost 2 years ago

  • Description updated (diff)

#3 Updated by Andreas Müller almost 2 years ago

  • Description updated (diff)

#4 Updated by Andreas Müller almost 2 years ago

  • Due date set to 08/19/2019
  • Start date changed from 12/17/2019 to 08/19/2019
  • Follows feature request #8477: Implement support for TermCollection.allowDuplicates in TaxEditor added

#5 Updated by Andreas Müller almost 2 years ago

  • Due date deleted (08/19/2019)
  • Target version changed from Unassigned CDM tickets to Release 5.13

#6 Updated by Andreas Müller almost 2 years ago

#7 Updated by Andreas Müller almost 2 years ago

#8 Updated by Andreas Müller almost 2 years ago

  • Related to bug #8774: Reimplement term tree editors to implement the general save strategy added

#9 Updated by Andreas Müller almost 2 years ago

Note: saving often does not work due to issues to be solved in #8774

#10 Updated by Andreas Müller almost 2 years ago

  • Related to bug #7994: Implement allowDuplicates for term trees in TaxEditor added

#11 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.13 to Release 5.14

#12 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.14 to Release 5.15

#13 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.15 to Release 5.18

#14 Updated by Andreas Müller 11 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

Looks like this is partly fixed already (at least first part of first issue). As it is related to #8774 we should try to fix it soon.

#15 Updated by Katja Luther 11 months ago

  • Status changed from In Progress to New
  • % Done changed from 10 to 0

Now the duplicates are checked on editor side and the message dialog shows which terms can not be added because they would create duplicates.

#16 Updated by Katja Luther 11 months ago

  • Description updated (diff)

#17 Updated by Katja Luther 11 months ago

  • Description updated (diff)

#18 Updated by Katja Luther 11 months ago

  • Description updated (diff)

#19 Updated by Andreas Müller 11 months ago

  • Status changed from New to In Progress

#20 Updated by Andreas Müller 11 months ago

#21 Updated by Katja Luther 11 months ago

  • Target version changed from Release 5.18 to Release 5.19

#22 Updated by Katja Luther 6 months ago

  • Target version changed from Release 5.19 to Release 5.25

#23 Updated by Katja Luther 5 months ago

  • Description updated (diff)

#24 Updated by Katja Luther 5 months ago

  • Description updated (diff)

#25 Updated by Katja Luther 5 months ago

  • Description updated (diff)

#26 Updated by Katja Luther 5 months ago

  • Description updated (diff)

#27 Updated by Katja Luther 5 months ago

  • Description updated (diff)

#28 Updated by Katja Luther 5 months ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review

#29 Updated by Andreas Müller 5 months ago

  • Description updated (diff)
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Everything works, only there is one open issue which was not yet on the list: d&d from a vocabulary is still possible but shouldn't if the term is a duplicate

#30 Updated by Andreas Müller 5 months ago

  • % Done changed from 0 to 40

#31 Updated by Andreas Müller 5 months ago

  • Target version changed from Release 5.25 to Release 5.24

#32 Updated by Andreas Müller 5 months ago

  • Copied from feature request #9643: New menu in term tree editor should have alternatives for flags added

#33 Updated by Andreas Müller 5 months ago

  • Description updated (diff)
  • Status changed from Feedback to Closed
  • % Done changed from 40 to 100

Seems to work as expected now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)