Project

General

Profile

Actions

bug #8776

closed

Open issues for TermCollection.allowDuplicates handling in TaxEditor

Added by Andreas Müller almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

  • The error message currently looks like an unhandled error. The message should only inform about the fact that duplicates are not allowed and therefore the selected area could not be added. No stacktrace should be shown (and also no stacktrace should be created! in any logfile as this should be a handled case).
    Also only 1 message should be shown if >1 terms are tried to be added which already exist.
    this was partly fixed and information about the doubled terms are added.

  • copied from #8477: do not allow editing the flag if duplicates exist in the collection

  • when changing the title of the tree the part which handles the details view area which holds the 3 flags (allow duplicates, is flat and order relevant) becomes orange. As these flags are not relevant for the titleCache this should not be the case this seems to be fixed in the meanwhile

  • "Paste" should not be available in context menu if the area already exists in the tree

  • d&d from 1 term tree to another in the same TermTreeEditor does currently not do the check (and therefore duplicates are possible), while d&d from e.g. term editor to term tree editor does check if duplicates exists (same way as described in first issue above)

  • d&d from a vocabulary to the term tree should not be possible if the term is a duplicate


Related issues

Related to EDIT - feature request #8476: Implement support for TermCollection.isFlat in TaxEditorClosedKatja Luther

Actions
Related to EDIT - feature request #8474: Make TermCollection.orderRelevant usable for TermTreesClosedKatja Luther

Actions
Related to EDIT - bug #8774: Reimplement term tree editors to implement the general save strategyClosedKatja Luther

Actions
Related to EDIT - bug #7994: Implement allowDuplicates for term trees in TaxEditorDuplicateKatja Luther

Actions
Related to EDIT - feature request #9337: Open issues for reimplementation of termtree editorsClosedKatja Luther

Actions
Follows EDIT - feature request #8477: Implement support for TermCollection.allowDuplicates in TaxEditorClosedPatrick Plitzner

Actions
Copied from EDIT - feature request #9643: New menu in term tree editor should have alternatives for flagsNewKatja Luther

Actions
Actions #1

Updated by Andreas Müller almost 3 years ago

  • Description updated (diff)
Actions #2

Updated by Andreas Müller almost 3 years ago

  • Description updated (diff)
Actions #3

Updated by Andreas Müller almost 3 years ago

  • Description updated (diff)
Actions #4

Updated by Andreas Müller almost 3 years ago

  • Due date set to 08/19/2019
  • Start date changed from 12/17/2019 to 08/19/2019
  • Follows feature request #8477: Implement support for TermCollection.allowDuplicates in TaxEditor added
Actions #5

Updated by Andreas Müller almost 3 years ago

  • Due date deleted (08/19/2019)
  • Target version changed from Unassigned CDM tickets to Release 5.13
Actions #6

Updated by Andreas Müller almost 3 years ago

Actions #7

Updated by Andreas Müller almost 3 years ago

Actions #8

Updated by Andreas Müller almost 3 years ago

  • Related to bug #8774: Reimplement term tree editors to implement the general save strategy added
Actions #9

Updated by Andreas Müller almost 3 years ago

Note: saving often does not work due to issues to be solved in #8774

Actions #10

Updated by Andreas Müller almost 3 years ago

  • Related to bug #7994: Implement allowDuplicates for term trees in TaxEditor added
Actions #11

Updated by Katja Luther over 2 years ago

  • Target version changed from Release 5.13 to Release 5.14
Actions #12

Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.14 to Release 5.15
Actions #13

Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.15 to Release 5.18
Actions #14

Updated by Andreas Müller almost 2 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

Looks like this is partly fixed already (at least first part of first issue). As it is related to #8774 we should try to fix it soon.

Actions #15

Updated by Katja Luther almost 2 years ago

  • Status changed from In Progress to New
  • % Done changed from 10 to 0

Now the duplicates are checked on editor side and the message dialog shows which terms can not be added because they would create duplicates.

Actions #16

Updated by Katja Luther almost 2 years ago

  • Description updated (diff)
Actions #17

Updated by Katja Luther almost 2 years ago

  • Description updated (diff)
Actions #18

Updated by Katja Luther almost 2 years ago

  • Description updated (diff)
Actions #19

Updated by Andreas Müller almost 2 years ago

  • Status changed from New to In Progress
Actions #20

Updated by Andreas Müller almost 2 years ago

Actions #21

Updated by Katja Luther almost 2 years ago

  • Target version changed from Release 5.18 to Release 5.19
Actions #22

Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.19 to Release 5.25
Actions #23

Updated by Katja Luther over 1 year ago

  • Description updated (diff)
Actions #24

Updated by Katja Luther over 1 year ago

  • Description updated (diff)
Actions #25

Updated by Katja Luther over 1 year ago

  • Description updated (diff)
Actions #26

Updated by Katja Luther over 1 year ago

  • Description updated (diff)
Actions #27

Updated by Katja Luther over 1 year ago

  • Description updated (diff)
Actions #28

Updated by Katja Luther over 1 year ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review

Actions #29

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Everything works, only there is one open issue which was not yet on the list: d&d from a vocabulary is still possible but shouldn't if the term is a duplicate

Actions #30

Updated by Andreas Müller over 1 year ago

  • % Done changed from 0 to 40
Actions #31

Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.25 to Release 5.24
Actions #32

Updated by Andreas Müller over 1 year ago

  • Copied from feature request #9643: New menu in term tree editor should have alternatives for flags added
Actions #33

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • Status changed from Feedback to Closed
  • % Done changed from 40 to 100

Seems to work as expected now.

Actions

Also available in: Atom PDF