Project

General

Profile

bug #8739

remaining issues for description detail page

Added by Patrick Plitzner 7 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

Copied from #8595

  • Evtl. will man auf aggr. Description von höheren Taxa nicht die Specimen als Quellen anzeigen, sondern die niedrigeren aggr. Description.

AM: Generally all descriptive data should be shown, not only structured descriptions. E.g. distribution data is still missing. => #8687


TODOs from Code review:

1.

DONE

description.inc#1179 :

$enclosing_tag = cdm_feature_block_element_tag_name($feature_block_settings); 

is unused, this breaks the feature block setting as_list (old bug)

2. Don't use <i> and <br> etc to apply styling, all styling must be applied through css

DONE cdm-dataportal|bea70813 & cdm-dataportal|753a8083

  1. pages.inc: render_cdm_description_link() ...
  2. pages.inc: $render_array[] = markup_to_render_array("Aggregation source from ".$description->created.'<br><br>');
  3. pages.inc: render_cdm_description() - $detail_html = (empty($description_string)?$link_text:$description_string).$iconlink."<br><br>";
  4. pages.inc: render_description_string()
              $descriptionString .= '<i>' . $element->feature->representation_L10n . '</i>: ' . $state_data . "; ";
            }
            break;
          case 'QuantitativeData':
            $descriptionString .= '<i>' . $element->feature->representation_L10n . '</i>: ' . compose_quant_stats($element) . "; ";
  1. pages.inc: compose_cdm_description()
if (isset($description->describedSpecimenOrObservation)) {
    $render_array[] = markup_to_render_array("<b>Specimen</b><br>");
    $render_array[] = markup_to_render_array(render_cdm_specimen_link($description->describedSpecimenOrObservation));
  }
  if (isset($description->taxon)) {
    $render_array[] = markup_to_render_array("<b>Taxon</b><br>");
    $render_array[] = markup_to_render_array(render_cdm_taxon($description->taxon));
  }

SampleSize:

diese Sache mit der SampleSize, die überall auftaucht, ist das schnell zu fixen? Das ist ziemlich irritierend.

  • warum werden die nur bei einem Teil der Characters in Klammern (wie es sein sollte), bei den anderen aber als "92 Sample Size" ausgegeben?
  • wir sollten in der Tabelle im Header hinter "States" erklärend anfügen: "(bracketed numbers denote sample size)" oder so, ähnlich bei der Description ...

===> #8766

Name der Description

Da war ich ungenau. Wenn das Taxon einen TaxonName hat, sollte der TaxonName.titleCache genommen werden, sonst wird’s zu lang. Nur wenn taxon.getName() == null dann taxon.titleCache nehmen. Wäre jedenfalls mein Vorschlag und machen wir an vielen andere Stellen so. Auf der Seite kommt dann ja auch nochmal der Link, wenn man es genau haben will.

===> #8779


Hallo,

hier wie besprochen noch ein paar Anmerkungen zur Portaldarstellung
zu http://test.e-taxonomy.eu/dataportal/preview/greece_bupleurum/cdm_dataportal/description/ff646ffe-0e6a-4edf-8aff-d3a5e0fdab11

  1. wir sollten in der Tabelle im Header hinter "States" erklärend anfügen: "(bracketed numbers denote sample size)" oder so, ähnlich bei der Description ... DONE: Note appears as caption below the table and feature block, the text is aligned right.
  2. bei numerischen Characters wird immer noch am Ende die Specimen-Zahl ausgegeben als e.g. "10 SampleSize", auch hier sollte stehen "[10]" - DONE
  3. Bei "stem width" wird als Minimum "0" angegeben: wie kommt das? Dateneingabe- oder -ausgabe-Fehler? REJETCED: this is a problem in the aggregation algorithm not in the dataportal.
    • es fehlt hier die Maßeinheit. Dateneingabe- oder -ausgabe-Fehler? - DONE: Problems solved by cdm-dataportal|ad7fa57c but nothing visible yet due to missing data.
    • abgesehen davon, dass die Mittelwertangabe zwischen Min und Max unüblich ist, sind 4 Nachkommastellen mindestens 2 zuviel. Das lässt sich doch sicher angeben? ==> #8771
    • Eine bessere Darstellung wäre ", mean = xx hinter Min+Max . ==> #8786
  4. Presence-Problematik: Hatten wir nicht mal eine Regel aufgestellt, wann die Angabe von Presence entfallen soll? Ganz schlimm: "Entire Plant present (28)"; siehe auch, im Gegensatz: "adventitious root presence present (2)"; spine presence present (2), absent(1)" ===> #8759
  5. Die seq. Referenzen bei den Taxanahmen sollten in solchen Zusammenhängen unbedingt entfallen, das ist nur krude und völlig überflüssig, da es ja eine Link aufs Taxon gibt; eigentlich sind sogar die Taxonautoren entbehrlich. ==> #8779

Schöne Grüße,
Norbert


Related issues

Related to Edit - bug #8687: Description page must show all DescriptionElement subclasses New 11/15/2019
Related to Edit - bug #8766: Aggregated Descriptions: show Sample size as [$SAMPLE_SIZE] Closed 12/13/2019
Related to Edit - task #8768: DISCUSS: place CdmLinks in a separate pseudo feature block? New 12/13/2019
Related to Edit - bug #8779: Description page: use render_taxon_or_name() for creating the page and description title and taxon links Closed 12/17/2019
Related to Edit - feature request #8714: description page: Show multiple datasets per description as list of links Resolved 11/21/2019
Related to Edit - bug #8788: Cloned descriptions do not show up in dataportal anymore Feedback 12/20/2019
Related to Edit - feature request #8798: description page: Show character hierarchy Resolved 01/07/2020
Follows Edit - feature request #8595: Create description detail page Closed 10/16/2019
Copied to Edit - feature request #8771: display of average value with precision so that it differs from min and max by one digit Resolved 12/17/2019
Copied to Edit - task #8786: Display of mean value with min max Resolved 12/19/2019

Associated revisions

Revision eab86ee2 (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8739 removing dead code

Revision 6722d9a5 (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8739 description page: explainig bracketed numbers

Revision 87aa88d6 (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8739 aggregated description feature block: explainig bracketed numbers

Revision ad7fa57c (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8739 description page: solving problems with unit display, order and spacing

Revision 3db61e83 (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8739 description page: improved dom and using stylesheets instead of html tags

Revision bea70813 (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8739 labels of CategoricalData and QuatitativeData stylable

Revision 753a8083 (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8739 description page better and stylable DOM

Revision 31d293b1 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8739 description table header left aligned (affects all data portal tables)

Revision 92e522db (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8739 description sources in alphabetical order

Revision e95b14dd (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8739 loading missing name for taxa in render_taxon_or_name()

Revision 209feb13 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8739 indenting description table entries by chraracter hierarchy

Revision 88e622d2 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8739 indenting description table entries by character hierarchy - bugfix

Revision fa094d60 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8739 table caption to the top an with smaller font

Revision cd3ea2e8 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8739 updated explanatory text for statistical values

History

#1 Updated by Patrick Plitzner 7 months ago

#2 Updated by Patrick Plitzner 7 months ago

#3 Updated by Patrick Plitzner 7 months ago

  • Due date set to 10/17/2019
  • Start date changed from 12/03/2019 to 10/17/2019
  • Follows feature request #8595: Create description detail page added

#4 Updated by Patrick Plitzner 7 months ago

  • Description updated (diff)

#5 Updated by Patrick Plitzner 7 months ago

  • Due date deleted (10/17/2019)
  • Start date deleted (10/17/2019)

#6 Updated by Andreas Müller 7 months ago

  • Description updated (diff)

#7 Updated by Andreas Müller 7 months ago

  • Related to bug #8687: Description page must show all DescriptionElement subclasses added

#8 Updated by Andreas Müller 7 months ago

  • Assignee changed from Patrick Plitzner to Andreas Kohlbecker
  • Target version changed from 287 to Release 5.12

#9 Updated by Andreas Kohlbecker 7 months ago

  • Priority changed from New to Highest

#10 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#11 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#12 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)
  • Status changed from New to In Progress

#13 Updated by Andreas Kohlbecker 7 months ago

  • Related to bug #8766: Aggregated Descriptions: show Sample size as [$SAMPLE_SIZE] added

#14 Updated by Andreas Kohlbecker 7 months ago

  • Related to task #8768: DISCUSS: place CdmLinks in a separate pseudo feature block? added

#15 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

removing obsolete conversation records from the issue description since these points are already handled in other issues: #8724, #8766, #8686

#16 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#17 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#18 Updated by Andreas Kohlbecker 7 months ago

  • Copied to feature request #8771: display of average value with precision so that it differs from min and max by one digit added

#19 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#20 Updated by Andreas Kohlbecker 7 months ago

  • Related to bug #8779: Description page: use render_taxon_or_name() for creating the page and description title and taxon links added

#21 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#22 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#23 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#24 Updated by Andreas Kohlbecker 7 months ago

  • Related to feature request #8714: description page: Show multiple datasets per description as list of links added

#25 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#26 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)
  • % Done changed from 0 to 30

#27 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#28 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#29 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#30 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#31 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#32 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#33 Updated by Andreas Kohlbecker 7 months ago

  • Copied to task #8786: Display of mean value with min max added

#34 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#35 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)

#36 Updated by Andreas Kohlbecker 7 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 30 to 50

AS far as I see, this ticket is either solved or remaining issues are copied to new tickets.

Therefore I suggest closing this ticket.

#37 Updated by Andreas Müller 7 months ago

  • Related to bug #8788: Cloned descriptions do not show up in dataportal anymore added

#38 Updated by Andreas Kohlbecker 6 months ago

#39 Updated by Andreas Müller 3 months ago

  • Description updated (diff)

#40 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • % Done changed from 50 to 100

This all seems to be implemented or moved to other tickets. Norbert, please reopen if you think some issues are not fully fixed.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)