Project

General

Profile

bug #8718

polytomousKey page: better handling of invalid uuids

Added by Andreas Kohlbecker 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
11/22/2019
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

ich habe gerade gesehen, dass ein PolyKey, wenn dessen uuid nicht stimmt unschöne Fehler schmeißt:

http://test.e-taxonomy.eu/dataportal/preview/greece_bupleurum/cdm_dataportal/polytomousKey/2e37d588-16c9-4e57-8b77-c33d3a63990a

Hier sollten wir, genauso wie bei den Taxa eine "PK does not exist" Meldung einbauen.

Associated revisions

Revision 4d9660ef (diff)
Added by Andreas Kohlbecker 2 months ago

fix #8718 humane error message in case the page does not exists: polytomous key, description, media, reference

Revision de017852 (diff)
Added by Andreas Kohlbecker 2 months ago

fix #8718 humane error message in case the page does not exists: bug fixes and revering erroneously comitted change

History

#1 Updated by Andreas Müller 3 months ago

  • Tags set to additivity

#2 Updated by Andreas Müller 3 months ago

Patrick, this is relevant for additivity (currently PKs get a new uuid with every generation) so we may think about moving it to the additivity milestone.

#3 Updated by Andreas Kohlbecker 2 months ago

  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.12

#4 Updated by Andreas Kohlbecker 2 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#6 Updated by Andreas Müller 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Instead of saying "page not found" can't we do the same as for taxa and say "xxx does not exist". This sounds a bit more specific. In future we could then be even more distinct and say "xxx was deleted" if it existed before (info taken from AUD tables). But not necessary now.

Page not found usually sounds like "the whole website has been moved or restructured", therefore I prefer "does not exist".

#7 Updated by Andreas Kohlbecker 2 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

Andreas Müller wrote:

Instead of saying "page not found" can't we do the same as for taxa and say "xxx does not exist". This sounds a bit more specific. In future we could then be even more distinct and say "xxx was deleted" if it existed before (info taken from AUD tables). But not necessary now.

Page not found usually sounds like "the whole website has been moved or restructured", therefore I prefer "does not exist".

It is actually implemented the way you suggest, but two problems prevented you from seeing this:

  1. The links I gave you where pointing to the production server - fixed
  2. The data portal code on the test server could not be updated by pulling due to local changes - I will adapt the jenkins job to avoid such problems in the future

#8 Updated by Andreas Müller 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Yes it seems to work now.

Only minor issue: instead of Named Area we could say simply "Area". Named area is a bit a technical term.
In general this ticket can be closed.

#9 Updated by Andreas Kohlbecker 2 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100

"Named area" is the term being used in general in the dataportal, but this is another issue - closing this ticket.

#10 Updated by Andreas Kohlbecker 2 months ago

  • Description updated (diff)

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)